Re: [O] [PATCH] add :session support for ob-js.el

Thanks for your refactoring. I must be recklessof this. I will be careful next time. On 03/26/2018 05:09 AM, Nicolas Goaziou wrote: Hello, stardiviner writes: I attached my new generated patches. On 03/17/2018 07:14 PM, Nicolas Goaziou wrote: Some comments follow.

Re: [O] [PATCH] add :session support for ob-js.el

Hello, stardiviner writes: > I attached my new generated patches. > > > On 03/17/2018 07:14 PM, Nicolas Goaziou wrote: >> Some comments follow. >>> + (result (if (not (string= (cdr (assq :session params)) "none")) >> You can integrate the test above in the `cond':

Re: [O] [PATCH] add :session support for ob-js.el

I attached my new generated patches. On 03/17/2018 07:14 PM, Nicolas Goaziou wrote: Some comments follow. + (result (if (not (string= (cdr (assq :session params)) "none")) You can integrate the test above in the `cond': (cond ((string= "none" (cdr (assq :session params)))

Re: [O] [PATCH] add :session support for ob-js.el

Hello, stardiviner writes: > updated my code. I followed your suggestions. But modify code one by > one messed code up. So I merge all related commits into one commit. > Sorry for this. Some comments follow. > +(result (if (not (string= (cdr (assq :session

Re: [O] [PATCH] add :session support for ob-js.el

updated my code. I followed your suggestions. But modify code one by one messed code up. So I merge all related commits into one commit. Sorry for this. >From 23ef274fd418c876be85871f8da34738ae15ffd5 Mon Sep 17 00:00:00 2001 From: stardiviner Date: Thu, 8 Mar 2018

Re: [O] [PATCH] add :session support for ob-js.el

Hello, stardiviner writes: > I added org-mode babel ob-js.el header argument :session. > > Following packages :session are supported: > > - skewer-mode > > - js-comint > > - Indium I don't know any of these, but here come some comments about the code. > then create.