Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

2018-03-26 Thread stardiviner
After dive into scel source code, I use cmake build fix. This seems an old problem. Now fixed. On 03/26/2018 07:38 PM, stardiviner wrote: You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed. Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in` for

Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

2018-03-26 Thread stardiviner
You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed. Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in` for built-time defaults. When user load sclang from source code of `scel`. This will cause error. Really don't understand why you have to `(require

Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

2018-03-25 Thread Nicolas Goaziou
Hello, Maxim Cournoyer writes: > The attached patch fixes a byte compilation issue in ob-sclang.el. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] contrib: ob-sclang: Fix compilation issue.

2018-03-24 Thread stardiviner
Hi, @MaximI'm the author of `ob-sclang.el`. Whyneed to require `sclang` instead of `sclang-interp`? ob-sclangused functions are all in `sclang-interp.el` file. No need to require `sclang`. And I checked out `scel` source code, have not found update. Might because `sclang-interp`? On