Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets

Hello, Sebastian Reuße writes: > Fair enough. Thank you! FWIW, is there some handy table to consult on > newly supported functions by Emacs version? Or do you have it all > memorized from the Emacs changelogs? When I encounter a suspicious function, i.e., a function I have

Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets

Nicolas Goaziou writes: > Sebastian Reuße writes: >> It didn’t feel right copy-pasting the tests wholesale, so I made a >> helper-macro. I checked the ert output by forcing a failure and the >> failure explanation looks as expected. Does this work for

Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets

Hello, Sebastian Reuße writes: > Sure. Have a look at the follow-up patch and let me know what you > think. Thank you! > It didn’t feel right copy-pasting the tests wholesale, so I made a > helper-macro. I checked the ert output by forcing a failure and the > failure

Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets

Hello Nicolas, Nicolas Goaziou writes: > Nitpick: Sections in test-org.el are sorted alphabetically. So the new > "Refile" section could go between "Radio Targets" and "Sparse trees". Thank you, I hadn’t noticed. > Would it be possible to split this big test into

Re: [O] [PATCH 1/2] Add tests for org-refile-get-targets

Hello, Sebastian Reuße writes: > * testing/lisp/test-org.el: Add test. > --- Thank you. > testing/examples/refile/a.org | 6 ++ > + > +;;; org-refile Nitpick: Sections in test-org.el are sorted alphabetically. So the new "Refile" section could go between "Radio