Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-16 Thread Charles C. Berry
On Fri, 16 May 2014, Rainer M Krug wrote: Sorry for coming back to your suggestions so late, but I did some thinking about the approach. Comments inline below. No problem. I am about to leave town and my email for a couple of weeks, so I might not be able to reply to further correspondence

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Rainer M Krug
Eric Schulte schulte.e...@gmail.com writes: Rainer M Krug rai...@krugs.de writes: Bastien b...@gnu.org writes: Hi Rainer, Rainer M Krug r.m.k...@gmail.com writes: I'll look at it again tomorrow and let you know as I made some changes since then. Do you prefer one patch to several? Up

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Suvayu Ali
On Mon, May 12, 2014 at 10:33:48AM +0200, Rainer M Krug wrote: Eric Schulte schulte.e...@gmail.com writes: Rainer M Krug rai...@krugs.de writes: Bastien b...@gnu.org writes: Hi Rainer, Rainer M Krug r.m.k...@gmail.com writes: I'll look at it again tomorrow and let you know as

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Rainer M Krug
Suvayu Ali fatkasuvayu+li...@gmail.com writes: On Mon, May 12, 2014 at 10:33:48AM +0200, Rainer M Krug wrote: Eric Schulte schulte.e...@gmail.com writes: Rainer M Krug rai...@krugs.de writes: Bastien b...@gnu.org writes: Hi Rainer, Rainer M Krug r.m.k...@gmail.com writes:

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Eric Schulte
If not would you mind submitting a version of the patches split into multiple commits with as much of the hard-coded R code as feasible placed into customizable variables along the lines of the `org-babel-R-assign-elisp-function' variable suggested by Charles. I am thinking of actually not

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Rainer M Krug
Eric Schulte schulte.e...@gmail.com writes: If not would you mind submitting a version of the patches split into multiple commits with as much of the hard-coded R code as feasible placed into customizable variables along the lines of the `org-babel-R-assign-elisp-function' variable suggested

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-12 Thread Charles C. Berry
On Mon, 12 May 2014, Rainer M Krug wrote: Eric Schulte schulte.e...@gmail.com writes: If not would you mind submitting a version of the patches split into multiple commits with as much of the hard-coded R code as feasible placed into customizable variables along the lines of the

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Rainer M Krug
Rainer M Krug r.m.k...@gmail.com writes: Envoyé de mon iPhone Le 8 mai 2014 à 04:26, Charles Berry ccbe...@ucsd.edu a écrit : Eric Schulte schulte.eric at gmail.com writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Rainer M Krug
Rainer M Krug rai...@krugs.de writes: Rainer M Krug r.m.k...@gmail.com writes: Envoyé de mon iPhone Le 8 mai 2014 à 04:26, Charles Berry ccbe...@ucsd.edu a écrit : Eric Schulte schulte.eric at gmail.com writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Bastien
Hi Rainer, Rainer M Krug r.m.k...@gmail.com writes: I'll look at it again tomorrow and let you know as I made some changes since then. Do you prefer one patch to several? Up to Eric's taste -- but in general I think a series of patches is better, it allows you to isolate and fix conflicts

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Rainer M Krug
Bastien b...@gnu.org writes: Hi Rainer, Rainer M Krug r.m.k...@gmail.com writes: I'll look at it again tomorrow and let you know as I made some changes since then. Do you prefer one patch to several? Up to Eric's taste -- but in general I think a series of patches is better, it allows

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-09 Thread Eric Schulte
Rainer M Krug rai...@krugs.de writes: Bastien b...@gnu.org writes: Hi Rainer, Rainer M Krug r.m.k...@gmail.com writes: I'll look at it again tomorrow and let you know as I made some changes since then. Do you prefer one patch to several? Up to Eric's taste -- but in general I think a

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-08 Thread Rainer M Krug
Le 7 mai 2014 à 12:27, Eric Schulte schulte.e...@gmail.com a écrit : Rainer M Krug rai...@krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session.

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-08 Thread Rainer M Krug
Envoyé de mon iPhone Le 8 mai 2014 à 04:26, Charles Berry ccbe...@ucsd.edu a écrit : Eric Schulte schulte.eric at gmail.com writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-07 Thread Eric Schulte
Rainer M Krug rai...@krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session. Thanks, Rainer Hi Rainer, Thanks for these patches. I don't have the

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-07 Thread Charles Berry
Eric Schulte schulte.eric at gmail.com writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session. Thanks,

Re: [O] [babel][PATCHES] ob-R patches for review

2014-05-01 Thread Rainer M Krug
Charles C. Berry ccbe...@ucsd.edu writes: On Wed, 30 Apr 2014, Rainer M Krug wrote: Charles Berry ccbe...@ucsd.edu writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to

Re: [O] [babel][PATCHES] ob-R patches for review

2014-04-30 Thread Rainer M Krug
Charles Berry ccbe...@ucsd.edu writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session. Rainer, I have

Re: [O] [babel][PATCHES] ob-R patches for review

2014-04-30 Thread Charles C. Berry
On Wed, 30 Apr 2014, Rainer M Krug wrote: Charles Berry ccbe...@ucsd.edu writes: Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the

Re: [O] [babel][PATCHES] ob-R patches for review

2014-04-29 Thread Charles Berry
Rainer M Krug Rainer at krugs.de writes: Hi Attached please find seven patches for review to implement the storing of org variables in their own environment and to make the org-issued R code look nicer in the R session. Rainer, I have suggestions and a concern. I suggest that you