Re: [O] Adding new table rows/cols in a formula update

2014-12-08 Thread Achim Gratz
Achim Gratz writes: > Dima Kogan writes: >> --- a/testing/lisp/test-org-table.el > […] >> +(condition-case > […] >> + "#+TBLFM: @1$2=5") >> + ('user-error t))) > > That part of the test, specifically the attempt to catch the error is > not working for me on Windows, most likely because

Re: [O] Adding new table rows/cols in a formula update

2014-10-13 Thread Achim Gratz
Dima Kogan writes: > --- a/testing/lisp/test-org-table.el […] > +(condition-case […] > + "#+TBLFM: @1$2=5") > + ('user-error t))) That part of the test, specifically the attempt to catch the error is not working for me on Windows, most likely because I use an older version of Emacs t

Re: [O] Adding new table rows/cols in a formula update

2014-10-12 Thread Bastien
Nicolas Goaziou writes: > Hello, > > Bastien writes: > >> Can one of you add Dima to >> http://orgmode.org/worg/org-contribute.html#contributors_with_fsf_papers >> >> ? > > Done. Thanks! -- Bastien

Re: [O] Adding new table rows/cols in a formula update

2014-10-12 Thread Nicolas Goaziou
Hello, Bastien writes: > Can one of you add Dima to > http://orgmode.org/worg/org-contribute.html#contributors_with_fsf_papers > > ? Done. Regards, -- Nicolas Goaziou0x80A93738

Re: [O] Adding new table rows/cols in a formula update

2014-10-12 Thread Bastien
Hi, Nicolas Goaziou writes: >> Here's the same patch without the TINYCHANGE marker, if that's >> helpful. > > Applied. Thank you for this work. Indeed, thanks. I double-checkedd and found the copyright assignment for Dima. Can one of you add Dima to http://orgmode.org/worg/org-contribute.html

Re: [O] Adding new table rows/cols in a formula update

2014-10-12 Thread Nicolas Goaziou
Hello, Dima Kogan writes: > Here's the same patch without the TINYCHANGE marker, if that's > helpful. Applied. Thank you for this work. Regards, -- Nicolas Goaziou

Re: [O] Adding new table rows/cols in a formula update

2014-10-11 Thread Dima Kogan
Nicolas Goaziou writes: >> Thanks for your work on this, the patch looks good but it cannot be >> accepted as a "tiny change". Would you be willing to sign the FSF >> copyright assignment papers? > > Actually, it's not a tiny change. He signed copyright assignment > already. See http://permalink

Re: [O] Adding new table rows/cols in a formula update

2014-10-11 Thread Nicolas Goaziou
Hello, Bastien writes: > Thanks for your work on this, the patch looks good but it cannot be > accepted as a "tiny change". Would you be willing to sign the FSF > copyright assignment papers? Actually, it's not a tiny change. He signed copyright assignment already. See http://permalink.gmane.o

Re: [O] Adding new table rows/cols in a formula update

2014-10-11 Thread Bastien
Hi Dima, Dima Kogan writes: > OK. New patch attached. Thanks for your work on this, the patch looks good but it cannot be accepted as a "tiny change". Would you be willing to sign the FSF copyright assignment papers? If yes, please fill in the form from here: http://orgmode.org/cgit.cgi/org-m

Re: [O] Adding new table rows/cols in a formula update

2014-10-10 Thread Dima Kogan
Nicolas Goaziou writes: > Would you mind providing a test for it in org-test-table.el and an entry > in ORG-NEWS? > > The commit message should be something like the following... OK. New patch attached. >From 273e642c937f0e12a2f71cf6499415406d708629 Mon Sep 17 00:00:00 2001 From: Dima Kogan Da

Re: [O] Adding new table rows/cols in a formula update

2014-10-10 Thread Nicolas Goaziou
Hello, Dima Kogan writes: > Sure. Updated patch attached. Thanks. It looks good. Would you mind providing a test for it in org-test-table.el and an entry in ORG-NEWS? > Subject: [PATCH] org-table.el: field formulas can now create columns as needed > > (org-table-recalculate): use the new org-

Re: [O] Adding new table rows/cols in a formula update

2014-10-03 Thread Dima Kogan
Nick Dokos writes: > Nicolas Goaziou writes: > > Does it need sanity checking? A typo in a formula can create "billions > and billions"[fn:1] of columns inadvertently. Sure. Updated patch attached. >From 06f09e58a0f8b62429dda2faa913e297218b67b2 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date:

Re: [O] Adding new table rows/cols in a formula update

2014-10-01 Thread Nick Dokos
Nicolas Goaziou writes: > Hello, > > Dima Kogan writes: > >> OK. Patch attached. > > Thanks for your patch. Some comments follow. > >> From 3b6581c647cb87f0d3e8cee94ce2fb1fb122d3fd Mon Sep 17 00:00:00 2001 >> From: Dima Kogan >> Date: Tue, 30 Sep 2014 22:36:21 -0700 >> Subject: [PATCH] Field fo

Re: [O] Adding new table rows/cols in a formula update

2014-10-01 Thread Dima Kogan
Hi. Thanks for replying. Nicolas Goaziou writes: > Thanks for your patch. Some comments follow. > >> From 3b6581c647cb87f0d3e8cee94ce2fb1fb122d3fd Mon Sep 17 00:00:00 2001 >> From: Dima Kogan >> Date: Tue, 30 Sep 2014 22:36:21 -0700 >> Subject: [PATCH] Field formulas can now add columns as nee

Re: [O] Adding new table rows/cols in a formula update

2014-10-01 Thread Nicolas Goaziou
Hello, Dima Kogan writes: > OK. Patch attached. Thanks for your patch. Some comments follow. > From 3b6581c647cb87f0d3e8cee94ce2fb1fb122d3fd Mon Sep 17 00:00:00 2001 > From: Dima Kogan > Date: Tue, 30 Sep 2014 22:36:21 -0700 > Subject: [PATCH] Field formulas can now add columns as needed > >

Re: [O] Adding new table rows/cols in a formula update

2014-09-30 Thread Dima Kogan
>> Dima Kogan writes: >> >> > Suppose I have this .org file: >> > >> > | | >> > #+TBLFM: @1$2=5 >> > >> > It's a 1x1 table with a formula. The formula sets a cell that's out of >> > bounds in the table, so evaluating this formula results in an error. >> > How set-in-stone is this behavior? I

Re: [O] Adding new table rows/cols in a formula update

2014-09-30 Thread Subhan Michael Tindall
@gnu.org] On > Behalf Of Dima Kogan > Sent: Tuesday, September 30, 2014 12:28 PM > To: emacs-orgmode@gnu.org > Subject: Re: [O] Adding new table rows/cols in a formula update > > Dima Kogan writes: > > > Suppose I have this .org file: > > > > | | > >

Re: [O] Adding new table rows/cols in a formula update

2014-09-30 Thread Dima Kogan
Dima Kogan writes: > Suppose I have this .org file: > > | | > #+TBLFM: @1$2=5 > > It's a 1x1 table with a formula. The formula sets a cell that's out of > bounds in the table, so evaluating this formula results in an error. How > set-in-stone is this behavior? I haven't dug too deeply into th