Re: [O] org-pdfview-open doesn't work anymore

2016-02-10 Thread Julien Cubizolles
Nicolas Goaziou writes: > I think the simplest solution may be to follow the advice in ORG-NEWS > and use > > (lambda (file link) (org-pdfview-open file)) It's working, thanks. Julien.

Re: [O] org-pdfview-open doesn't work anymore

2016-02-07 Thread Nicolas Goaziou
Hello, Michael Brand writes: > Remixed patch for review attached. It looks good. Please apply it on master. Thank you. Regards, -- Nicolas Goaziou

Re: [O] org-pdfview-open doesn't work anymore

2016-02-07 Thread Michael Brand
Hi Nicolas On Sat, Feb 6, 2016 at 5:41 PM, Nicolas Goaziou wrote: > IMO, notifying user that there's something rotten in the state of > `org-file-apps' is enough. There's no need to go into the gory details > of the problem. I agree and finally found what I was missing:

Re: [O] org-pdfview-open doesn't work anymore

2016-02-06 Thread Nicolas Goaziou
Hello, Michael Brand writes: > I just notice that in our case at least in case of wrong-type-argument the > `cmd' is missing, so I suggest > > ((wrong-number-of-arguments wrong-type-argument invalid-function) > (user-error "Please see Org News for version

Re: [O] org-pdfview-open doesn't work anymore

2016-02-06 Thread Michael Brand
Hi Nicolas On Fri, Feb 5, 2016 at 11:43 PM, Nicolas Goaziou wrote: > Michael Brand writes: >> + ;; FIXME: Remove this check when most default installations of >> + ;; Emacs have at least Org 9.0. >> + ((wrong-number-of-arguments

Re: [O] org-pdfview-open doesn't work anymore

2016-02-05 Thread Nicolas Goaziou
Hello, Michael Brand writes: > + ;; FIXME: Remove this check when most default installations of > + ;; Emacs have at least Org 9.0. > + (let ((arglist (help-function-arglist cmd))) > + (when (or (memq ' arglist) > + (memq ' arglist) >

Re: [O] org-pdfview-open doesn't work anymore

2016-02-05 Thread Michael Brand
Hi Julien On Fri, Feb 5, 2016 at 6:46 AM, Julien Cubizolles wrote: > I've been using org-pdfview (from > https://github.com/markus1189/org-pdfview) to have org-mode open pdf > files generated during export. > > --8<---cut

Re: [O] org-pdfview-open doesn't work anymore

2016-02-05 Thread Nicolas Goaziou
Hello, Michael Brand writes: > + ;; FIXME: Remove this check when most default installations of > + ;; Emacs have at least Org 9.0. > + ((wrong-number-of-arguments invalid-function) > + (user-error > + (concat > +"Please see Org News

Re: [O] org-pdfview-open doesn't work anymore

2016-02-05 Thread Michael Brand
Hi Nicolas On Fri, Feb 5, 2016 at 6:22 PM, Nicolas Goaziou wrote: > Michael Brand writes: >> + ;; FIXME: Remove this check when most default installations of >> + ;; Emacs have at least Org 9.0. >> + (let ((arglist

Re: [O] org-pdfview-open doesn't work anymore

2016-02-05 Thread Nicolas Goaziou
Hello, Michael Brand writes: > Hi Julien > > On Fri, Feb 5, 2016 at 6:46 AM, Julien Cubizolles > wrote: >> I've been using org-pdfview (from >> https://github.com/markus1189/org-pdfview) to have org-mode open pdf >> files generated during

Re: [O] org-pdfview-open doesn't work anymore

2016-02-05 Thread Michael Brand
Hi Nicolas On Fri, Feb 5, 2016 at 9:33 AM, Michael Brand wrote: > Due to lexical binding in org.el there was a change in > `org-file-apps', see Org News for version 9.0 and e. g. this thread: > http://thread.gmane.org/gmane.emacs.orgmode/104272 > I think the most