Re: [PATCH] Fix some emacs-30 byte-compile warnings

2024-05-12 Thread Ihor Radchenko
Ihor Radchenko writes: > It is clearly a bug of some kind - the code is not doing what it > intended originally. But we need to understand org-table.el better to > fix this... Upon further review, I dropped that branch of if completely.

Re: [PATCH] Fix some emacs-30 byte-compile warnings

2023-02-17 Thread Robert Pluim
> On Fri, 17 Feb 2023 14:08:04 +, Ihor Radchenko > said: Ihor> Robert Pluim writes: Ihor> 3 unexpected results: Ihor> FAILED test-org-table/copy-field Ihor> FAILED test-org-table/references/mode-string-N Ihor> FAILED test-org-table/references/mode-string-none

Re: [PATCH] Fix some emacs-30 byte-compile warnings

2023-02-17 Thread Ihor Radchenko
Robert Pluim writes: > Ihor> 3 unexpected results: > Ihor>FAILED test-org-table/copy-field > Ihor>FAILED test-org-table/references/mode-string-N > Ihor>FAILED test-org-table/references/mode-string-none > > Hmm, at least the first one is because the code in the 't'

Re: [PATCH] Fix some emacs-30 byte-compile warnings

2023-01-23 Thread Robert Pluim
> On Mon, 23 Jan 2023 14:04:42 +, Ihor Radchenko > said: Ihor> Robert Pluim writes: >> The emacs 30 byte-compiler warns about uses of `eq' >> and similar with constant strings which might have unintended >> semantics. Patch is against emacs master. Ihor>

Re: [PATCH] Fix some emacs-30 byte-compile warnings

2023-01-23 Thread Ihor Radchenko
Robert Pluim writes: > The emacs 30 byte-compiler warns about uses of `eq' > and similar with constant strings which might have unintended > semantics. Patch is against emacs master. Thanks, but it will break some tests: 3 unexpected results: FAILED test-org-table/copy-field FAILED