Maxim Nikulin writes:
> I hope, I have addressed other your comments in the updated patch.
>
> commit 5eca7764d94dd46b9f9a7792d1b786a3f03b20b6
> Author: Max Nikulin
> Date: Wed Feb 17 16:35:58 2021 +
>
> org.el: Avoid xdg-open silent failure
Thanks. A note for future patches: your pat
On 19/03/2021 10:50, Kyle Meyer wrote:
Maxim Nikulin writes:
A few comments in addition to Eli's advice to drop the
(eq system-type 'gnu/linux) condition...
Feel free to commit the change suggested in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44824#82
instead of this patch.
+(defun org--e
Maxim Nikulin writes:
> org.el: Avoid xdg-open silent failure
>
> * lisp/org.el (org-open-file): Use 'pipe :connection-type instead of
> 'pty to prevent killing of background process on handler exit.
>
> Problem happens only in some desktop environments where configured
>
On 19/02/2021 21:54, Eli Zaretskii wrote:
From: Maxim Nikulin
Date: Fri, 19 Feb 2021 19:29:49 +0700
On Windows Emacs always uses pipes, because we don't have PTYs there.
And there's no xdg-open on MS-Windows anyway, so it's a moot point.
Should I consider your response as a suggestion to remo
> From: Maxim Nikulin
> Date: Fri, 19 Feb 2021 19:29:49 +0700
> Cc: 44...@debbugs.gnu.org
>
> > On Windows Emacs always uses pipes, because we don't have PTYs there.
> > And there's no xdg-open on MS-Windows anyway, so it's a moot point.
>
> Should I consider your response as a suggestion to rem
On 18/02/2021 21:48, Eli Zaretskii wrote:
From: Maxim Nikulin
Date: Thu, 18 Feb 2021 19:56:03 +0700
I could not estimate effect of such change on windows, so pipe process
is used only on linux. I am unsure concerning mac however.
On Windows Emacs always uses pipes, because we don't have PTYs t
> From: Maxim Nikulin
> Date: Thu, 18 Feb 2021 19:56:03 +0700
> Cc: 44...@debbugs.gnu.org
>
> I could not estimate effect of such change on windows, so pipe process
> is used only on linux. I am unsure concerning mac however.
On Windows Emacs always uses pipes, because we don't have PTYs there.
