Re: eldoc recursion error

2020-09-20 Thread Kyle Meyer
This was resolved by the thread at . Although the first message in that thread had an In-Reply-To header pointing to a message in this thread, it didn't have a proper References header, so I don't think will pick up

Re: eldoc recursion error

2020-09-20 Thread Kyle Meyer
James N. V. Cash writes: > Kyle Meyer writes: > >> Does your cider test case above break if we use >> eldoc-print-current-symbol-info without relaying the callback? That is, >> this squashed into your patch: > > My concern with using the eldoc-print-current-symbol-info is that it's > now

Re: eldoc recursion error

2020-09-20 Thread James N . V . Cash
Kyle Meyer writes: > All right, so we can't get by without using eldoc--make-callback here? > Relying on a symbol marked with "--" makes me uneasy, and I'd like to > avoid it if possible. Yeah, good point. I was doing that so I could honour the setting of eldoc-documentation-strategy. I don't

Re: eldoc recursion error

2020-09-20 Thread Kyle Meyer
James N. V. Cash writes: > Indeed, testing with an eldoc backend (a personally hacked-up version of > clojure's cider) that actually uses the callback, it wasn't working with > the previous approach. I've attached a patch that addresses the > previously-mentioned issues as well as this. [...] >

Re: eldoc recursion error

2020-09-20 Thread James N . V . Cash
James N. V. Cash writes: > I was just thinking more about this, and I'm concerned I might need to > change things around a little bit more. The closure that > org-eldoc-get-mode-local-documentation-function now returns under Emacs > 28 doesn't take any arguments and instead lets the >

Re: eldoc recursion error

2020-09-20 Thread James N . V . Cash
Kyle Meyer writes: > Using lexical-let here is problematic because it's obsolete since Emacs > 24. Taking a quick glance, I don't see any issues with switching this > file over to lexical binding by adding " -*- lexical-binding: t; -*-" to > the first line. Cool, will do. I was concerned that

Re: eldoc recursion error

2020-09-19 Thread Kyle Meyer
James N. V. Cash writes: > Kyle Meyer writes: >> Okay, so when eldoc-documentation-functions is defined (Emacs >=28), we >> take the first function and go with it. That might not be exactly what >> you'd see in the native buffer, depending on whether there are other >> members of

Re: eldoc recursion error

2020-09-17 Thread James N . V . Cash
Kyle Meyer writes: > Thanks for the patch! For information about the expected commit message > format, please see . Ah will do, thanks! I'm still learning how to work with the email & patch-based workflow. > Okay, so when

Re: eldoc recursion error

2020-09-16 Thread Kyle Meyer
James N V Cash writes: > I've attached a patch that addresses the recursion issue with Emacs 28 > and shows eldoc properly with example python. It presumably should act > the same with older versions of Emacs, although I haven't tested. Thanks for the patch! For information about the expected

Re: eldoc recursion error

2020-09-15 Thread James N V Cash
I've attached a patch that addresses the recursion issue with Emacs 28 and shows eldoc properly with example python. It presumably should act the same with older versions of Emacs, although I haven't tested. diff --git a/contrib/lisp/org-eldoc.el b/contrib/lisp/org-eldoc.el index

Re: eldoc recursion error

2020-09-10 Thread Kyle Meyer
Matt Price writes: > On Tue, Sep 8, 2020 at 11:27 AM Matt Price wrote: >> On Tue, Sep 8, 2020 at 10:53 AM Bastien wrote: >> >>> Matt Price writes: >>> >>> > In a new org file, add these lines: >>> > >>> > #+begin_src python >>> > print >>> > #+end_src >>> > >>> > position cursor inside block

Re: eldoc recursion error

2020-09-08 Thread Matt Price
On Tue, Sep 8, 2020 at 11:27 AM Matt Price wrote: > > > On Tue, Sep 8, 2020 at 10:53 AM Bastien wrote: > >> Hi Matt, >> >> Matt Price writes: >> >> > In a new org file, add these lines: >> > >> > #+begin_src python >> > print >> > #+end_src >> > >> > position cursor inside block and the error

Re: eldoc recursion error

2020-09-08 Thread Matt Price
On Tue, Sep 8, 2020 at 10:53 AM Bastien wrote: > Hi Matt, > > Matt Price writes: > > > In a new org file, add these lines: > > > > #+begin_src python > > print > > #+end_src > > > > position cursor inside block and the error message occurs. > > I can't reproduce the bug. What version of Emacs

Re: eldoc recursion error

2020-09-08 Thread Bastien
Hi Matt, Matt Price writes: > In a new org file, add these lines: > > #+begin_src python > print > #+end_src > > position cursor inside block and the error message occurs. I can't reproduce the bug. What version of Emacs are you using? Can you give a recipe starting with emacs -q? Thanks!

Re: eldoc recursion error

2020-09-08 Thread Matt Price
On Tue, Sep 8, 2020 at 10:25 AM Bastien wrote: > Hi Matt, > > can you provide a recipe to reproduce the problem? > > oops, sorry, that was stupid. In a new org file, add these lines: #+begin_src python print #+end_src position cursor inside block and the error message occurs.

Re: eldoc recursion error

2020-09-08 Thread Bastien
Hi Matt, can you provide a recipe to reproduce the problem? Thanks, -- Bastien

eldoc recursion error

2020-09-08 Thread Matt Price
I know there have been a couple of updates to org-eldoc lately. After updating to current master, I get this error in source blocks if eldoc mode is turned on: eldoc error: (error Lisp nesting exceeds ‘max-lisp-eval-depth’) Is there an easy fix for this? is it a generic eldoc problem or