Re: ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-30 Thread Ihor Radchenko
Daniel Kraus writes: >> Let me know if you need any help with the fix. > > I feel adding session support for babashka and nbb (and maybe a future > clojure-cli backend) > makes most sense. > Relying on `inf-clojure` would make this task simpler but this is also the > package the least amount of

Re: ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-30 Thread Daniel Kraus
Ihor Radchenko writes: > > If Bastien removed session support, and you do not see any justification, > it was most likely an oversight. We generally avoid feature regressions: > https://bzg.fr/en/the-software-maintainers-pledge/ > > So, if sessions are currently not supported, it should be

indent-tabs-mode in org (was: ob-clojure eval error when has comment at end of code line)

2022-10-29 Thread Daniel Kraus
Ihor Radchenko writes: > Daniel Kraus writes: > >> - What should I use for indention? Looking in ob-clojure and org.el >> it seems that using tabs with tab-width 8 is standard but there's >> quite a few lines where it's spaces only. > That is a good question. I guess, just Emacs default. >

Re: ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-28 Thread Ihor Radchenko
Daniel Kraus writes: > Looking in the history, Christopher added session support 5 years ago, > then (3 years ago) I see Bastien also adding something with initiate-session > but > then removing all session support the following commit. > I guess something was broken and got removed but stayed

ob-clojure session support (was: ob-clojure eval error when has comment at end of code line)

2022-10-28 Thread Daniel Kraus
Ihor Radchenko writes: > make test BTEST_POST="-L /path/to/cider.el" BTEST_OB_LANGUAGES="clojure" > BTEST_RE="ob-clojure" > > Note that our tests demand cider executable and library. > Testing with external libraries is a bit manual. Thanks. I think cider is falsely required in the test. It

Re: ob-clojure eval error when has comment at end of code line

2022-10-27 Thread Ihor Radchenko
Daniel Kraus writes: > @Ihor, a few developer related questions: > - I wanted to add a test, how can I run only test-ob-clojure? make test BTEST_POST="-L /path/to/cider.el" BTEST_OB_LANGUAGES="clojure" BTEST_RE="ob-clojure" Note that our tests demand cider executable and library. Testing with

Re: ob-clojure eval error when has comment at end of code line

2022-10-27 Thread Max Nikulin
On 27/10/2022 19:25, Daniel Kraus wrote: - I wanted to add a test, how can I run only test-ob-clojure? See testing/README make BTEST_RE=ob-closure

Re: ob-clojure eval error when has comment at end of code line

2022-10-27 Thread Daniel Kraus
Hi! I had a look and apparently cider-eval returns nil when the expression is a comment, vs the string "nil" when the Clojure expression returns nil. Simply filtering nil values out seems to have fixed the issue for me. @Christopher, can you check the attached patch if this works for you? @Ihor,

Re: ob-clojure eval error when has comment at end of code line

2022-10-26 Thread Ihor Radchenko
"Christopher M. Miles" writes: > I have following Clojure source block: > > #+begin_src clojure > (re-find #"\d+" "I've just finished reading Fahrenheit 451");; => "451" > (re-find #"Bees" "Beads aren't cheap.");; => nil > #+end_src > > When I press =[C-c C-c]= to evaluate source block, got

ob-clojure eval error when has comment at end of code line

2021-11-10 Thread Christopher M. Miles
I have following Clojure source block: #+begin_src clojure (re-find #"\d+" "I've just finished reading Fahrenheit 451");; => "451" (re-find #"Bees" "Beads aren't cheap.");; => nil #+end_src When I press =[C-c C-c]= to evaluate source block, got error: When there is no comments behind code