William Xu writes:
> Any updates here? I do hope the patch can be merged..
I plan to bump the thread and revisit this patch again some time later,
after we stabilise recent changes in org-element and after preparing the
final patches for org-fold.
Meanwhile, you can try my dev branch [1] :)
Any updates here? I do hope the patch can be merged..
--
William
Timothy writes:
> Hi Ihor,
>
> This thread is looking promising! Just wondering if you might have time
> to respond to William's latest reply?
Sure. Just descended from work staff down to the Emacs area in my TODO
list ;)
William Xu writes:
> I need to make below additional change, otherwise it works perfectly.
Incorporated in the attached final version of the patch.
> Looking at the changes, I see you changed below `concat' call to
> `format'. Is this in the end some bug in the `concat' implementation?
It is
Hi Ihor,
This thread is looking promising! Just wondering if you might have time
to respond to William's latest reply?
--
Timothy
Ihor Radchenko writes:
> Oops. Forgot to rebase the patch to current master. The correct version
> is attached.
Thanks for the fix!
I need to make below additional change, otherwise it works perfectly. I
can't reproduce the original issue any more.
Looking at the changes, I see you changed
William Xu writes:
> On which commit is the patch based? When I try to apply it, somehow I
> get failures:
Oops. Forgot to rebase the patch to current master. The correct version
is attached.
Best,
Ihor
>From 924375994e110ba06ea6ed3fa9aa1ecab9380d5b Mon Sep 17 00:00:00 2001
Message-Id:
Ihor Radchenko writes:
> William Xu writes:
>> Thanks. At least not something weird in my emacs config. :)
>>
>> I think your patch is ready to be merged into orgMode. Hopefully it can be
>> merged soon.
>
> I believe that I managed to fix the problem you observe, though I do not
> understand
William Xu writes:
> Thanks. At least not something weird in my emacs config. :)
>
> I think your patch is ready to be merged into orgMode. Hopefully it can be
> merged soon.
I believe that I managed to fix the problem you observe, though I do not
understand how. Can you test the attached
Ihor Radchenko writes:
> I can reproduce with ONGOING as well... In fact, I can reproduce the
> issue with any TODO keyword of >4 chars length while using
> prettify-symbols-mode (but not pretty-symbols-mode). Moreover, the
> 'composition property is _not_ removed in agenda. Emacs... just does
William Xu writes:
> I can't reproduce it using your steps and config. I compared the org
> config differences. I'm using a different org keyword ONGOING, instead of
> NEXT.
>
> In fact, if I replace NEXT with ONGOING in 1.el, then I can reproduce
> the issue. This is very strange..
I can
Ihor Radchenko writes:
> Sorry, I cannot reproduce on my side using Emacs master, Emacs 27, and
> Emacs 25. I used the following recipe:
>
> 1. cd /path/to/org
> 2. make clean
> 3. make
> 4. emacs -Q -L ./lisp/ -l org -l /tmp/1.el ~/Org/inbox.org
> 5. M-x org-agenda < t
> 6. M-x org-todo on the
William Xu writes:
>> I was able to reproduce using prettify-symbols-mode (though not using
>> pretty-symbols-mode). Should be fixed now in the attached patch.
>
> The issue seems still present.
Sorry, I cannot reproduce on my side using Emacs master, Emacs 27, and
Emacs 25. I used the
Ihor Radchenko writes:
>> I think I'm still seeing the issue. For example, if i change (M-x
>> org-agenda-todo) a TODO item into next state ONGOING, which i have made
>> prettified:
>>
>> (push '("ONGOING" . "" ) prettify-symbols-alist)
>>
>> So far so good. But as soon as I call
William Xu writes:
> I think I'm still seeing the issue. For example, if i change (M-x
> org-agenda-todo) a TODO item into next state ONGOING, which i have made
> prettified:
>
> (push '("ONGOING" . "" ) prettify-symbols-alist)
>
> So far so good. But as soon as I call org-agenda-redo-all,
Ihor Radchenko writes:
>>> The only issue I still see, is that when you org-agenda-redo-all, or
>>> org-agenda-log-mode (which triggers org-agenda-redo-all), the
>>> prettify gets lost again. Maybe org-buffer-substring-fontified call is
>>> also required somewhere during org-agenda-redo-all?
>>
> William Xu writes:
>> The only issue I still see, is that when you org-agenda-redo-all, or
>> org-agenda-log-mode (which triggers org-agenda-redo-all), the
>> prettify gets lost again. Maybe org-buffer-substring-fontified call is
>> also required somewhere during org-agenda-redo-all?
>
> I
Ihor Radchenko writes:
> Bastien writes:
>> Could it slow down agenda generation for some configurations?
> The total slowdown is ~30%, though the second part will only be slow
> before the headings are fontified first time by
> org-buffer-substring-fontified. Subsequent agenda rebuilds will
Bastien writes:
> Could it slow down agenda generation for some configurations?
Yes, it can. Specifically, fontifying tags can be costly. For
illustration, below if profiler report for a very large agenda buffer
(1468 entries):
19820 95% - org-agenda
...
4401 21% -
Hi Ihor,
Ihor Radchenko writes:
> William Xu writes:
>
>> Now I try to test it extensively. Even with all your changes, I find
>> when I use org-agenda-todo to change the todo-state inside the agenda
>> buffer, the new state isn't always prettified.
>>
>> Do you see the same behaviour?
>
>
Ihor Radchenko writes:
> See the updated patch.
Thanks, it works quite nice now on the agenda line.
The only issue I still see, is that when you org-agenda-redo-all, or
org-agenda-log-mode (which triggers org-agenda-redo-all), the
prettify gets lost again. Maybe org-buffer-substring-fontified
William Xu writes:
> Now I try to test it extensively. Even with all your changes, I find
> when I use org-agenda-todo to change the todo-state inside the agenda
> buffer, the new state isn't always prettified.
>
> Do you see the same behaviour?
Oops. Yes, I do see the same behaviour. I only
Ihor Radchenko writes:
> This change is needed, for example, when you change todo-state using
> `org-agenda-todo'. Refreshing the agenda line in
> org-agenda-highlight-todo involves
>
> (insert (format org-agenda-todo-keyword-format s))
>
> `insert' will destroy the 'composition as 'composition
William Xu writes:
>> (org-agenda-highlight-todo): Preserve composition property used,
>> i.e. by `prettify-symbols-mode'.
>
> It looks like this change is not really needed, my emacs is built from
> git master. Maybe the 'composition property is now preserved
> automatically in the buffer?
Ihor Radchenko writes:
> Bastien writes:
>
>> Thanks for bringing this idea up.
>>
>> If allowing prettify-symbols-mode in Org agenda mode does not slow
>> down the agenda display and does not create spacing problems, then
>> yes, why not.
>
> Here is t
Bastien writes:
> Thanks for bringing this idea up.
>
> If allowing prettify-symbols-mode in Org agenda mode does not slow
> down the agenda display and does not create spacing problems, then
> yes, why not.
Here is the patch. It will be great if other people test it first, as I
Hi William,
William Xu writes:
> Thanks for the info. I'll be happy to prepare the patch. However, I
> would like to hear what is the opinion of org maintainter(s) on this
> topic.
Thanks for bringing this idea up.
If allowing prettify-symbols-mode in Org agenda mode does not
> I would like to hear what is the opinion of org maintainter(s) on this
> topic.
Ok. Marking this thread with X-Woof-Help.
William Xu writes:
> Ihor Radchenko writes:
>
>> Feel free to prepare a patch using my code and send it here.
>> I think the following function should be sufficient to
Ihor Radchenko writes:
> Feel free to prepare a patch using my code and send it here.
> I think the following function should be sufficient to preserve
> pretty-symbols composition:
>
> (el-patch-defun org-agenda-highlight-todo ...
>
> I have added only 3 lines to the original
in the body).
That change simply preserves 'composition text property in agenda.
Best,
Ihor
William Xu writes:
> Hi,
>
> Is there any plan to support prettify-symbols-mode in org agenda? With
> that mode, it would make it easier to, for example, replace the todo
> keywords
Hi,
Is there any plan to support prettify-symbols-mode in org agenda? With
that mode, it would make it easier to, for example, replace the todo
keywords with some nice looking unicode chars.
>From reddit, I found yantar92 has posted some elisp changes to enable the
>support:
31 matches
Mail list logo
