[SOLVED] Re: the latest commit broke the inline image preview

2019-12-23 Thread stardiviner


Nicolas Goaziou  writes:

> Hello,
>
> stardiviner  writes:
>
>> After EMC testing, the latest commit " 04d2828ad org: Fix verbatim block
>> fontification to end blocks on headlines " break the inline image
>> preview

I try to git checkout a commit before this commit in history. But unfortunately
this does not work. I might misunderstanding somewhere.

>
> Thank you for the report. However, I think more information may be
> useful, since « break the inline image preview » is rather vague. 
>
> In any case, I'm Cc'ing Tom Gillespie as he may know what is happening.
>
>> If possible, I think Org Mode should add test for inline image.
>
> Patches welcome :)
>
> Regards,

After I long time bisect my init files and Org mode repository recently commits.
I have not found what commit caused this issue.

I found this is because I have not explicitly require org-attach library.

Now I added explicit require

#+begin_src emacs-lisp
(require 'org-attach)
#+end_src

Problem solved. :)

-- 
[ stardiviner ]
   I try to make every word tell the meaning what I want to express.

   Blog: https://stardiviner.github.io/
   IRC(freenode): stardiviner, Matrix: stardiviner
   GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
  



Re: Asynchronous org-agenda-redo

2019-12-23 Thread Adam Porter
Ihor Radchenko  writes:

> If you accidentally move the point in the buffer being processed by
> agenda, the results may be unpredictable (org-agenda-get-* functions
> move across the buffer with re-search-forward).

I'm afraid that's the basic problem with threading in Emacs: shared
state.  I don't know of a way to work around that.  I suppose you could
modify a lot of the agenda code to, e.g. store the position of the
current search in a variable and go to it before each search.  Of
course, that would also reduce performance to some extent.  It's a hard
problem.




problem with org-toggle-inline-images

2019-12-23 Thread Johannes Brauer
Hi!
Typing C-c C-x C-v the image is displayed in the org buffer correctly. Typing 
C-c C-x C-v again the image does not disappear and I get the error message:

org-toggle-inline-images: Symbol’s value as variable is void: image-map

Any hints what is going wrong?

I am using
Aquamacs 3.5  GNU Emacs 25.3.50.1 (x86_64-apple-darwin16.7.0, NS
macOs 10.15.2
Org mode version 9.3 (9.3-8-geab7c4-elpa

Johannes



Re: alpha sort of TODO flagged tasks

2019-12-23 Thread Sharon Kimble
Nicolas Goaziou  writes:

> Hello,
>
> Sharon Kimble  writes:
>
>> How can I sort alphabetically some of my org-mode tasks which are in the
>> format of [1] please? I can sort them once the TODO flag is removed, but
>> I would like to sort them before then.
>
> I think you can do it the usual way, with `org-sort-entries'. Have you
> tried it? It works here.
>
> Regards,

Thanks Nicolas for replying.

I wasn't aware of 'org-sort-entries' and it does work extremely well, thanks.

Thanks
Sharon.
-- 
A taste of linux = http://www.sharons.org.uk
TGmeds = http://www.tgmeds.org.uk
DrugFacts = https://www.drugfacts.org.uk
Debian 10.1, fluxbox 1.3.7, emacs 26.3, org 9.3


signature.asc
Description: PGP signature


[PATCH] restore window configuration after org-edit-src-exit

2019-12-23 Thread Jack Kamm
Attached is a patch to restore the window configuration after exiting an
org source buffer, when org-src-window-setup is one of reorganize-frame,
split-window-below, or split-window-right.

References:
https://lists.gnu.org/archive/html/emacs-orgmode/2019-12/msg00263.html
https://lists.gnu.org/archive/html/emacs-orgmode/2018-11/msg00253.html

>From 03a2b9433f1ad15ac21a49e7f0c6c5390e9e4375 Mon Sep 17 00:00:00 2001
From: Jack Kamm 
Date: Mon, 23 Dec 2019 08:55:55 -0800
Subject: [PATCH] org-src: restore windows for some values of
 org-src-window-setup

---
 etc/ORG-NEWS|  3 +++
 lisp/org-src.el | 16 
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 44dfd5459..8cb611aee 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -24,6 +24,9 @@ for all headlines.
 *** New option to group captured datetime entries by month
 A new `:tree-type month' option was added to org-capture-templates to
 group new datetime entries by month.
+*** Refinement in window behavior on exiting Org source buffer
+After editing a source block, Org will restore the window layout when
+~org-src-window-setup~ is set to a value that modifies the layout.
 ** New functions
 *** ~org-columns-toggle-or-columns-quit~
 == bound to ~org-columns-toggle-or-columns-quit~ replaces the
diff --git a/lisp/org-src.el b/lisp/org-src.el
index 5e50a1b47..5a2f07d53 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -156,8 +156,7 @@ split-window-right Show edit buffer to the right of the current window,
keeping all other windows.
 other-window   Use `switch-to-buffer-other-window' to display edit buffer.
 reorganize-frame   Show only two windows on the current frame, the current
-   window and the edit buffer.  When exiting the edit buffer,
-   return to one window.
+   window and the edit buffer.
 other-frameUse `switch-to-buffer-other-frame' to display edit buffer.
Also, when exiting the edit buffer, kill that frame."
   :group 'org-edit-structure
@@ -276,6 +275,9 @@ issued in the language major mode buffer."
 (defvar-local org-src--remote nil)
 (put 'org-src--remote 'permanent-local t)
 
+(defvar-local org-src--saved-temp-window-config nil)
+(put 'org-src--saved-temp-window-config 'permanent-local t)
+
 (defvar-local org-src--source-type nil
   "Type of element being edited, as a symbol.")
 (put 'org-src--source-type 'permanent-local t)
@@ -469,6 +471,10 @@ When REMOTE is non-nil, do not try to preserve point or mark when
 moving from the edit area to the source.
 
 Leave point in edit buffer."
+  (when (memq org-src-window-setup '(reorganize-frame
+ split-window-below
+ split-window-right))
+(setq org-src--saved-temp-window-config (current-window-configuration)))
   (let* ((area (org-src--contents-area datum))
 	 (beg (copy-marker (nth 0 area)))
 	 (end (copy-marker (nth 1 area) t))
@@ -1182,8 +1188,10 @@ Throw an error if there is no such buffer."
(write-back (org-src--goto-coordinates coordinates beg end
 ;; Clean up left-over markers and restore window configuration.
 (set-marker beg nil)
-(set-marker end nil)))
-
+(set-marker end nil)
+(when org-src--saved-temp-window-config
+  (set-window-configuration org-src--saved-temp-window-config)
+  (setq org-src--saved-temp-window-config nil
 
 (provide 'org-src)
 
-- 
2.24.1



Re: Fix time regexp in org-get-entries-from-diary

2019-12-23 Thread Nicolas Goaziou
Hello,

Thomas Fitzsimmons  writes:

> I have signed FSF papers for contributions to GNU Emacs.

I updated your status, then. Thank you for letting me know.

Regards,

--
Nicolas Goaziou



Re: restore window configuration after org-edit-src-exit

2019-12-23 Thread Nicolas Goaziou
Jack Kamm  writes:

> However, the change here is very small, I just wrote a small patch and
> it's 15 insertions (+), 4 deletions(-), including the entry in
> ORG-NEWS. My understanding is that such small changes don't require
> explicit copyright assignment.
>
> Is it OK for me to send the patch along, or should I hold off on this?

It is OK.



Re: restore window configuration after org-edit-src-exit

2019-12-23 Thread Jack Kamm
> OK. Would you want to implement it?

Yes, but I'm still in the process of updating my copyright papers for my
current job. My job said they won't be able to sign the copyright
disclaimer until the new year, so I expect this to be sorted out later
in January some time.

However, the change here is very small, I just wrote a small patch and
it's 15 insertions (+), 4 deletions(-), including the entry in
ORG-NEWS. My understanding is that such small changes don't require
explicit copyright assignment.

Is it OK for me to send the patch along, or should I hold off on this?

--Jack



Re: Fix time regexp in org-get-entries-from-diary

2019-12-23 Thread Thomas Fitzsimmons
Hi Nicolas,

Nicolas Goaziou  writes:

> Hello,
>
> Thomas Fitzsimmons  writes:
>
>> I filed a bug report in Emacs debbugs, but probably should have sent it
>> here instead:
>>
>>http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599
>>
>> The attached patch appears to fix the bug.  Does it look OK?
>
> Applied. Thank you.

Thanks.

> I added your name to the list of contributors who haven't signed FSF
> papers. Please let me know if you did so I can update your status.

I have signed FSF papers for contributions to GNU Emacs.

Thomas



Re: [Idea] Org Collections

2019-12-23 Thread Roland Everaert


Gustav Wikström writes:

> Hi!
>
>> -Original Message-
>> From: Emacs-orgmode  On Behalf
>> Of Roland Everaert
>> Sent: den 16 december 2019 12:26
>> To: emacs-orgmode@gnu.org
>> Subject: Re: [Idea] Org Collections
>> 
>> +1 for this idea.
>> 
>> You speak about one document used by multiple collections, how do you
>> plan to manage that from a file system point of view?
>
> The idea was to let the user define the scope of each collection herself. 
> Similar to how an agenda is defined today (Maybe in the same way even?). Most 
> simple configuration would be to let a collection be one folder. But in the 
> end it would be up to the imagination of and usefulness for the user. Having 
> one document in multiple collections wouldn't be any issue because the 
> collections are only pointing to locations of files in the filesystem. And if 
> creating overlap between collections sounds dumb then it's a simple choice by 
> the user to not do it!

Have you had a look at org-brain. I don't use is much, but there are
some overlapping functionnality to merge, maybe.

>
>> How will be organized a collection, still from the FS point of view?
>
> Maybe the comments above answer that as well?
>
>> As some are delving into the abyss of sementic, I propose aspects
>> instead of collections or contexts. Ultimately we are trying to manage
>> various aspects of our life, by splitting those aspects into files or
>> diretories and what not. So, if it is the intent of your idea, the term
>> aspect seems more appropriate than collection or context IMHO.
>
> Many words could work. Context, Project, Group, Aspect, Areas, etc. I first 
> thought of the name "project" to match the Projectile package. But I think 
> collection is a better concept here. It lets the user think not of how it 
> should be used but rather of what it consists. Which is a collection of files 
> (and settings). That collection can ofc. be used for project, as aspects, or 
> be seen as contexts or areas. So in my mind collection is the broader, more 
> applicable term. It has less subjective meaning attached to how this 
> functionality could be used. It IS a collection but can be USED as aspects, 
> for projects, etc. What do you say? 

I think I can live with it ;)

>
>> 
>> Did you think about the specific UI of aspects management?
>> Proposal of UI I particularly like:
>> - Mu4E
>> - forge/magit
>
> Not really.. Except I agree with you on magit. The other I haven't used.

Mu4E is a major mode for managing e-mails using the mu index. it
provides a main view with bookmarks and entries to perform searches and
composing message, among othe thing, but what I find more useful are the
header view, which displays a multi-columns list of e-mails with
associated meta-data and a message view allowing to view the content of
an e-mail. The header view allows for bulk actions while the message
view act, obiously, on the current message and permit replying and
transfering the current e-mail.

>
>> 
>> How to keep track of all those aspects?
>
> My first thought was to define them in a simple list.
>
>> 
>> I will surely have more to say, but, as of know I am at work.
>> 
>> Regards,
>> 
>> Roland.
>
> Thanks for your comments!
>
> Regards
> Gustav


-- 
Luke, use the FOSS

Sent from Emacs



Re: restore window configuration after org-edit-src-exit

2019-12-23 Thread Nicolas Goaziou
Hello,

Jack Kamm  writes:

> I agree, this sounds like the correct behavior to me.

OK. Would you want to implement it?

Regards,

-- 
Nicolas Goaziou



Re: alpha sort of TODO flagged tasks

2019-12-23 Thread Nicolas Goaziou
Hello,

Sharon Kimble  writes:

> How can I sort alphabetically some of my org-mode tasks which are in the
> format of [1] please? I can sort them once the TODO flag is removed, but
> I would like to sort them before then.

I think you can do it the usual way, with `org-sort-entries'. Have you
tried it? It works here.

Regards,

-- 
Nicolas Goaziou



alpha sort of TODO flagged tasks

2019-12-23 Thread Sharon Kimble

How can I sort alphabetically some of my org-mode tasks which are in the
format of [1] please? I can sort them once the TODO flag is removed, but
I would like to sort them before then.

Thanks
Sharon.

[1]
--8<---cut here---start->8---
** TODO foo
** TODO delta
** TODO oxymoron
** TODO clueless
--8<---cut here---end--->8---
-- 
A taste of linux = http://www.sharons.org.uk
DrugFacts = https://www.drugfacts.org.uk
Debian 10.1, fluxbox 1.3.7, emacs 26.3, org 9.3


signature.asc
Description: PGP signature