Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-24 Thread Ihor Radchenko
Max Nikulin writes: > On 23/07/2022 12:01, Ihor Radchenko wrote: >> Juan Manuel Macías writes: >> >>> Here is a new version of the patch, with the fixes added. >> >> Thanks! Considering that the followup discussion deviated from the >> substance of the patch towards related design issues, > >

Re: [BUG] org-capture-kill: doesn't remove the right text region

2022-07-24 Thread Ihor Radchenko
Caleb Chase writes: > I discovered a bug with org-capture and org-capture kill when > canceling an item or plain type template on a heading that has only an > empty line for content. Minimal reproduction is as follows: The fix is attached. The reason why this bug is happening is

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-24 Thread Ihor Radchenko
Max Nikulin writes: >>> It is `map-do' that causes the problem. Maybe earlier implementation in >>> Emacs-26 has some peculiarities. It is the version available from the >>> system repository for Ubuntu-20.04 LTS focal. >> >> Tests do not fail on my side using Emacs 26.3 > > Ihor, what is the

[restarting helps, memory problem?] (was: [Problem persits])

2022-07-24 Thread Uwe Brauer
>>> "UB" == Uwe Brauer writes: >>> "UB" == Uwe Brauer writes: >>> "UB" == Uwe Brauer writes: >>> Hi >>> I attach a file that hopefully explains the problem. >>> That file contains 109 heading, each heading has 17 different >>> properties when all of them are included in the >> It seems that

Re: [PROPOSED-PATCH] ox-publish: fix typo in function name

2022-07-24 Thread Paul Eggert
Thanks for the review. Pushed with the changes you suggested.

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-24 Thread Ihor Radchenko
Juan Manuel Macías writes: >> Hmm. You are actually right. >> Juan, can you please take a look. It looks like you missed >> "org-latex--format-spec" in the patch. It should use the new >> org-latex-language-alist variable instead. > > Attached a new patch to fix (I hope) the

Bug in definition of org-encode-time

2022-07-24 Thread Kenneth Stuart
Hello, Macro `org-encode-time` (lisp/org-macs.el +1395) does not get defined for emacs >= 27.1 as the top level if statement is missing its ELSE clause. #+begin_src elisp (if (version< emacs-version "27.1") (defmacro org-encode-time ( time) (if (cdr time) `(encode-time

Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters

2022-07-24 Thread Max Nikulin
On 23/07/2022 20:06, Ihor Radchenko wrote: Max Nikulin writes: If it still fails, could you try isolating whether it's a specific `should' clause which is the problem, if it fails with any of them? It is `map-do' that causes the problem. Maybe earlier implementation in Emacs-26 has some

Re: Bug in definition of org-encode-time

2022-07-24 Thread Kenneth Stuart
Yes, you're right I should have looked more closely, I also see 'Morgan Smith' has already raised the issue more clearly. Please ignore the noise ;) Ihor Radchenko writes: > Kenneth Stuart writes: > >> Macro `org-encode-time` (lisp/org-macs.el +1395) does not get defined >> for emacs >= 27.1

Re: Bug in definition of org-encode-time

2022-07-24 Thread Kenneth Stuart
This appears to be an issue with the emacs native compiler, as using a build without it enabled works as expected, and using a build with the native compiler enabled but before the relevant .eln files have been built also works as expected, once they've been built the issue mentioned by Morgan

Re: [PATCH] oc-csl: Add support for sub-bibliographies

2022-07-24 Thread Ihor Radchenko
András Simonyi writes: > Dear Ihor, thanks a lot for your comments, I've attached a new version > in which I tried to implement your suggestions. Thanks! I have made some changes to the patch, mostly fixing grammar issues (the ones I can notice). I also changed the sub-section from

columnview: add a formula?

2022-07-24 Thread Uwe Brauer
Hi I have the following setting #+begin_src * Everything :PROPERTIES: :COLUMNS: %TODO %ITEM %Cash %Card :END: ** WAIT Hotel :PROPERTIES: :Cash: 100 :Card: 200 :Result: :END: ** WAIT Flight :PROPERTIES: :Cash: 300 :Card: 200 :Result: :END:

Re: [PROPOSED-PATCH] ox-publish: fix typo in function name

2022-07-24 Thread Ihor Radchenko
Paul Eggert writes: > * lisp/ox-publish.el (org-publish-cache-mtime-of-src): > Rename from org-publish-cache-ctime-of-src, since it > has always cached mtime not ctime. All uses changed. Thanks! mtime is indeed more accurate. Note that your patch does not apply onto main. Also, please define

Re: Bug in definition of org-encode-time

2022-07-24 Thread Ihor Radchenko
Kenneth Stuart writes: > Macro `org-encode-time` (lisp/org-macs.el +1395) does not get defined > for emacs >= 27.1 as the top level if statement is missing its ELSE clause. Are you sure? > #+begin_src elisp > (if (version< emacs-version "27.1") > (defmacro org-encode-time ( time) >

Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists

2022-07-24 Thread Juan Manuel Macías
Ihor Radchenko writes: > Can you please add the comments, similar to what I requested earlier. > These magic length of 4 may be hard to grasp otherwise. Hi Ihor, Here is the new patch. I have realized that it is not necessary to put a cond, since in this case it is only necessary to obtain the

Improvements in the default LaTeX preamble: templates? (was: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists)

2022-07-24 Thread Juan Manuel Macías
Ihor Radchenko writes: > Adding things like paper size is a much more debatable topic. > Considering the number of expected developments in this area, including > the earlier discussion on XeLaTeX/LuaTeX and preamble generation by TEC, > adding the new specific defaults will need to be a subject

[PROPOSED-PATCH] Fix doc string quoting problems with '

2022-07-24 Thread Paul Eggert
The Emacs doc string convention is to document values as-is when that is clear, and surrounded by `single quotes' otherwise. For example, a doc string "(a b c)" stands for a list of symbols, and the doc string "`a'" stands for a single symbol. The doc string "\\=`a" is typically not correct for