Re: [DRAFT PATCH v6] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-25 Thread General discussions about Org-mode.
Ruijie Yu via "General discussions about Org-mode." writes: > Ihor Radchenko writes: > >> (let ((org-time-stamp-formats '("%Y-%m-%d" . "%Y-%m-%d %H:%M"))) >> (org-element-timestamp-interpreter timestamp nil)) > > Thanks for the pointer. I have made this into a macro and redid my >

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-25 Thread General discussions about Org-mode.
Ihor Radchenko writes: >> +(defun org-columns--substring-below-width (string start width) >> + "Similar to `substring', but use `string-width' to check width. > > This is not really similar to `substring' as `substring' has totally > different third argument. Addressed in v6 -- see my update

Re: [PATCH] lisp/ob-scheme.el

2023-04-25 Thread Ihor Radchenko
Zelphir Kaltstahl writes: > Subject: [PATCH] org-babel-expand-body:scheme: define header arg vars using > define Applied, onto main, adding TINYCHANGE cookie and newline between variable definitions and body. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d97ba5ba5 You are

Re: How to disable org-persist in a given file?

2023-04-25 Thread Gustavo Barros
On Tue, 25 Apr 2023 at 07:21, Ihor Radchenko wrote: > > I don't understand that. Isn't persistence about keeping data across > > Emacs sessions? > > Not only. We also use org-persist to cache downloaded images from > internet and, in future, to cache image previews (currently, they just > sit in

Re: [PATCH] before emit an error message, try to load the babel language

2023-04-25 Thread General discussions about Org-mode.
Ihor Radchenko writes: > lin Sun writes: > >> Thanks for the comment. >> If we switch to the `add-variable-watcher', it seems we'll load the >> ob-LANG in the callback immediately. >> The previous change can lazyly load the babel languages until the user >> tries to evaluate the source block.

[PATCH] org-clock.el: Fix week start != 1

2023-04-25 Thread Max Nikulin
On 25/04/2023 02:44, Marcin Borkowski wrote: And I assume that FSF might want to look at my contract, which is in Polish I had an impression that an FSF form signed by your employer is enough, but I may be wrong. Could you, please, test if the attached patch works correctly for you?From

Re: [PATCH] before emit an error message, try to load the babel language

2023-04-25 Thread Ihor Radchenko
Ruijie Yu writes: >> 1. `setopt' already triggers loading when variable is set. It is just >>`setq', often used in place of `setopt', that does not trigger >>loading/unloading. > > Speaking of which, since we now (or are about to?) depend on compat, we > can just do (require 'compat) and

Re: How to disable org-persist in a given file?

2023-04-25 Thread Ihor Radchenko
Gustavo Barros writes: >> We cannot just disable persistence completely. >> For example, remote image export relies on persistence to be working >> _during_ Emacs session. > > I don't understand that. Isn't persistence about keeping data across > Emacs sessions? Not only. We also use

The meaning of / inverted in the agenda

2023-04-25 Thread John Wiegley
In previous version of Org-mode, I was used to "/ t" showing me only entries that matched the tag keyed by 't'. Now it hides them instead. I was able to fix this using: modified lisp/org-agenda.el @@ -8578,7 +8578,7 @@ also press `-' or `+' to switch between filtering and excluding."

Re: The meaning of / inverted in the agenda

2023-04-25 Thread Ihor Radchenko
John Wiegley writes: >> May you please provide a reproducer or at least more details? > > - Enter the Org-agenda > - Press '/ t' to filter by the tag identified by 't' > - Note that it hides those tags, rather than showing only those tags I just tried 1. emacs -Q 2. C-x C-f /tmp/1.org 3. *

Re: [BUG] Null character in block/drawer regexps (but not in org-element parser)

2023-04-25 Thread Ihor Radchenko
Bastien Guerry writes: > Ihor Radchenko writes: > >> So, we should probably remove zero-width shenanigans from the code. > > +1. Upon further look, it appears to me that [^\000] was simply used to match "anything, including newline" in most places. Fixed, on main.

Re: The meaning of / inverted in the agenda

2023-04-25 Thread John Wiegley
> Ihor Radchenko writes: > "John Wiegley" writes: >> In previous version of Org-mode, I was used to "/ t" showing me only >> entries that matched the tag keyed by 't'. Now it hides them instead. > May you please provide a reproducer or at least more details? - Enter the Org-agenda - Press

Re: The meaning of / inverted in the agenda

2023-04-25 Thread Ihor Radchenko
"John Wiegley" writes: > In previous version of Org-mode, I was used to "/ t" showing me only entries > that matched the tag keyed by 't'. Now it hides them instead. May you please provide a reproducer or at least more details? > I was able to > fix this using: > > modified

Re: The meaning of / inverted in the agenda

2023-04-25 Thread John Wiegley
> Ihor Radchenko writes: > What am I missing? My apologies, I really don't know what errant behavior had crept into my configuration, but even now as I tried the steps, I saw that it had flipped again, making the "fix" I proposed entirely incorrect, as you surmised. This is really quite

Allowing :PROPERTIES: drawer to appear at the end of entries

2023-04-25 Thread John Wiegley
I have about 21,000 headlines throughout my Org files, most of those tasks. Nearly all of them have PROPERTIES drawers, and since those drawers appear at the end of the entries, I've grown quite used to that arrangement. Anyway, it didn't take much effort to adapt Org 9.x to allow for such

Re: [PATCH] before emit an error message, try to load the babel language

2023-04-25 Thread General discussions about Org-mode.
Ihor Radchenko writes: > Ruijie Yu writes: > >>> 1. `setopt' already triggers loading when variable is set. It is just >>>`setq', often used in place of `setopt', that does not trigger >>>loading/unloading. >> >> Speaking of which, since we now (or are about to?) depend on compat, we

Re: [PATCH] before emit an error message, try to load the babel language

2023-04-25 Thread lin Sun
Thank you all for the comments, and agree with no code change. Please feel free to close this ticket. Thanks

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-25 Thread Ihor Radchenko
Ruijie Yu writes: > Just had a try at this, fully untested code (other than starting a > LANG=zh_CN.UTF-8 Emacs session and running this substring function to > see its effects). Thanks! > +(defun org-columns--substring-below-width (string start width) > + "Similar to `substring', but use

Re: [PATCH] before emit an error message, try to load the babel language

2023-04-25 Thread Ihor Radchenko
lin Sun writes: > Thanks for the comment. > If we switch to the `add-variable-watcher', it seems we'll load the > ob-LANG in the callback immediately. > The previous change can lazyly load the babel languages until the user > tries to evaluate the source block. Is there any advantage doing the

Re: [DRAFT PATCH v5] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-25 Thread General discussions about Org-mode.
Ihor Radchenko writes: > (let ((org-time-stamp-formats '("%Y-%m-%d" . "%Y-%m-%d %H:%M"))) > (org-element-timestamp-interpreter timestamp nil)) Thanks for the pointer. I have made this into a macro and redid my changes accordingly. Please also let me know if more work should be dedicated