Re: [MAINTENANCE] Org orphanage?

2023-08-17 Thread Corwin Brust
Hi all; I added worg co-curator krupalinbox to CC. On Thu, Aug 17, 2023 at 8:41 AM Jonas Bernoulli wrote: > > Ihor Radchenko writes: > > > I may miss more org-related repositories from emacsorphanage list. > [SNIP] > > >> IMO it would be a good idea if Bastien and/or Ihor joined the > >>

Re: org-assert-version considered harmful

2023-08-17 Thread Max Nikulin
On 16/08/2023 18:08, Ihor Radchenko wrote: Every library will have (require 'org-foo-9.X "org-foo") (require 'org-bar-9.X "org-bar") ... (provide 'org-lib) (provide 'org-lib-9.X) Are you going to update patch version of particular library on each change of macro definitions?

Re: [BUG][SECURITY] ob-sqlite header args allows execution of arbitrary shell commands

2023-08-17 Thread Max Nikulin
On 13/08/2023 14:52, Ihor Radchenko wrote: What do you think about creating a new API to built shell commands and then using it across all the babel backends? I support the idea in general, but not its particular implementation as `org-make-shell-command' in your patch. It does not address

[POLL] Should org-copy/cut/paste-special handle inlinetasks specially? (was: BUG: org-cut-special on inlinetask kill until point-max)

2023-08-17 Thread Ihor Radchenko
Michael Dauer writes: > I understand your view. From the user perspective inline task are still > more a specialization of a task, which is a specialisation of a heading. > > Here is my implementation of how I see it that it should behave: > (defun pm-cut-special () > "Like org-cut-special but

[BUG] ob-sqlite: can not override header argument

2023-08-17 Thread Max Nikulin
It seems there is no way to override for a specific code block header arguments specified for the whole file through #+property: #+property: header-args:sqlite :header #+begin_src elisp :results none (require 'ob-sqlite) #+end_src I have tried "nil", etc. for ":header", but column names are

Re: [BUG][SECURITY] ob-sqlite header args allows execution of arbitrary shell commands

2023-08-17 Thread Max Nikulin
On 13/08/2023 14:52, Ihor Radchenko wrote: + (when separator (format "-separator %s" separator)) It should be escaped as a whole. It seems sqlite3 command line arguments parser does not support -separator=| variant, so two words should be quoted separately. Try :separator |

Re: [BUG] ob-sqlite: can not override header argument

2023-08-17 Thread Ihor Radchenko
Max Nikulin writes: > It seems there is no way to override for a specific code block header > arguments specified for the whole file through #+property: > > #+property: header-args:sqlite :header > #+begin_src elisp :results none >(require 'ob-sqlite) > #+end_src > > I have tried "nil",

[BUG] org-element-cache Org parser error [9.7 (9.7-??-d6f3aed @ /home/guillaume.muller/.emacs.d/.local/straight/build-28.1/org/)]

2023-08-17 Thread Guillaume MULLER
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Re: [MAINTENANCE] Org orphanage?

2023-08-17 Thread Jonas Bernoulli
Ihor Radchenko writes: > What about https://github.com/flexibeast/org-vcard and > https://github.com/nikclayton/ob-sql-mode ? Are you saying these packages are unmaintained and asking whether they should be moved to the orphanage? When I feel like that about a package, I usually open an issue

Re: org-assert-version considered harmful

2023-08-17 Thread Ihor Radchenko
Max Nikulin writes: > On 16/08/2023 18:08, Ihor Radchenko wrote: >> Every library will have >> >> (require 'org-foo-9.X "org-foo") >> (require 'org-bar-9.X "org-bar") >> ... >> (provide 'org-lib) >> (provide 'org-lib-9.X) > > Are you going to update patch version of particular library on each

Re: [BUG] org-element-cache Org parser error [9.7 (9.7-??-d6f3aed @ /home/guillaume.muller/.emacs.d/.local/straight/build-28.1/org/)]

2023-08-17 Thread Ihor Radchenko
Guillaume MULLER writes: > When I start DoomEmacs, I get this message: > > --- > Warning (org-element-cache): org-element--cache: Org parser error in > packages.el::4667. Resetting. > The error was: (error "rx ‘**’ range error") > Backtrace: > nil > Please report this to Org mode mailing

Re: [patch] ox-latex.el: fix blank lines behavior in verse block

2023-08-17 Thread Juan Manuel Macías
Ihor Radchenko writes: > Thanks! > >> * (org-latex-verse-block): now the treatment of blank lines is >> consistent with the syntax of the LaTeX `verse' environment, and the >> one provided by the `verse' package. If the `:literal' attribute is >> used, all blank lines are preserved and exported

Re: [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots

2023-08-17 Thread gerard . vermeulen
On 17.08.2023 14:10, Ihor Radchenko wrote: gerard.vermeu...@posteo.net writes: Your patches allow anyone to change org-babel-python--def-format-value. For instance, I want to use black to "pretty-print" certain tree-like structures May you simply add an extra code to transform output as

Re: [BUG] Global agenda TODO list not able to filter to some custom [9.7 (9.7-??-6eb773053 @ /home/shortcut/.emacs.d/.local/straight/build-28.1/org/)] keywords

2023-08-17 Thread Ihor Radchenko
writes: > When adding a custom sequence of todo keywords to `org-todo-keywords', “`[ ]' > -> `[X]'”, the function `org-todo-list' will not filter to those entries with > keyword `[ ]', and entries with keyword `[X]' will not be displayed at all. > > Steps to reproduce: > ... Thanks for

Re: BUG: org-cut-special on inlinetask kill until point-max

2023-08-17 Thread Ihor Radchenko
Michael Dauer writes: > I probably mis-interpreted the code. Because then I would also fail for > normal headings. Just thinking about the symptoms I think the issue Is that > (org-end-of-subtree) works with type 'headline. And inlinetask is a > different type, right? Yes. Inlinetask is not

Re: [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots

2023-08-17 Thread Ihor Radchenko
Jack Kamm writes: > Following up on a discussion from last month [1], I am reviving my > proposal from a couple years ago [2] to improve ob-python results > handling. Since it's a relatively large change, I am sending it to the > list for review before applying the patch. Some comments on the

Re: [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots

2023-08-17 Thread Ihor Radchenko
Jack Kamm writes: > I attach a 2nd patch implementing this. It also makes ":results table" > the default return type for dict. (Use ":results verbatim" to get the > dict as a string instead). Thanks! >> #+begin_src python :results list >>return {"a": 1, "b": 2} >> #+end_src >> >>

Re: BUG: org-cut-special on inlinetask kill until point-max

2023-08-17 Thread Michael Dauer
I looked directly into the code and I think I found the issue: (org-copy-subtree) calls (org-end-of-subtree) without providing an element. But without an element this function just jumps to (point-max). I would expect a different behavior or (org-end-of-subtree). Since element is optional it

Re: [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots

2023-08-17 Thread gerard . vermeulen
On 17.08.2023 06:04, Jack Kamm wrote: I attach a 2nd patch implementing this. It also makes ":results table" the default return type for dict. (Use ":results verbatim" to get the dict as a string instead). I am also putting a branch with these changes here:

Re: [PATCH] ob-tangle.el: restore :tangle closure nil behavior

2023-08-17 Thread Ihor Radchenko
Tom Gillespie writes: >> My confusion about you patch comes from the fact that >> >> #+begin_src emacs-lisp :tangle (if (= 1 1) "yes") >> 2 >> #+end_src >> >> works just fine on main. > > It appears to work fine on main, but that is because > what is actually happening behind the scenes is that

Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

2023-08-17 Thread Ihor Radchenko
Jonathan Gregory writes: >> Ok. Would you mind adding a commit message, as described in >> https://orgmode.org/worg/org-contribute.html#first-patch? > > Patch attached. I also attached a test file. Thanks! Applied, onto main. Fixed.

Re: [patch] ox-latex.el: fix blank lines behavior in verse block

2023-08-17 Thread Ihor Radchenko
Juan Manuel Macías writes: > Here is the modified patch. Thanks! > * (org-latex-verse-block): now the treatment of blank lines is > consistent with the syntax of the LaTeX `verse' environment, and the > one provided by the `verse' package. If the `:literal' attribute is > used, all blank lines

Re: [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots

2023-08-17 Thread Ihor Radchenko
gerard.vermeu...@posteo.net writes: > Your patches allow anyone to change org-babel-python--def-format-value. > For instance, I want to use black to "pretty-print" certain tree-like > structures May you simply add an extra code to transform output as needed? -- Ihor Radchenko // yantar92, Org

Re: [MAINTENANCE] Org orphanage?

2023-08-17 Thread Ihor Radchenko
Jonas Bernoulli writes: > I just went through the list of packages mentioned there as being hosted > on https://github.com/emacsorphanage: Thanks! > - org-grep should be delisted as it found a new home at > https://sr.ht/~minshall/org-grep/ Fixed. https://git.sr.ht/~bzg/worg/commit/667e1142

Re: [MAINTENANCE] Org orphanage?

2023-08-17 Thread Ihor Radchenko
Jonas Bernoulli writes: > I think what we have now is a good compromise. We continue to use the > existing emacsorphanage for org-related packages, which previously were > maintained on github anyway. If more org-related packages are abandoned > and they already use github, then I will

Re: BUG: org-cut-special on inlinetask kill until point-max

2023-08-17 Thread Michael Dauer
I understand your view. From the user perspective inline task are still more a specialization of a task, which is a specialisation of a heading. Here is my implementation of how I see it that it should behave: (defun pm-cut-special () "Like org-cut-special but also works on inlinetask."

Re: BUG: org-cut-special on inlinetask kill until point-max

2023-08-17 Thread Ihor Radchenko
Michael Dauer writes: > I looked directly into the code and I think I found the issue: > (org-copy-subtree) calls (org-end-of-subtree) without providing an element. > But without an element this function just jumps to (point-max). This is not true. Please make sure that you are using the latest

Re: BUG: org-cut-special on inlinetask kill until point-max

2023-08-17 Thread Michael Dauer
I probably mis-interpreted the code. Because then I would also fail for normal headings. Just thinking about the symptoms I think the issue Is that (org-end-of-subtree) works with type 'headline. And inlinetask is a different type, right? IMO org-mode should consistently treat inlinetasks