Re: [O] [PATCH] Don't push url to kill-ring when invoking org-protocol-capture

2017-04-17 Thread Nicolas Goaziou
Hello,

Matt Lundin  writes:

> Subject: [PATCH] Don't push url to kill-ring when invoking 
> org-protocol-capture
>
> * lisp/org-protocol.el: (org-protocol-do-capture) Don't push link to
>   kill-ring when invoking org-protocol-capture. Otherwise,
>   org-protocol-do-capture interferes with capture templates that
>   insert the contents of the clipboard or the kill ring.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



[O] Bug: Stuck projects view reverts to tag match on refresh [9.0.5]

2017-04-17 Thread Allen Li

The stuck projects agenda view reverts to a tag match when it is
refreshed with r or g

Example of original view:

List of stuck projects: 
  Refile: Stuck
:refile::project:

After refreshing:

Headlines with TAGS match: project
Press ‘C-u r’ to search again with new search string
  Refile: Stuck
:refile::project:
  Refile: Unstuck  
:refile::project:

Emacs  : GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.7)
 of 2017-02-07
Package: Org mode version 9.0.5 (9.0.5-elpa @ ~/.emacs.d/elpa/org-20170210/)



Re: [O] ANN/RFC: ox-epub

2017-04-17 Thread Mark Meyer
> "Eric" == Eric S Fraga  writes:

Hi Eric,

Eric> this sounds potentially very useful (to me, at least).  Will
Eric> it export equations and tables, even if as images?  I guess I
Eric> could simply try it... which I'll aim to do this week.

epubtest.org is something aking to an exhaustive test of feature
compliance of reading
systems. http://epubtest.org/testsuite/epub3/feature/mathml/ details the
MathML support for these devices. It looks kind of discouraging.

Now most readers support some kind of JavaScript, but that support is
not clearly specified in the standard. So using MathJax may be possible
on some devices, but not on others.

I'll keep looking on how to best implement this.

Cheers, Mark

-- 
   Mark Meyer
   m...@ofosos.org



Re: [O] ANN/RFC: ox-epub

2017-04-17 Thread Mark Meyer
Hi Eric,

> "Eric" == Eric S Fraga  writes:

Eric> this sounds potentially very useful (to me, at least).  Will
Eric> it export equations and tables, even if as images?  I guess I
Eric> could simply try it... which I'll aim to do this week.

Tables should be no problem. Equations I'll say are not supported. I'd
assume you want MathML support, this was delivered with EPUB 3.0.1,
while we're currently targeting EPUB 2.0.1.

Let me look into that.

Cheers, Mark

-- 
   Mark Meyer
   m...@ofosos.org



Re: [O] ANN: org-sticky-header

2017-04-17 Thread Eric Abrahamsen
Adam Porter  writes:

> Hi friends,
>
> I've posted another package which you might find useful:
>
> https://github.com/alphapapa/org-sticky-header
>
> It's modeled on semantic-stickyfunc-mode.  When you scroll down and push
> an Org heading out of view, it displays that heading in the Emacs header
> line at the top of the window so you don't forget which heading the
> partially displayed entry at the top belongs to.
>
> It seems to be working well so far.  Please let me know if you have any
> feedback.

I love it! I've wanted something like this for long text files for ages
-- this scratches a very old itch. Thanks for doing this, and I'll
report back with issues, though it's work great so far.




[O] [PATCH] Don't push url to kill-ring when invoking org-protocol-capture

2017-04-17 Thread Matt Lundin
From: Matt Lundin 
To: Org Mode 
Date: Mon, 17 Apr 2017 20:58:30 -0500
Subject: [PATCH] Don't push url to kill-ring when invoking
 org-protocol-capture
--text follows this line--

* lisp/org-protocol.el: (org-protocol-do-capture) Don't push link to
  kill-ring when invoking org-protocol-capture. Otherwise,
  org-protocol-do-capture interferes with capture templates that
  insert the contents of the clipboard or the kill ring.
---
 lisp/org-protocol.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index a59540a30..825435674 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -498,7 +498,6 @@ Now template ?b will be used."
 	 (org-capture-link-is-already-stored t)) ;; avoid call to org-store-link
 (setq org-stored-links
 	  (cons (list url title) org-stored-links))
-(kill-new orglink)
 (org-store-link-props :type type
 			  :link url
 			  :description title
-- 
2.12.2




Re: [O] org-mobile-push needs a visible frame ?

2017-04-17 Thread Ian Dunn
Bingo  writes:

> Hi,
>
> I see that when there is an emacs server without a visible frame, 
>
> emacsclient --eval "(org-mobile-push)" , gives the error :
>
> *ERROR*: Unknown terminal type
>
> Only when there is a visible frame does org-mobile-push succeed. Is there a
> reason why org-mobile-push needs a frame ? How can I make it work without a
> frame?
>
> Org version is 8.3.2, emacs version 24.4.1, Debian Linux 8.2.
>
> thanks
>

What do you have org-agenda-window-setup set to?  I was able to fix the
problem on my machine by setting org-agenda-window-setup to
current-window.

-- 
Ian Dunn



[O] ANN: org-sticky-header

2017-04-17 Thread Adam Porter
Hi friends,

I've posted another package which you might find useful:

https://github.com/alphapapa/org-sticky-header

It's modeled on semantic-stickyfunc-mode.  When you scroll down and push
an Org heading out of view, it displays that heading in the Emacs header
line at the top of the window so you don't forget which heading the
partially displayed entry at the top belongs to.

It seems to be working well so far.  Please let me know if you have any
feedback.

Thanks,
Adam




Re: [O] ANN/RFC: ox-epub

2017-04-17 Thread Eric S Fraga
On Sunday, 16 Apr 2017 at 15:18, Mark Meyer wrote:
> Hi,
> this is to announce that ox-epub is now in a somewhat working state and
> pretty much aligned with the rest of the ox framework.
>
> https://github.com/ofosos/ox-epub

Hi Mark,

this sounds potentially very useful (to me, at least).  Will it export
equations and tables, even if as images?  I guess I could simply try
it... which I'll aim to do this week.

thanks,
eric

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 26.0.50, Org release_9.0.5-444-g998576


signature.asc
Description: PGP signature


Re: [O] org-protocol-check-filename-for-protocol obscures other errors

2017-04-17 Thread Adam Porter
Nicolas Goaziou  writes:

> I tried to improve the situation in maint branch. Please let me know if
> it makes your life easier !

Looks great, thanks!




Re: [O] Radio targets

2017-04-17 Thread R C
Hi,
OK, thank you. I am using emacs with spacemacs and it is still using the
melpa version of orgmode as I am unable to get it to load the git branch of
orgmode. I will try it out once I make the switch.

On Sun, Apr 16, 2017 at 2:54 AM, Nicolas Goaziou 
wrote:

> Hello,
>
> R C  writes:
>
> > Please see attached. The org file is just:
> >
> > * <<>> heading
> >   The discussion in *abc* highlights the issue.
>
> Fixed. Thank you.
>
> Regards,
>
> --
> Nicolas Goaziou0x80A93738
>


[O] Handling custom link types for html export in v 9.0 - Replacement for deprecated `org-add-link-type`?

2017-04-17 Thread Milan Zimmermann
Hi:

I have a question about how to define custom link type, which before
9.0 used the (9.0) deprecated  `org-add-link-type`.

1. Let me first provide the context:

There is often a need to generate, for org links export/publish to
Html, elements where img src URL starts with a slash, like this



The only way that was possible before v9, for this to be exported from
a link such as

[[/images/a.jgp]]

was to use a method described in

http://stackoverflow.com/questions/14684263/how-to-org-mode-image-absolute-path-of-export-html

- Basically, the solution described there is

a) define a custom link type such as "img"
b) in org,  use [[img:images/a.jpg]]
c) define two functions handling the img link in org and on
export/publish, and call (org-add-link-type "img"
'org-custom-link-img-follow 'org-custom-link-img-export)

2. The problem and question

In org 9.0, we get `org-add-link-type ... This function is obsolete
since Org 9.0 use `org-link-set-parameters' instead.

My problem is I have no idea how to, in a practical sense, use
`org-link-set-parameters` to define a custom link type "img" and
handle it's image handling in both org buffer and Html publish.

My question is, are there any links and examples how one would do the
above in 9.0?

Thanks
Milan



Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
On Mon, Apr 17, 2017 at 2:05 PM Nicolas Goaziou 
wrote:

> This was a typo of mine. Fixed. Thank you.
>
> Regards,
>

Thanks. I confirm the fix.
-- 

Kaushal Modi


Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Nicolas Goaziou
Hello,

Kaushal Modi  writes:

> While that error is fixed, we still have this byte compilation warning:
>
> org-capture.el:1586:1:Warning: Unused lexical variable ‘first-value’
>
> I haven't used pcase extensively, but based on the warning, the below
> doesn't work as intended in the compiled elc:
>
>((or "C" "L")
> (let ((insert-fun (if (equal key "C") #'insert
> (lambda (s) (org-insert-link 0 s
>   (first-value (car org-capture--clipboards)))
>   (pcase (length org-capture--clipboards)
> (`nil nil)
> (`(,value) (funcall insert-fun value))
> (`(,first-value . ,_)
>  (funcall insert-fun
>   (read-string "Clipboard/kill value: "
> first-value; Based on the
> warning, does it mean that the value of first-value is not picked from the
> value calculated in the let form above?
> 'org-capture--clipboards
> first-value))) ; And the same
> here
> (_ (error "Invalid `org-capture--clipboards' value: %S"
>   org-capture--clipboards)

This was a typo of mine. Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
While that error is fixed, we still have this byte compilation warning:

org-capture.el:1586:1:Warning: Unused lexical variable ‘first-value’

I haven't used pcase extensively, but based on the warning, the below
doesn't work as intended in the compiled elc:

   ((or "C" "L")
(let ((insert-fun (if (equal key "C") #'insert
(lambda (s) (org-insert-link 0 s
  (first-value (car org-capture--clipboards)))
  (pcase (length org-capture--clipboards)
(`nil nil)
(`(,value) (funcall insert-fun value))
(`(,first-value . ,_)
 (funcall insert-fun
  (read-string "Clipboard/kill value: "
first-value; Based on the
warning, does it mean that the value of first-value is not picked from the
value calculated in the let form above?
'org-capture--clipboards
first-value))) ; And the same
here
(_ (error "Invalid `org-capture--clipboards' value: %S"
  org-capture--clipboards)
-- 

Kaushal Modi


Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
This patch works:

>From 5edec74298a0140c5ebf55e7be0d64de6c702b17 Mon Sep 17 00:00:00 2001
From: Kaushal Modi 
Date: Mon, 17 Apr 2017 11:01:28 -0400
Subject: [PATCH] Fix nil case in pcase

* lisp/org-capture.el (org-capture-fill-template): Use `nil for the
  nil case in pcase form.
---
 lisp/org-capture.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 76cacdda764..cd67c280392 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1782,7 +1782,7 @@ The template may still contain \"%?\" for cursor
positioning."
  (lambda (s) (org-insert-link 0 s
(first-value (car org-capture--clipboards)))
(pcase (length org-capture--clipboards)
- (nil nil)
+ (`nil nil)
  (`(,value) (funcall insert-fun value))
  (`(,first-value . ,_)
   (funcall insert-fun
-- 
2.11.0

> --

Kaushal Modi


Re: [O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
To add, I am using emacs build from the master branch as of today.

Doing M-x byte-compile-file on org-capture.el gives:

-
Compiling file /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-capture.el at
Mon Apr 17 10:48:22 2017
org-capture.el:1586:1:Error: Unknown pattern ‘nil’
-


On Mon, Apr 17, 2017 at 10:11 AM Kaushal Modi 
wrote:

> I am on master branch: ea3754f.
>
> A recent change in org-capture.el breaks compilation:
>
-- 

Kaushal Modi


[O] Failure in compiling org-capture.el

2017-04-17 Thread Kaushal Modi
I am on master branch: ea3754f.

A recent change in org-capture.el breaks compilation:

In toplevel form:
org-capture.el:1586:1:Error: Unknown pattern ‘nil’
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-install.el...
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-loaddefs.el...
Compiling /home/kmodi/.emacs.d/elisp/org-mode/lisp/org-version.el...
Done (Total of 0 files compiled, 1 failed, 121 skipped)
make[2]: Leaving directory `/home/kmodi/.emacs.d/elisp/org-mode/lisp'
if [ ! -d
/home/kmodi/usr_local/apps/6/emacs/master/share/emacs/site-lisp/org ] ;
then \
  install -m 755 -d
/home/kmodi/usr_local/apps/6/emacs/master/share/emacs/site-lisp/org ; \
fi ;
install -m 644 -p ob-C.elc ob-J.elc ob-R.elc ob-abc.elc ob-asymptote.elc
ob-awk.elc ob-calc.elc ob-clojure.elc ob-comint.elc ob-coq.elc ob-core.elc
ob-css.elc ob-ditaa.elc ob-dot.elc ob-ebnf.elc ob-emacs-lisp.elc
ob-eval.elc ob-exp.elc ob-forth.elc ob-fortran.elc ob-gnuplot.elc
ob-groovy.elc ob-haskell.elc ob-hledger.elc ob-io.elc ob-java.elc ob-js.elc
ob-keys.elc ob-latex.elc ob-ledger.elc ob-lilypond.elc ob-lisp.elc
ob-lob.elc ob-lua.elc ob-makefile.elc ob-matlab.elc ob-maxima.elc
ob-mscgen.elc ob-ocaml.elc ob-octave.elc ob-org.elc ob-perl.elc
ob-picolisp.elc ob-plantuml.elc ob-processing.elc ob-python.elc ob-ref.elc
ob-ruby.elc ob-sass.elc ob-scala.elc ob-scheme.elc ob-screen.elc ob-sed.elc
ob-shell.elc ob-shen.elc ob-sql.elc ob-sqlite.elc ob-stan.elc ob-table.elc
ob-tangle.elc ob.elc org-agenda.elc org-archive.elc org-attach.elc
org-bbdb.elc org-bibtex.elc org-capture.elc org-clock.elc org-colview.elc
org-compat.elc org-crypt.elc org-ctags.elc org-datetree.elc org-docview.elc
org-duration.elc org-eldoc.elc org-element.elc org-entities.elc
org-eshell.elc org-eww.elc org-faces.elc org-feed.elc org-footnote.elc
org-gnus.elc org-habit.elc org-id.elc org-indent.elc org-info.elc
org-inlinetask.elc org-irc.elc org-lint.elc org-list.elc org-macro.elc
org-macs.elc org-mhe.elc org-mime.elc org-mobile.elc org-mouse.elc
org-pcomplete.elc org-plot.elc org-protocol.elc org-rmail.elc org-src.elc
org-table.elc org-timer.elc org-w3m.elc org.elc ox-ascii.elc ox-beamer.elc
ox-html.elc ox-icalendar.elc ox-latex.elc ox-man.elc ox-md.elc ox-odt.elc
ox-org.elc ox-publish.elc ox-texinfo.elc ox.elc ob-C.el ob-J.el ob-R.el
ob-abc.el ob-asymptote.el ob-awk.el ob-calc.el ob-clojure.el ob-comint.el
ob-coq.el ob-core.el ob-css.el ob-ditaa.el ob-dot.el ob-ebnf.el
ob-emacs-lisp.el ob-eval.el ob-exp.el ob-forth.el ob-fortran.el
ob-gnuplot.el ob-groovy.el ob-haskell.el ob-hledger.el ob-io.el ob-java.el
ob-js.el ob-keys.el ob-latex.el ob-ledger.el ob-lilypond.el ob-lisp.el
ob-lob.el ob-lua.el ob-makefile.el ob-matlab.el ob-maxima.el ob-mscgen.el
ob-ocaml.el ob-octave.el ob-org.el ob-perl.el ob-picolisp.el ob-plantuml.el
ob-processing.el ob-python.el ob-ref.el ob-ruby.el ob-sass.el ob-scala.el
ob-scheme.el ob-screen.el ob-sed.el ob-shell.el ob-shen.el ob-sql.el
ob-sqlite.el ob-stan.el ob-table.el ob-tangle.el ob.el org-agenda.el
org-archive.el org-attach.el org-bbdb.el org-bibtex.el org-capture.el
org-clock.el org-colview.el org-compat.el org-crypt.el org-ctags.el
org-datetree.el org-docview.el org-duration.el org-eldoc.el org-element.el
org-entities.el org-eshell.el org-eww.el org-faces.el org-feed.el
org-footnote.el org-gnus.el org-habit.el org-id.el org-indent.el
org-info.el org-inlinetask.el org-install.el org-irc.el org-lint.el
org-list.el org-macro.el org-macs.el org-mhe.el org-mime.el org-mobile.el
org-mouse.el org-pcomplete.el org-plot.el org-protocol.el org-rmail.el
org-src.el org-table.el org-timer.el org-w3m.el org.el ox-ascii.el
ox-beamer.el ox-html.el ox-icalendar.el ox-latex.el ox-man.el ox-md.el
ox-odt.el ox-org.el ox-publish.el ox-texinfo.el ox.el org-version.el
org-loaddefs.el
/home/kmodi/usr_local/apps/6/emacs/master/share/emacs/site-lisp/org
install: cannot stat `org-capture.elc': No such file or directory
make[1]: *** [install] Error 1
make[1]: Leaving directory `/home/kmodi/.emacs.d/elisp/org-mode/lisp'
make: *** [install-lisp] Error 2


-- 

Kaushal Modi


Re: [O] Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

2017-04-17 Thread Nicolas Goaziou
Hello,

Damien Cassou  writes:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>  http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> 
>
> Given this org file
>
> [[http://foo.com][https://foo.com/badge.svg]]
>
> [[http://foo.com][https://foo.com/badge.svg?branch=master]]
>
>
> I get this when exporting to HTML:
>
>   
> 
>   http://foo.com";>
> https://foo.com/badge.svg"; alt="badge.svg" />
>   
> 
>   
>
>   
> http://foo.com";>
>href="https://foo.com/badge.svg?branch=master";>https://foo.com/badge.svg?branch=master
> 
>   
>
>
> I was expecting both outputs to be figures with an image. It seems that
> the query "?branch=master" at the end of the URL prevents the output of
> a picture.

Couldn't you extend `org-html-inline-image-rules'?

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: Clipboard history is empty when using %^C in capture template [9.0.5 (9.0.5-elpaplus @ /home/mir/.emacs.d/elpa/org-plus-contrib-20170210/)]

2017-04-17 Thread Nicolas Goaziou
Hello,

Allen Li  writes:

> Using the %^C expansion in a capture template brings up a minibuffer
> prompt to read/select a clipboard value, but there are no values to
> select from.
>
> The relevant code is in the function org-capture-fill-template.
>
>  ("C"
>   (cond
>((= (length clipboards) 1) (insert (car clipboards)))
>((> (length clipboards) 1)
> (insert (read-string "Clipboard/kill value: "
>  (car clipboards)
>  '(clipboards . 1)
>  (car clipboards))
>
> It looks like the intention is to put the list of possible clipboard
> values into the minibuffer history for read-string, but in practice I
> get an error saying the history is empty.
>
> I suspect that the problem is that clipboard is lexically bound, and
> since read-string takes a symbol for the history, it cannot get the
> lexical value for clipboards from the symbol argument.

Thank you for the report.

I think I fixed it in maint. Could you confirm it?

Regards,

-- 
Nicolas Goaziou



[O] [PATCH] ob-C.el: Fix command to perform on remote host

2017-04-17 Thread Ivan Truskov
Date: Mon, 17 Apr 2017 12:45:39 +0300
/host:/tmp/C-bin/tempfilename.exe". Processing name of binary file
>From 1525efb65438f006be742b18d27804bf8409feae Mon Sep 17 00:00:00 2001
* lisp/ob-C.el (org-babel-C-execute): Made sure name of compiled
program is converted to local representation before sending it to the
shell on remote host.

The problem was when one would try to evaluate C source code block in
the file on remote host. Compilation would go normally, then
evaluation will fail with error like "/bin/sh: unable to find file
prevents that.

TINYCHANGE
---
 lisp/ob-C.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ob-C.el b/lisp/ob-C.el
index 795bcb2..e54e174 100644
--- a/lisp/ob-C.el
+++ b/lisp/ob-C.el
@@ -161,7 +161,7 @@ or `org-babel-execute:C++' or `org-babel-execute:D'."
   (org-babel-eval
(pcase org-babel-c-variant
  ((or `c `cpp)
-  (concat tmp-bin-file cmdline))
+  (concat (org-babel-process-file-name tmp-bin-file) cmdline))
  (`d
   (format "%s %s %s %s"
   org-babel-D-compiler
-- 
2.7.4




Re: [O] Bug: Using org-capture with a template adds an unnecessary newline regardless of flags set [9.0.5 (9.0.5-elpa @ /home/igor/.emacs.d/elpa/org-20170210/)]

2017-04-17 Thread Nicolas Goaziou
Hello,

Igor Perepelytsya  writes:

> Using a template with org-capture to create a new org entry will add an
> unwanted newline after it. This occurs regardless of the contents of the
> template file, whether or not the 'empty-lines 1' / 'empty-lines-after
> 1' checkboxes are ticked in org-customize, or `empty-lines` /
> `empty-lines-after` keys are set to 0 manually. I expected that there
> would be no newline added by default after a template is inserted into
> an org-capture buffer.
>
> This appears to happen because
> `org-capture-place-(entry/plain-text/etc)` defuns in org-capture.el have
> `(org-capture-empty-lines-after 1)` in them by default. Changing this to
> `(org-capture-empty-lines-after)` and byte-compiling the file fixes the
> issue. I am not aware of any reason for 1 to be the default forced value
> here.

Would you want to provide a patch for that? Some tests in
"test-org-capture.el" would also be highly appreciated.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] ox-confluence.el: Blank org table cells[...]

2017-04-17 Thread Nicolas Goaziou
Hello,

Stephen Mackenzie  writes:

> First post..
> Disclaimer, I have no idea what I'm doing. (Don't know lisp, don't know how
> to use git format-patch correctly(?), etc.
> Fixed this for myself and wanted to try my hand at submitting it.
> If I did a terrible job, let me know and I'll try to remedy.

No, this is very good.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] org-protocol-check-filename-for-protocol obscures other errors

2017-04-17 Thread Nicolas Goaziou
Hello,

Adam Porter  writes:

> I've found that catching errors at this spot in
> org-protocol-check-filename-for-protocol (currently line 618 in the
> file):
>
> file:~/src/org-mode/lisp/org-protocol.el::(error
>
> Is causing a couple of problems.
>
> 1.  Any error in the sub-protocol handler causes the handler to be
> called a second time with an old-style link string.  I guess this is
> okay if the reason for the error is the handler's not handling new-style
> links, but if not, calling it a second time with the other string
> doesn't work.
>
> 2.  Catching all errors here obscures any error in the sub-protocol
> handler.  This makes it very difficult to debug the handler.
>
> For example, in my handler I was calling call-process-region with a
> final argument which should have been a string, but because of a bug in
> my code the argument was nil, and this caused call-process-region to
> give an error.  But the error was caught and replaced with the warning,
> and then the handler was called a second time, which, of course, failed
> again.  Even using edebug on the handler didn't help, because the error
> was still obscured.  I had to take apart the handler and run each
> expression manually to get to the real error.  (I tried temporarily
> removing the condition-case from
> org-protocol-check-filename-for-protocol, but for some reason that
> didn't help--I probably did something wrong.)
>
> Could this code be adjusted to help avoid this problem in the future?

I tried to improve the situation in maint branch. Please let me know if
it makes your life easier !

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] lisp/org-el: Fix explanation, if state change is blocked by contained checkboxes

2017-04-17 Thread Nicolas Goaziou
Hello,

Marc Ihm  writes:

> The patch below fixes a minor problem:
>
> Consider a node, which contains unchecked checkboxes; if you have set
> org-enforce-todo-checkbox-dependencies and try to change the node to
> DONE, you will be denied with a message explaining why. However in this
> special case the explanation would be wrong in talking of an unrelated
> node instead of the checkboxes.
>
> The fix uses the already existing variable org-blocked-by-checkboxes
> (which is handled in org-block-todo-from-checkboxes).  Similar code is
> already present in org-agenda-dim-blocked-tasks within org-agenda.el.
>
>
> Please review the patch and let me know, if you have any comments or
> questions.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] [PATCH] : org-link-search failing to find links created by clock table

2017-04-17 Thread Nicolas Goaziou
Hello,

"Stacey Marshall"  writes:

> Sorry, I'm trying out MailMate and forgot to select Plain Text when 
> copying in from Emacs.
>
> * Example of the issue
>
> Emacs  : GNU Emacs 25.2.1 (x86_64-apple-darwin16.4.0, Carbon Version 157 
> AppKit 1504.81)
>   of 2017-03-07
> Package: Org mode version 9.0.5 (release_9.0.5-351-g0e0fda.dirty @ 
> /Users/stacey/.emacs.d/org-mode/lisp/)
>
> In this buffer the TODO keywords are FIXME and FIXED, as set by:
>
> #+SEQ_TODO: FIXME FIXED
>
> #+BEGIN: clocktable :maxlevel 4 :scope subtree :link t
> #+CAPTION: Clock summary at [2017-04-14 Fri 20:01]
>
> | Headline   
>  | Time  | |   |   |
> |+---+-+---+---|
> | *Total time*   
>  | *1h 9min* | |   |   |
> |+---+-+---+---|
> | [[file:/tmp/test.org::Example%20of%20the%20issue][Example of the 
> issue]]   | 1h 9min   | |   
> |   |
> | \_  [[file:/tmp/test.org::Test%20log][Test log]]   
>  |   | 0h 4min |   |   |
> | \_  [[file:/tmp/test.org::Test%20log][FIXME Test log]] 
>  |   | 1h 0min |   |   |
> | \_  [[file:/tmp/test.org::test%20with%20comment%20no%20to-do][COMMENT 
> test with comment no to-do]] |   | 0h 2min |   |   |
> | \_  
> [[file:/tmp/test.org::FIXME%20comment%20with%20to-do%20keyword][COMMENT 
> FIXME comment with to-do keyword]] |   | 0h 1min |   |   |
> | \_  [[file:/tmp/test.org::with%20a%20fraction][FIXME with a fraction]] 
>  |   | 0h 1min |   |   |
> | \_  [[file:/tmp/test.org::with%20a%20percentage][FIXME with a 
> percentage]] |   | 0h 1min | 
>|   |
> #+END:
>
> ** Test log
> :LOGBOOK:
> CLOCK: [2017-04-11 Tue 23:20]--[2017-04-11 Tue 23:24] =>  0:04
> :END:
> ** FIXME Test log
> :LOGBOOK:
> CLOCK: [2017-04-11 Tue 22:20]--[2017-04-11 Tue 23:20] =>  1:00
> :END:
>
> ** COMMENT test with comment no to-do
> :LOGBOOK:
> CLOCK: [2017-04-14 Fri 17:29]--[2017-04-14 Fri 17:31] =>  0:02
> :END:
> ** COMMENT FIXME comment with to-do keyword
> :LOGBOOK:
> CLOCK: [2017-04-14 Fri 17:31]--[2017-04-14 Fri 17:32] =>  0:01
> :END:
> ** FIXME with a fraction [1/2]
> :LOGBOOK:
> CLOCK: [2017-04-14 Fri 17:42]--[2017-04-14 Fri 17:43] =>  0:01
> :END:
> - [X] One
> - [ ] two
> ** FIXME with a percentage [50%]
> :LOGBOOK:
> CLOCK: [2017-04-14 Fri 17:32]--[2017-04-14 Fri 17:33] =>  0:01
> :END:
> - [ ] one
> - [X] two
>
>
> * Patch
>
> Appears that change ebbc675bd9890c451ad01910fa2625fa78baac9b way back
> in 9.0.1 needed to also modify org-clock.el, or at least when I revert
> that change I get the behavior I'm used to back.
>
> Below is a patch which modifies org-clock.el; Though I'm sure it can
> be approved upon.

Thank you for the analysis and the patch.  I incorporated your
suggestion in a larger patch since there were other fishy parts in the
function. It is now hopefully fixed.

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: :session doesn't honor :verbatim [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/26.0.50/lisp/org/)]

2017-04-17 Thread Michael Albinus
"Charles C. Berry"  writes:

>> However, I don't want to change this globally. Is there an org mean to
>> change this locally just for the session?
>>
>> Maybe the shell prompt could be customizable for a session in ob-sh.el?
>
> That happens in the shell. You can do this to start your session:
>
> #+BEGIN_SRC shell :session mysess
>PS1="MyPrompt-$ "
> #+END_SRC
>
> #+RESULTS:
>
> and then tell emacs to locally set `comint-prompt-regexp' to a value
> other than what was copied from `shell-prompt-pattern'
>
> #+BEGIN_SRC emacs-lisp
>(save-excursion
>  (pop-to-buffer "mysess")
>  (setq-local comint-prompt-regexp "MyPrompt-$ "))
> #+END_SRC
>
> #+RESULTS:
> : MyPrompt-$
>
> and then it should work.
>
> #+BEGIN_SRC shell :session mysess
>echo "a%b"
> #+END_SRC
>
> #+RESULTS:
> : a%b
>
> ---
>
> You might skip the second step and instead set `shell-prompt-pattern'
> to "MyPrompt-$ ". If `comint-use-prompt-regexp' is nil, then the
> `comint-prompt-regexp' is only consulted by ob-shell.el funs per the 
> docstring of comint-use-prompt-regexp.

Thanks for the examples. Anything goes, of course, but I'm hoping for a
tighter integration. Maybe a :prompt param to sh source blocks, which
sets the prompt in a session, and which also manipulates
`comint-prompt-regexp' or `shell-prompt-pattern' local in the session buffer.

Or a mechanism like in Tramp, where the shell prompt is set to a random
string not expected in the shell (see `tramp-end-of-output'), and
`comint-prompt-regexp' or `shell-prompt-pattern' are adapted
automatically local in the session buffer.

> Chuck

Best regards, Michael.