Re: [O] Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]

2019-07-14 Thread Nicolas Goaziou
Hello,

Marcin Borkowski  writes:

> Thanks.  How about this?

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]

2019-07-14 Thread Marcin Borkowski

On 2019-07-12, at 10:53, Nicolas Goaziou  wrote:

> Hello,
>
> Marcin Borkowski  writes:
>
>> Thanks.  I meant that - according to the manual - `t' should be
>> synonymous with `near' and not `all'.  I can fix the commit message, but
>> could you confirm that I'm right first?
>
> AFAICT, your guess sounds right.

Thanks.  How about this?

Best,

-- 
Marcin Borkowski
http://mbork.pl
>From 669b4347f35dd87815e9f232ab72533d6514d7d1 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski 
Date: Mon, 24 Jun 2019 21:05:56 +0200
Subject: [PATCH] Fix a bug when `org-agenda-todo-ignore-deadlines` is set to t

Make `t' synonymous with `near' instead of `all' (as is stated in the
docstring).
---
 lisp/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index daf51601d..673c3c311 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5444,7 +5444,7 @@ This function is invoked if `org-agenda-todo-ignore-deadlines',
 	  (and org-agenda-todo-ignore-deadlines
 	   (re-search-forward org-deadline-time-regexp end t)
 	   (cond
-		((memq org-agenda-todo-ignore-deadlines '(t all)) t)
+		((eq org-agenda-todo-ignore-deadlines 'all) t)
 		((eq org-agenda-todo-ignore-deadlines 'far)
 		 (not (org-deadline-close-p (match-string 1
 		((eq org-agenda-todo-ignore-deadlines 'future)
-- 
2.22.0



Re: [O] BEGIN - END markers in manual and guide

2019-07-14 Thread Carsten Dominik
Hi Nicolas,

On Sun, Jul 14, 2019 at 10:08 AM Nicolas Goaziou 
wrote:

> Hello,
>
> Carsten Dominik  writes:
>
> > I was wondering if we should change all the #+BEGIN and #+END stuff in
> the
> > manual and in the compact guide to lower case?  This is what the
> structure
> > templates insert, and it also looks better.  I'd be willing to do it,
> just
> > wondering if there are objections.
>
> Upper case is used as a way to emphasize specific syntax in code
> snippets.
>
> Also, in typesetting conventions,
>
> - =TITLE=, =BEGIN= ... =END= ::
>
>   Keywords and blocks are written in uppercase to enhance their
>   readability, but you can use lowercase in your Org files.
>
> Therefore, I do not object to this change, but I do think it is not
> necessary.
>

Yes, OK, I leave it like it is.

Regards

Carsten


>
> Regards,
>
> --
> Nicolas Goaziou
>
>


Re: [O] BEGIN - END markers in manual and guide

2019-07-14 Thread Nicolas Goaziou
Hello,

Carsten Dominik  writes:

> I was wondering if we should change all the #+BEGIN and #+END stuff in the
> manual and in the compact guide to lower case?  This is what the structure
> templates insert, and it also looks better.  I'd be willing to do it, just
> wondering if there are objections.

Upper case is used as a way to emphasize specific syntax in code
snippets.

Also, in typesetting conventions,

- =TITLE=, =BEGIN= ... =END= ::

  Keywords and blocks are written in uppercase to enhance their
  readability, but you can use lowercase in your Org files.

Therefore, I do not object to this change, but I do think it is not
necessary.

Regards,

-- 
Nicolas Goaziou



[O] BEGIN - END markers in manual and guide

2019-07-14 Thread Carsten Dominik
Hi,

I was wondering if we should change all the #+BEGIN and #+END stuff in the
manual and in the compact guide to lower case?  This is what the structure
templates insert, and it also looks better.  I'd be willing to do it, just
wondering if there are objections.

Carsten