Re: TODO or checkboxes in org tables

2020-05-07 Thread Axel Kielhorn
> Am 07.05.2020 um 19:05 schrieb Uwe Brauer : > "AK" == Axel Kielhorn writes: > > Hi Alex >>> Am 02.05.2020 um 21:33 schrieb Uwe Brauer : >>> >> "AK" == Axel Kielhorn writes: >>> >>> Hi Alex, >>> >>> I am not sure my first answer made it, so I apologize for a possible >>>

Re: [PATCH] Fix moving cursor in org-set-tags-command

2020-05-07 Thread Kyle Meyer
Matt Lundin writes: > Commit 44ec473c199262d89b372d8a6cd35bed7672164d from Feb. 23 causes > org-set-tags-command to move the cursor forward 1 char when situated on > headline asterisks. [...] > This commit modified a previous change on Feb. 21 > (450452de4b790706d187291f9f71a286f8f62004). But

[PATCH] Fix moving cursor in org-set-tags-command

2020-05-07 Thread Matt Lundin
Commit 44ec473c199262d89b372d8a6cd35bed7672164d from Feb. 23 causes org-set-tags-command to move the cursor forward 1 char when situated on headline asterisks. So if I am on the following level 1 headline with the cursor on the asterisk as below... * Headline ^ ...and I call org-set-tags

RE: [Bug] org-store-link should not insert a document level ID property

2020-05-07 Thread Matthew Lundin
Gustav Wikström writes: > Hi again, > > Patch is attached. It's not applied yet as it doesn't include anything > about user-configuration yet. @Matt Lundin, care to elaborate what you > had in mind in terms of that? > > With this patch a link before first headline is stored with the > filename

Re: [Bug]: org-capture-place-plain-text error when template :unnarrowed

2020-05-07 Thread Nicolas Goaziou
Hello, No Wayman writes: > org-capture-place-plain-text throws an error for templates which > meet the following criteria: > - entry type is 'plain > - the template has a non-nil :unnarrowed option > - the template string is not empty and does not explicitly > include "%?" > > Seems

Re: [Patch] Do not ignore headers argument in ob-latex

2020-05-07 Thread Nicolas Goaziou
Hello, Yuri Lensky writes: > Subject: [PATCH] lisp/ob-latex.el: Stop ignoring headers argument Thank you. > During default "png" export, the "headers" argument is no longer > explicitly ignored. According to the TODO in that function, this is not the first time it happens. Would you mind

Re: [PATCH] Allow org-capture-mode-hook to access org-capture-current-plist [9.3.6 (release_9.3.6-443-g0e8aff @ /home/n/.emacs.d/straight/build/org/)]

2020-05-07 Thread Nicolas Goaziou
Hello, No Wayman writes: > I'm proposing the following trivial patch to bring more consistency to > org-capture-mode's hooks. > By setting org-capture-current-plist before invoking org-capture-mode > in the capture buffer, users > can access the same variable in org-capture-mode-hook as they

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Nicolas Goaziou
Kévin Le Gouguec writes: >> (I hope I got that right.) LGTM. I applied the patch on your behalf. Now Org has future-proof support for Electric indent mode. Thank you.

[O] (no)export of special blocks

2020-05-07 Thread Ken Mankoff
Hello, I'd like to be able to optionally export/not-export a specific paragraph within a section, based on a top-level property. Is this possible in Org? I know I can toggle export of code blocks, but what about text blocks? More specifically, I'm writing a journal article and I would like to

Re: TODO or checkboxes in org tables

2020-05-07 Thread Uwe Brauer
>>> "AK" == Axel Kielhorn writes: Hi Alex >> Am 02.05.2020 um 21:33 schrieb Uwe Brauer : >> > "AK" == Axel Kielhorn writes: >> >> Hi Alex, >> >> I am not sure my first answer made it, so I apologize for a possible >> crossposting. > It didn’t reach me. >>

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Kévin Le Gouguec
Kévin Le Gouguec writes: > (I hope I got that right.) Except I forgot the explanatory comment, and I left a typo in the docstring. Ahem. diff --git a/lisp/org-compat.el b/lisp/org-compat.el index 2b35535fa..caaf5ce58 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -102,6 +102,12

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Kévin Le Gouguec
Nicolas Goaziou writes: > AFAICT, `newline-and-indent' doesn't accept any argument. Keeping it > introduces a build warning and test failures. Hence the removal. > > Since you were calling it with an argument I assume this may be > a novelty in Emacs 27. Wow, you're right. That caught me

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Kévin Le Gouguec
Stefan Monnier writes: >> +(defmacro org-test-with-minor-mode (mode state body) >> + "Run BODY after setting MODE to STATE. >> +Restore MODE to its former state afterward." >> + (declare (debug (sexp sexp body)) (indent 2)) >> + `(let ((old-state ,mode)) >> + (,mode (if ,state 1 0)) >>

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Stefan Monnier
> +(defmacro org-test-with-minor-mode (mode state body) > + "Run BODY after setting MODE to STATE. > +Restore MODE to its former state afterward." > + (declare (debug (sexp sexp body)) (indent 2)) > + `(let ((old-state ,mode)) > + (,mode (if ,state 1 0)) > + ,@body > + (,mode

Re: ical2org.awk

2020-05-07 Thread Eric S Fraga
On Thursday, 7 May 2020 at 14:05, Andreas Röhler wrote: > thanks providing ical2org.awk. > When running on Debian8 however, encountered a bunch of errors: [...] > Turns out had to install gawk. Yes, I guess ical2org does expect gawk. I should have made that clear. On my Debian installation

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Nicolas Goaziou
Kévin Le Gouguec writes: > I see you've removed ARG from the call to `newline-and-indent'; I don't > have a strong opinion about this (though I don't see a reason not to > keep it), but I guess the docstring of `org--newline' should be changed > to match? AFAICT, `newline-and-indent' doesn't

ical2org.awk

2020-05-07 Thread Andreas Röhler
Hi, thanks providing ical2org.awk. When running on Debian8 however, encountered a bunch of errors: awk: ./ical2org.awk: line 394: function strftime never defined awk: ./ical2org.awk: line 394: function gensub never defined awk: ./ical2org.awk: line 394: function gensub never defined awk:

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Kévin Le Gouguec
Nicolas Goaziou writes: > I fixed a typo and applied your patch. Thank you for fixing the typo in ORG-NEWS. I see you've removed ARG from the call to `newline-and-indent'; I don't have a strong opinion about this (though I don't see a reason not to keep it), but I guess the docstring of

Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers

2020-05-07 Thread Christian Heinrich
Hi, thanks for your (initial) patch! I traced another error down today and found your code by chance. I tested it on an org-drill file that I had (with over 3500 items and hence 3500 drawers) and this patch helps *a lot* already. (Performance broke in 4403d4685e19fb99ba9bfec2bd4ff6781c66981f

Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode

2020-05-07 Thread Nicolas Goaziou
Hello, Kévin Le Gouguec writes: > Here's a complete patch to make RET and C-j honor electric-indent-mode > in org-mode, targeting Org's master branch. Thank you very much. I fixed a typo and applied your patch. > +(defmacro org-test-with-minor-mode (mode state body) > + "Run BODY after

Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers

2020-05-07 Thread Karl Voit
Hi, * Karl Voit wrote: > Hi Ihor, > > * Ihor Radchenko wrote: >> >> So far, I came up with the following partial solution searching and >> showing hidden text. >> >> (defun org-find-text-property-region (pos prop) >> (define-advice isearch-search-string (:after ( _) put-overlay) >> (defun