Re: Bug: no math-mode detection for align-environment [9.3.7 (9.3.7-13-ge62ca4-elpaplus @ /home/stefi/.emacs.d/elpa/org-plus-contrib-20200713/)]

2020-08-27 Thread Kyle Meyer
Stefi writes:

> It might be a change to texmathp.el. It is part of Auctex and checks if
> math mode is on or off. I could not find align environment in the list
> of default environments. Maybe that has changed.
>
> However, I added align and align* to "Texmathp Tex Commands" from the
> customize browser (open a .tex file to customize auctex). Tab-expansion
> is working now. Can anyone confirm?
>
> In my .emacs, it added to custom-set-variables:
> '(texmathp-tex-commands (quote (("align*" env-on) ("align" env-on

Yes, that results in expansion on my end as well.

It looks like this issue was introduced with AUCTeX's 91701704 (Delete
overhead in extending font lock range of math expression, 2020-06-11).
If you're getting AUCTeX from ELPA, the regression is included the
current version there (12.2.4, 2020-06-29).

At the start of this month, it was fixed in f04a508f (Restore all math
environments in texmathp.el, 2020-08-01), so the issue should go away
with the next update that lands on ELPA.



Re: new feature for consideration: other-tab for org-agenda-window-setup

2020-08-27 Thread Kyle Meyer
Eric S Fraga writes:

> Dear all,
>
> Please see attached for a new version of my changes for adding
> 'other-tab as an option for org-agenda-window-setup.
>
> I think I've addressed all your comments, Kyle, but any more are
> welcome.  It would be good if somebody who is using an older version of
> Emacs, i.e. pre 27.1, could test the error handling: set
> org-agenda-window-setup to 'other-tab and see if it fails properly.  I
> only have v28.x on my systems!
>
> On v28.x, it seems to be working fine.

Thanks for the updated patch.  I've tested it on 26.3 as well as the
Emacs master branch.

> @@ -3769,6 +3776,10 @@ FILTER-ALIST is an alist of filters we need to apply 
> when
>(org-switch-to-buffer-other-window abuf))
>   ((eq org-agenda-window-setup 'other-frame)
>(switch-to-buffer-other-frame abuf))
> + ((eq org-agenda-window-setup 'other-tab)
> +  (if (fboundp 'switch-to-buffer-other-tab)
> +   (switch-to-buffer-other-tab abuf)
> + (user-error "Your version of Emacs does not have tab bar support.")))

Sorry, I've got another consistency/style nit-pick for you: the
convention is to omit the trailing period from error messages.  (No need
to resend for that.  I'll plan to adjust when applying.)

I'll let this sit for another day to see if other comments come in.



Re: org-link-set-parameters :complete how to prompt for description?

2020-08-27 Thread Ihor Radchenko
> I am guessing you were referring to org-link-make-string?

Well. Not really. But I am glad that you found the function you need.

Normally, org-link-make-description-function should be called for any
link inserted with org-insert-link to generate initial text for the
description prompt. The (possibly empty) prompt should actually be shown
regardless of the value of org-link-make-description-function. But I
guess you can as well directly return the link with description in your
completion function.

Best,
Ihor

TRS-80  writes:

>> On 2020-08-27 07:37, Ihor Radchenko wrote:
>> 
>>>Any tips would be greatly appreciated.
>> 
>>   Take a look at org-link-make-description-function
>> 
>>   Best,
>>   Ihor
>
> Hi Ihor,
>
> I am guessing you were referring to org-link-make-string?
>
> I don't know how I missed that.  All I can say is I don't think
> it is actually in the Docs anywhere.  Because I looked and
> looked (as well as searching Internet)!
>
> In either case, I truly am greatly appreciative, as promised.  :)
> Thanks a lot, Ihor!
>
> ---
>
> @All,
>
> Apologies for any duplicates received, I seem to have some
> trouble figuring out the correct thread and method to reply (even
> though I don't usually have problem on other lists).
>
> Assuming I didn't overlook it, perhaps this is an opportunity to
> improve said Docs?
>
> Cheers,
> TRS-80



Re: org-link-set-parameters :complete how to prompt for description?

2020-08-27 Thread TRS-80

On 2020-08-27 07:37, Ihor Radchenko wrote:


   Any tips would be greatly appreciated.


  Take a look at org-link-make-description-function

  Best,
  Ihor


Hi Ihor,

I am guessing you were referring to org-link-make-string?

I don't know how I missed that.  All I can say is I don't think
it is actually in the Docs anywhere.  Because I looked and
looked (as well as searching Internet)!

In either case, I truly am greatly appreciative, as promised.  :)
Thanks a lot, Ihor!

---

@All,

Apologies for any duplicates received, I seem to have some
trouble figuring out the correct thread and method to reply (even
though I don't usually have problem on other lists).

Assuming I didn't overlook it, perhaps this is an opportunity to
improve said Docs?

Cheers,
TRS-80



Re: new feature for consideration: other-tab for org-agenda-window-setup

2020-08-27 Thread Eric S Fraga
Dear all,

Please see attached for a new version of my changes for adding
'other-tab as an option for org-agenda-window-setup.

I think I've addressed all your comments, Kyle, but any more are
welcome.  It would be good if somebody who is using an older version of
Emacs, i.e. pre 27.1, could test the error handling: set
org-agenda-window-setup to 'other-tab and see if it fails properly.  I
only have v28.x on my systems!

On v28.x, it seems to be working fine.

thank you,
eric

-- 
: Eric S Fraga via Emacs 28.0.50, Org release_9.3.7-720-gbe5916
>From be5916aba7031cd2343d3e59a98a47496ced95f2 Mon Sep 17 00:00:00 2001
From: Eric S Fraga 
Date: Wed, 26 Aug 2020 17:17:42 +0100
Subject: [PATCH] Add other-tab option for org-agenda-window-setup

* org-agenda.el (org-agenda-prepare-window, org-agenda--quit): Handle
other-tab option for agenda view creation and exit.
---
 etc/ORG-NEWS   |  6 ++
 lisp/org-agenda.el | 27 +--
 2 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 8a3589ec2..6d8db0e18 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -291,6 +291,12 @@ possible via column view value edit or with ==.
 Counterpart of ~org-show-entry~.
 
 ** New options
+*** New option for using tabs in ~org-agenda-window-setup~
+
+Choosing ~other-tab~ for ~org-agenda-window-setup~ will open the
+agenda view in a new tab.  This will work with versions of Emacs since
+27.1 when ~tab-bar-mode~ was introduced.
+
 *** New option ~org-clock-auto-clockout-timer~
 
 When this option is set to a number and the user configuration
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 8ebc882fc..fd30e6d81 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -1100,14 +1100,21 @@ reorganize-frame  Show only two windows on the current frame, the current
   window and the agenda.
 other-frame   Use `switch-to-buffer-other-frame' to display agenda.
   Also, when exiting the agenda, kill that frame.
+other-tab Use `switch-to-buffer-other-tab' to display the
+  agenda, making use of the `tab-bar-mode' introduced
+  in Emacs version 27.1.  Also, kill that tab when
+  exiting the agenda view. 
+
 See also the variable `org-agenda-restore-windows-after-quit'."
   :group 'org-agenda-windows
   :type '(choice
 	  (const current-window)
 	  (const other-frame)
+	  (const other-tab)
 	  (const other-window)
 	  (const only-window)
-	  (const reorganize-frame)))
+	  (const reorganize-frame))
+  :package-version '(Org . "9.4"))
 
 (defcustom org-agenda-window-frame-fractions '(0.5 . 0.75)
   "The min and max height of the agenda window as a fraction of frame height.
@@ -1118,11 +1125,11 @@ It only matters if `org-agenda-window-setup' is `reorganize-frame'."
 
 (defcustom org-agenda-restore-windows-after-quit nil
   "Non-nil means restore window configuration upon exiting agenda.
-Before the window configuration is changed for displaying the agenda,
-the current status is recorded.  When the agenda is exited with
-`q' or `x' and this option is set, the old state is restored.  If
-`org-agenda-window-setup' is `other-frame', the value of this
-option will be ignored."
+Before the window configuration is changed for displaying the
+agenda, the current status is recorded.  When the agenda is
+exited with `q' or `x' and this option is set, the old state is
+restored.  If `org-agenda-window-setup' is `other-frame' or
+`other-tab', the value of this option will be ignored."
   :group 'org-agenda-windows
   :type 'boolean)
 
@@ -3769,6 +3776,10 @@ FILTER-ALIST is an alist of filters we need to apply when
   (org-switch-to-buffer-other-window abuf))
  ((eq org-agenda-window-setup 'other-frame)
   (switch-to-buffer-other-frame abuf))
+ ((eq org-agenda-window-setup 'other-tab)
+  (if (fboundp 'switch-to-buffer-other-tab)
+	  (switch-to-buffer-other-tab abuf)
+	(user-error "Your version of Emacs does not have tab bar support.")))
  ((eq org-agenda-window-setup 'only-window)
   (delete-other-windows)
   (pop-to-buffer-same-window abuf))
@@ -7389,6 +7400,10 @@ agenda."
   (cond
((eq org-agenda-window-setup 'other-frame)
 	(delete-frame))
+   ((eq org-agenda-window-setup 'other-tab)
+	(if (fboundp 'tab-bar-close-tab)
+	(tab-bar-close-tab)
+	  (user-error "Your version of Emacs does not have tab bar mode support.")))
((and org-agenda-restore-windows-after-quit
 	 wconf)
 	;; Maybe restore the pre-agenda window configuration.  Reset
-- 
2.28.0



Re: [PATCH] Add org-md-src-block for src-block formater

2020-08-27 Thread Berry, Charles
You might want to browse the ox-ravel repository[1].

It provides a collection of exporters that support reformatting src blocks and 
inline src blocks for a variety of output formats (including markdown).

Basically, it will produce a derived backend that adds source block 
reformatting to whatever the parent backend provides.

It is aimed at R flavored exports (knitr, Rmarkdown, Sweave), but customizable. 
One can, for example, allow emacs-lisp and shell src blocks to execute during 
export, but format python, C++ and R blocks for markdown and subsequent 
processing. It is easy to apply to any markdown exporter

See ox-ravel.org for details on customization.

It has plenty of stops and whistles even without customization. Check out the 
examples, such as demos.org and markdown.org.


HTH,

Chuck  

[1] 
https://github.com/chasberry/orgmode-accessories/blob/org-9-plus/markdown.org

> On Aug 26, 2020, at 10:26 PM, Naoya Yamashita  wrote:
> 
> Hi,
> I found `ox-md` exporter drop src-block language information.
> My patch fixes the behavior; to embed src-block language information
> using markdown src block grammar.
> 
> 1. Open some buffer
> 2. Tnsert below code
> 3. Turn on `org-mode`
> 4. `C-c C-e m M` (export as markdown in temp buffer)
> 
> ## org source
> ```org
> #+begin_src python
> print(1 + 2)
> #+end_src
> 
> #+begin_src emacs-lisp
> (print "hello")
> #+end_src
> 
> #+begin_src
> something source code
> #+end_src
> ```
> 
> ## before
> ```markdown
> 
> # Table of Contents
> 
> 
> 
> print(1 + 2)
> 
> (print "hello")
> 
> something source code
> 
> ```
> 
> ## after
> ```markdown
> 
> # Table of Contents
> 
> 
> 
> ```python
> print(1 + 2)
> ```
> 
> ```emacs-lisp
> (print "hello")
> ```
> 
> ```
> something source code
> ```
> 
> ```
> <0001-Add-org-md-src-block-for-src-block-formater.patch>





Re: Website revamp?

2020-08-27 Thread Maxim Nikulin

24.08.2020 14:43, TEC wrote:


Here's my overview of the current state of affairs
+ done :: nicer overall theme + done :: make site work on a variety of 
form-factors + done :: nice features page (with animations!)  + done :: 
prettier home page + done :: new "install" page + todo :: content for 
home page + todo :: releases page + todo :: documentation + todo :: 
contribute page + todo :: any missed pages/content


Certainly shortened version of features should appear on the main page. 
Some remarks. I do not know how much work is required to update animated 
images. Maybe someone will give better ideas, so do not hurry.


- Source code. I may be wrong but "C++" instead of "cpp" can be more 
friendly to older org versions bundled with emacs.


Concerning motivation, it seems to be convenient to keep small examples 
intended to check if some feature works or how to use particular 
language construct in a single file in preferred order instead of plenty 
of independent files in some directory.


- Tables. Consider specifying of explicit format, e,g, ";f5"

Another idea of a table that likely could be implemented in a better way

#+caption: Heron's method for $\sqrt{2}$
| iteration | approximation |error |
| ! |   cur |  err |
|---+---+--|
| 0 |   1.0 |  4.1e-01 |
| 1 | 1.500 | -8.6e-02 |
| 2 | 1.417 | -2.5e-03 |
| 3 | 1.41421568628 | -2.1e-06 |
| 4 | 1.41421356238 | -1.0e-11 |
#+TBLFM: 
@4$1..$1=@-1+1::@4$2..$2=(0.5*(@-1+$arg/@-1));f11::@3$3..$3=$result - 
$cur;%.1e

#+CONSTANTS: arg=2.0 result=sqrt(2)

- Folding. Maybe it is better to show cycle for the top-level heading

# screen edge
last line of the previous section
* Section
Maybe single line
** Short subsection
a couple of lines
with some text
** Longer subsection
it
has more
# screen edge when everything is open
text
* Maybe something else

1. Initial state: everything is open
2. Cycle of visibility for top level section till section is open, 
subsections are folded

3 open first subsection

- Publishing. Something wrong with HTML export of the LaTeX macro, 
backslashes are exported in description (just as on orgmode.org). Empty 
braces are necessary only if space should be kept after a TeX command, 
e.g. "\TeX{} logo", Unsure if math mode separator is required, but it 
should allow omit braces. I have tried "@@latex:\\@@LaTeX". It works, 
but newline is inserted before. I believe, it is OK to use just text 
LaTeX in e.g. HTML.


Installation page

I am uncertain if it is applicable for other editors, but I would like 
to see name of vim plugin since ambiguity (or matter of taste) exists.. 
FAQ suggests other vim plugins. I do not remember if I saw vim-outliner 
somewhere on orgmode.org. I have not tried any of these plugins.


Certainly all above is an opinion and it is up to you whether to accept 
or to reject such suggestions.






Re: Font width in Properties Drawer

2020-08-27 Thread Garrett Rolfs
Norman Tovey-Walsh  writes:

> Garrett Rolfs  writes:
>> Executing C-u C-x = on a space in this area indicates there is no face
>> defined. So I suspect the answer is currently no.
>
> I don’t know if this is useful feedback, but I’m running Org-mode
> version 9.3.7 and in my properties drawers, the keywords are in
> org-special-keyword face and the values are in org-property-value face.

Thank you. Both are fixed width. I'm wrestling with the space in
between. With differing length property names I was hoping to be able to
have my proprieties drawer look something like:

:PROPERTIES:
:header-args::var service_host="api.github.com"
:header-args+:   :var repo_source="repos/myid/myrepo"
:header-args:restclient: :var accept="Accept: application/json"
:END:

However the spaces between org-special-keyword and org-property-value
are a different width. I can get close but things look a little
squiggly. This is a very minor issue. Thanks for the feedback!




Re: [PATCH] Add org-md-src-block for src-block formater

2020-08-27 Thread Naoya Yamashita
> This is a feature. "ox-md" exports to vanilla Markdown, which doesn't
> support such syntax. You may want to use other back-ends, e.g.,
> "ox-gfm".

Thanks for letting me know that. I would try it.

2020年8月27日(木) 14:34 Nicolas Goaziou :

> Hello,
>
> Naoya Yamashita  writes:
>
> > I found `ox-md` exporter drop src-block language information.
> > My patch fixes the behavior.
>
> This is a feature. "ox-md" exports to vanilla Markdown, which doesn't
> support such syntax. You may want to use other back-ends, e.g.,
> "ox-gfm".
>
> Regards,
> --
> Nicolas Goaziou
>


Re: [PATCH] Re: org-forward-heading-same-level and the invisible-ok argument

2020-08-27 Thread Ihor Radchenko
> What I am wondering is whether it would make more sense as an argument
> for org-forward-heading-same-level and similar commands, or as a
> (potentially buffer-local) org variable to tweak the behavior, given
> it's most likely going to affect these functions as interactive commands
> (see alternative_org.el.diff).  This version has the advantage of
> allowing minor modes to easily mess with Org's behavior buffer-locally.

I do not think that setting visibility the leading stars is a correct
approach to control the movement commands. After second though about the
issue you raised in the first email, I think that it would make more
sense for org-forward-heading-same-level to check if any part of the
heading line is visible to decide if we need to skip it (instead of
current approach checking only the point at the beginning of the
headline). Any mode aiming to make org-forward-heading-same-level skip a
heading will then just need to make the whole heading invisible.
Skipping partially visible headlines would be a violation of the
docstring.

Best,
Ihor


D  writes:

>> I guess it is simply because nobody though that the leading stars can be
>> hidden via fontification.
>> 
>> I think the whole issue can be fixed by changing the call to
>> org-invisible-p inside org-forward-heading-same-level. org-invisible-p
>> has an optional third argument to ignore text hidden via fontification.
>> You can try to make a patch for org-forward-heading-same-level and
>> similar commands adding that third argument.
>
> I looked into the git repository and noticed that org-invisible-p
> already, thanks to a patch from Nicolas Goaziou (b1822760f4).
> What I am wondering is whether it would make more sense as an argument
> for org-forward-heading-same-level and similar commands, or as a
> (potentially buffer-local) org variable to tweak the behavior, given
> it's most likely going to affect these functions as interactive commands
> (see alternative_org.el.diff).  This version has the advantage of
> allowing minor modes to easily mess with Org's behavior buffer-locally.
>
> I considered how adding a third argument to
> org-forward-heading-same-level, but realized that adding another
> invisibility argument would kinda leak a little complexity, as we'd wind
> up with TWO invisibility-related arguments (which only differ in subtle
> ways) and their interactions.  So instead I'd recommend to instead allow
> a distinct, non-nil option for invisible-ok, for example `t', `nil' and
> `except-folding' (see org.el.diff).  This version would be more
> transparent, as it would not change the behavior of ALL calls in the
> buffer, but comes at the cost of minor modes needing to overshadow
> bindings to accomplish the same.
>
> I whipped up a quick diff for both versions, and will gladly make a
> patch once we settled on one, but I wanted to discuss which is
> preferable before making an uninformed decision on my own.
> diff --git a/lisp/org.el b/lisp/org.el
> index 71dbc611e..b8e6d47c2 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -20482,7 +20482,12 @@ entry."
>"Move forward to the ARG'th subheading at same level as this one.
>  Stop at the first and last subheadings of a superior heading.
>  Normally this only looks at visible headings, but when INVISIBLE-OK is
> -non-nil it will also look at invisible ones."
> +non-nil it will also look at invisible ones.
> +
> +If INVISIBLE-OK is set to the symbol `except-folding', continue
> +ignoring all parts that are invisible due to folding of a
> +headline, a block or a drawer, i.e., not because of
> +fontification."
>(interactive "p")
>(let ((backward? (and arg (< arg 0
>  (if (org-before-first-heading-p)
> @@ -20495,12 +20500,14 @@ non-nil it will also look at invisible ones."
>   (result (point)))
>   (while (and (> count 0)
>   (funcall f org-outline-regexp-bol nil 'move))
> -   (let ((l (- (match-end 0) (match-beginning 0) 1)))
> +   (let ((l (- (match-end 0) (match-beginning 0) 1))
> + (folding-only (eq 'except-folding invisible-ok)))
>   (cond ((< l level) (setq count 0))
> ((and (= l level)
> - (or invisible-ok
> + (or (and invisible-ok (not folding-only))
>   (not (org-invisible-p
> -   (line-beginning-position)
> +   (line-beginning-position)
> +   folding-only
>  (cl-decf count)
>  (when (= l level) (setq result (point)))
>   (goto-char result))
> diff --git a/lisp/org.el b/lisp/org.el
> index 71dbc611e..8e0040814 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -20478,6 +20478,18 @@ entry."
>   ((looking-at-p re) (forward-line))
>   (t (throw 'exit t
>  
> +
> +(defcustom org-navigate-invisible-headings nil
> +  "If non-nil, navigate through (unfolded) invisible 

Re: Bug: no math-mode detection for align-environment [9.3.7 (9.3.7-13-ge62ca4-elpaplus @ /home/stefi/.emacs.d/elpa/org-plus-contrib-20200713/)]

2020-08-27 Thread Stefi
It might be a change to texmathp.el. It is part of Auctex and checks if
math mode is on or off. I could not find align environment in the list
of default environments. Maybe that has changed.

However, I added align and align* to "Texmathp Tex Commands" from the
customize browser (open a .tex file to customize auctex). Tab-expansion
is working now. Can anyone confirm?

In my .emacs, it added to custom-set-variables:
'(texmathp-tex-commands (quote (("align*" env-on) ("align" env-on


On 8/26/20 5:44 AM, Kyle Meyer wrote:
> Stefi writes:
> 
>> Hi Kyle, hi mailing list,
>>
>> I also evaluated (org-inside-LaTeX-fragment-p) and got non-nil values
>> for all blocks, however, inside the align* environment, the "fr" does
>> not get expanded on TAB whereas it does in equation environment. So
>> either the matchers do not include align/align*, or there is something
>> different now with cdlatex.
> 
> I'm leaning towards there being something different with cdlatex.
> 
> I've now installed cdlatex from
> .  The
> file header says the version is 4.8, and the file's md5sum is
> 9246a4e9f30c9589406783ffd5270641.
> 
> I tried your example file with this minimal configuration:
> 
> (require 'org)
> (add-hook 'org-mode-hook (lambda () (org-cdlatex-mode 1)))
> (require 'edebug)
> (edebug-instrument-function 'org-try-cdlatex-tab)
> 
> As you and Rafael report, "fr => \frac{}{}" is not expanded in the align
> or align* environments, while it is expanded in the equation
> environment.  However, stepping through the org-try-cdlatex-tab call,
> cdlatex-tab is called in all cases.  So it would seem that something has
> changed downstream.
> 
> In line with this idea, I observed the same behavior with both the
> latest commit of the master branch (cdfc404be) and v9.2 (released in Dec
> 2018).  Also, as I mentioned in earlier in the thread, I don't see any
> recent changes on Org's side related to the cdlatex functionality.
> 



Re: org-link-set-parameters :complete how to prompt for description?

2020-08-27 Thread Ihor Radchenko
> Any tips would be greatly appreciated.

Take a look at org-link-make-description-function

Best,
Ihor


TRS-80  writes:

> Good day, everyone!
>
> I have been trying to create a new custom link type with
> org-link-set-parameters, which in turn calls functions for the various
> "methods" (for lack of a better term), like so:
>
>(org-link-set-parameters "zdlink"
>  :complete  #'my-zetteldeft-org-complete-link
>  :follow#'my-zetteldeft-org-follow-link
>  :help-echo #'my-zetteldeft-org-help-echo
>  :store #'my-zetteldeft-org-store-link)
>
> The only one I seem to be having trouble with is :complete.  I can get 
> it to
> prompt me for completing-read, and it returns the link portion only, but 
> how
> to get it to also prompt for a description?  Here is my :complete 
> function:
>
>(defun my-zetteldeft-org-complete-link ()
>   "Link completion for Org zdlink type links"
>   (let* ((file (completing-read "File to link to: "
> (deft-find-all-files-no-prefix)))
>  (link (zetteldeft--lift-id file)))
> (unless link (user-error "No file selected"))
> (concat "zdlink:" link)))
>
> I searched the Internet, this mailing list archives, etc. high and low, 
> all
> to no avail.  So I decide to join the mailing list today.  Probably long
> overdue anyway.  :)
>
> Any tips would be greatly appreciated.
>
> Cheers,
> TRS-80



Re: new feature for consideration: other-tab for org-agenda-window-setup

2020-08-27 Thread Kyle Meyer
Eric S Fraga writes:

> On Wednesday, 26 Aug 2020 at 18:28, Kyle Meyer wrote:
>> Thanks.  Sounds fine to me.
>
> Hi Kyle,
>
> thanks for the feedback.  Some questions/comments:
>
>> Style conventions: s/added/Add/s/handle/Handle/
>
> Okay although grammatically wrong but we won't go into that... ;-)

(Eh, sorry about the lack of a space between my s/// expressions.)

I assume you're talking about using the imperative mood with the "added
=> Add" change.  I don't see what's grammatically incorrect about that.

>> I think it's worth noting here which Emacs version gained tab support.
>
> Just as part of the comment?

As part of the docstring, yes.

Also, I should have mentioned that because the option value is changing,
the defcustom should get a `:package-version '(Org . "9.N")`, where N is
probably 4.  (And of course a NEWS entry would be good.)

>> As you suggest in your follow-up message, you need to guard these calls
>> for the sake of older versions.  Perhaps something like
>>
>> (if (fboundp 'FN)
>> (FN ...)
>>   (user-error "Your Emacs version doesn't support tabs"))
>
> Okay; is there any way to guard the customization of the variable so
> that the option does not get provided when it's an older version of
> Emacs?

You could conditionally set the defcustom value, but IMO it's not really
worth the trouble.  Either way I think the above call sites should be
guarded.

Thanks.



Re: new feature for consideration: other-tab for org-agenda-window-setup

2020-08-27 Thread Eric S Fraga
On Wednesday, 26 Aug 2020 at 18:28, Kyle Meyer wrote:
> Thanks.  Sounds fine to me.

Hi Kyle,

thanks for the feedback.  Some questions/comments:

> Style conventions: s/added/Add/s/handle/Handle/

Okay although grammatically wrong but we won't go into that... ;-)

> I think it's worth noting here which Emacs version gained tab support.

Just as part of the comment?

> As you suggest in your follow-up message, you need to guard these calls
> for the sake of older versions.  Perhaps something like
>
> (if (fboundp 'FN)
> (FN ...)
>   (user-error "Your Emacs version doesn't support tabs"))

Okay; is there any way to guard the customization of the variable so that the 
option does not get provided when it's an older version of Emacs?

I'll update the patch and post later.

Thanks again,
eric

-- 
: Eric S Fraga via Emacs 28.0.50, Org release_9.3.7-719-gcdfc40.dirty



Re: [PATCH] Fix bug in org-num check for commented headlines

2020-08-27 Thread Nicolas Goaziou
Hello,

Anders Johansson  writes:

> I found an easily solved bug in org-num.
>
> This happens when org-num-skip-commented is non-nil.
> When creating a new headline, often org-num--skip-value is invoked
> before any headline text is created. This means that ‘title‘ is nil
> and the string-match check breaks. Checking if title is non-nil fixes
> this.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou