Re: [PATCH] Re: Bug: org-agenda-sort-notime-is-late is not correctly handled by timestamp comparison [9.4.6 (9.4.6-12-gdcc3a8-elpaplus @ /Users/charlestam/.emacs.d/elpa/org-plus-contrib-20210830/)]

2022-01-29 Thread Ihor Radchenko
Timothy writes: > I’ve confirmed both your issue report (thanks for the detailed steps), and > your > suggested fix. As such, I’ve produced a patch (attached). It would be good if > someone else could check this looks fine and apply it. I have applied the patch onto bugfix as 1b675f0. The bug

Re: [PATCH] org-agenda.el: agenda*: add lost argument

2022-01-29 Thread Ihor Radchenko
Mikhail Skorzhinskii writes: > * lisp/org-agenda.el (org-agenda): add lost argument for agenda* Thanks! I am not able to apply your patch onto main. Could you resend, preferably adding the patch as an attachment and adding TINYCHANGE cookie (you do not seem to have the copyright assignment)?

Re: cut and paste not working after xdg-open "org-protocol://store-link?url=URL=TITLE"

2022-01-29 Thread Ihor Radchenko
chris writes: > 3- if you do `C-y` you can see the URL is in the kill-ring > But obviously there is no reason for this URL to be also in the Wayland (or > x11) clipboard? (there is no law of nature saying that what is in emacs kill- > ring must necessarily also be in wayland clipboard. I think

Re: cut and paste not working after xdg-open "org-protocol://store-link?url=URL=TITLE"

2022-01-29 Thread chris
On Friday, 28 January 2022 13:40:45 CET Max Nikulin wrote: > On 27/01/2022 07:03, chris wrote: > > First: `xdg-open "org-protocol://store-link?url=URL=TITLE"` from a > > terminal. > > Then `M-x org-insert-link` in emacs, or not (it makes no difference). > > Then cut-and-paste from

Re: New folding backend & outline (was: [PATCH 22/35] ORG-NEWS: Add list of changes)

2022-01-29 Thread Ihor Radchenko
Kévin Le Gouguec writes: > From the perspective of a heavy outline-minor-mode user, who dreams of > Org "backporting" its great outlining features to outline.el, that's a > bit disheartening, since IIUC this will cause Org and outline.el to > drift further apart? We already had some subtle (yet

New folding backend & outline (was: [PATCH 22/35] ORG-NEWS: Add list of changes)

2022-01-29 Thread Kévin Le Gouguec
Ihor Radchenko writes: > + =outline-*= functions may no longer work correctly in Org mode > + > +The new folding backend breaks some of the =outline-*= functions that > +rely on the details of visibility state implementation in > +=outline.el=. The old Org folding backend was compatible

LaTeX letters in Org

2022-01-29 Thread William Denton
I wrote up how to use Org to write letters with the LaTeX letter class. Here's the link in case anyone's interested: https://www.miskatonic.org/2022/01/28/latex-letters-in-org/ Cheers, Bill -- William Denton https://www.miskatonic.org/ Librarian, artist and licensed private investigator.

Re: [BUG] Cached element is incorrect in file.org [9.6 (9.6-??-0c9b30e @ /Users/jeffballowe/.emacs.d/.local/straight/build-27.2/org/)]

2022-01-29 Thread Jeff
Thank you for the very helpful high-level view of things, Ihor. This will help me a lot going forward. Best, Jeff > On Jan 28, 2022, at 18:41 PM, Ihor Radchenko wrote: > > Jeff writes: > >> Sorry for the delay responding. > > No problem. This list does not have reddit pacing :) > >> The

Re: [BUG] (Doom) Consistently seeing "org-element--cache" problems [9.6 (9.6-??-0c9b30e @ /home/dc/.emacs.doom/.local/straight/build-28.0.90/org/)]

2022-01-29 Thread Ihor Radchenko
David Conner writes: > Subject: [BUG] (Doom) Consistently seeing "org-element--cache" problems [9.6 > (9.6-??-0c9b30e @ Thanks for the report! > I was shuffling around the headlines in a newly created org file. The > error message showed up when I demoted the last headlines under the >

Re: Org-syntax: Intra-word markup

2022-01-29 Thread Juan Manuel Macías
Ihor Radchenko writes: > Maybe we should introduce an equivalent of special blocks, but for > inline use? Or should we modify _both_ inline export snippets and export > blocks to allow fallback mechanism? I find the idea of inline special blocks very interesting, but I think there are a couple

[BUG] (Doom) Consistently seeing "org-element--cache" problems [9.6 (9.6-??-0c9b30e @ /home/dc/.emacs.doom/.local/straight/build-28.0.90/org/)]

2022-01-29 Thread David Conner
From: David Conner To: emacs-orgmode@gnu.org Subject: [BUG] (Doom) Consistently seeing "org-element--cache" problems [9.6 (9.6-??-0c9b30e @ /home/dc/.emacs.doom/.local/straight/build-28.0.90/org/)] Date: Thu, 27 Jan 2022 22:59:37 -0500 Message-ID: <87y230se6u@gmail.com> --text follows this

[PATCH 35/35] test-ol/org-toggle-link-display: Fix compatibility with old Emacs

2022-01-29 Thread Ihor Radchenko
* testing/lisp/test-ol.el (test-ol/org-toggle-link-display): Use back-compatible `org-xor' instead of `xor'. --- testing/lisp/test-ol.el | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/testing/lisp/test-ol.el b/testing/lisp/test-ol.el index 343631623..429bb52ee

[PATCH 32/35] test-org/string-width: Add tests for strings with prefix properties

2022-01-29 Thread Ihor Radchenko
--- testing/lisp/test-org-macs.el | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/testing/lisp/test-org-macs.el b/testing/lisp/test-org-macs.el index 6a7ccea3c..05cef1281 100644 --- a/testing/lisp/test-org-macs.el +++ b/testing/lisp/test-org-macs.el @@ -65,7 +65,11 @@

[PATCH 31/35] org-fold-core: Fix fontification inside folded regions

2022-01-29 Thread Ihor Radchenko
* lisp/org-fold-core.el (org-fold-core-initialize): Declare `org-fold-core-fontified' text property for font-lock. (org-fold-core--force-fontification): New variable controlling forced fontification inside folded regions. (org-fold-core-fontify-region): Fix cases when BEG is inside folded region.

[PATCH 30/35] org-fold-show-set-visibility: Fix edge case when folded region is at BOB

2022-01-29 Thread Ihor Radchenko
--- lisp/org-fold.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-fold.el b/lisp/org-fold.el index a16ee0f9b..d5a21cbcb 100644 --- a/lisp/org-fold.el +++ b/lisp/org-fold.el @@ -840,7 +840,7 @@ (defun org-fold-show-set-visibility--text-properties (detail)

[PATCH 27/35] Fix org-fold--hide-drawers--overlays

2022-01-29 Thread Ihor Radchenko
--- lisp/org-fold.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-fold.el b/lisp/org-fold.el index e48a528bf..a16ee0f9b 100644 --- a/lisp/org-fold.el +++ b/lisp/org-fold.el @@ -714,7 +714,7 @@ (defun org-fold--hide-drawers--overlays (begin end) "Hide all drawers

[PATCH 24/35] Fix typo: delete-duplicates → delete-dups

2022-01-29 Thread Ihor Radchenko
--- lisp/org-fold-core.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el index 6ea374498..121c6b5c4 100644 --- a/lisp/org-fold-core.el +++ b/lisp/org-fold-core.el @@ -592,7 +592,7 @@ (defun

[PATCH 23/35] Backport contributed commits

2022-01-29 Thread Ihor Radchenko
--- lisp/org-cycle.el | 2 +- lisp/org-fold-core.el | 2 +- lisp/org-keys.el | 4 ++-- lisp/org.el | 6 ++ 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/lisp/org-cycle.el b/lisp/org-cycle.el index df0a3761a..d2fcc356c 100644 --- a/lisp/org-cycle.el +++

[PATCH 34/35] org-link-make-string: Throw error when both LINK and DESCRIPTION are empty

2022-01-29 Thread Ihor Radchenko
This behaviour is expected according to `test-ol/make-string'. --- lisp/ol.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/ol.el b/lisp/ol.el index 1837bf37c..2e954a57f 100644 --- a/lisp/ol.el +++ b/lisp/ol.el @@ -999,7 +999,9 @@ (defun org-link-make-string (link

[PATCH 29/35] org-string-width: Work around `window-pixel-width' bug in old Emacs

2022-01-29 Thread Ihor Radchenko
--- lisp/org-macs.el | 188 --- 1 file changed, 129 insertions(+), 59 deletions(-) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index 0a7da0637..db98dd149 100644 --- a/lisp/org-macs.el +++ b/lisp/org-macs.el @@ -887,73 +887,143 @@ (defun

[PATCH 21/35] org-manual: Update to new org-fold function names

2022-01-29 Thread Ihor Radchenko
--- doc/org-manual.org | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index 2c54fde87..ba63d3a4e 100644 --- a/doc/org-manual.org +++ b/doc/org-manual.org @@ -495,11 +495,11 @@ *** Global and local cycling Switch back

[PATCH 33/35] org--string-from-props: Fix handling folds in Emacs <28

2022-01-29 Thread Ihor Radchenko
* lisp/org-macs.el (org--string-from-props): Respect `char-property-alias-alist' when querying for `invisible' text property. --- lisp/org-macs.el | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index 867139742..6a2d7fe85 100644

[PATCH 20/35] Add org-fold-related tests

2022-01-29 Thread Ihor Radchenko
--- testing/lisp/test-ol.el | 24 + testing/lisp/test-org-list.el | 73 ++ testing/lisp/test-org.el | 177 +++--- 3 files changed, 238 insertions(+), 36 deletions(-) diff --git a/testing/lisp/test-ol.el b/testing/lisp/test-ol.el index

[PATCH 25/35] Fix bug in org-get-heading

2022-01-29 Thread Ihor Radchenko
Fixes #26, where fontification could make the matching and extraction of heading components fail. --- lisp/org.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 1c01ecf88..dd6298104 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -6166,8

[PATCH 26/35] Rename remaining org-force-cycle-archived → org-cycle-force-archived

2022-01-29 Thread Ihor Radchenko
--- lisp/org-cycle.el | 2 +- lisp/org-keys.el | 4 ++-- lisp/org.el | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/org-cycle.el b/lisp/org-cycle.el index d2fcc356c..df0a3761a 100644 --- a/lisp/org-cycle.el +++ b/lisp/org-cycle.el @@ -811,7 +811,7 @@ (defun

[PATCH 28/35] org-string-width: Handle undefined behaviour in older Emacs

2022-01-29 Thread Ihor Radchenko
* lisp/org-macs.el (org-string-width): Force older Emacs treating invisible text with ellipsis as zero-width. Newer Emacs versions do exactly this. --- lisp/org-macs.el | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index

[PATCH 16/35] Obsolete old function names that are now in org-fold

2022-01-29 Thread Ihor Radchenko
--- lisp/org-compat.el | 88 ++ 1 file changed, 88 insertions(+) diff --git a/lisp/org-compat.el b/lisp/org-compat.el index 772ef37f9..14afb4600 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -238,6 +238,11 @@

[PATCH 19/35] Restore old visibility behaviour of org-refile

2022-01-29 Thread Ihor Radchenko
--- lisp/org-refile.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org-refile.el b/lisp/org-refile.el index d68760623..df7f645ef 100644 --- a/lisp/org-refile.el +++ b/lisp/org-refile.el @@ -547,6 +547,7 @@ (defun org-refile ( arg default-buffer rfloc msg) (goto-char

[PATCH 18/35] Move `org-buffer-list' to org-macs.el

2022-01-29 Thread Ihor Radchenko
--- lisp/org-macs.el | 38 ++ lisp/org.el | 38 -- 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index 5494acb3e..0ccf080a3 100644 --- a/lisp/org-macs.el +++

[PATCH 22/35] ORG-NEWS: Add list of changes

2022-01-29 Thread Ihor Radchenko
--- etc/ORG-NEWS | 104 +++ 1 file changed, 104 insertions(+) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 5a94e737e..a60248589 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -40,6 +40,105 @@ The cache state is saved between Emacs sessions.

[PATCH 11/35] Implement overlay- and text-property-based versions of some functions

2022-01-29 Thread Ihor Radchenko
--- lisp/org-element.el| 54 - lisp/org-fold.el | 5 +- lisp/org-inlinetask.el | 26 ++- lisp/org-list.el | 74 ++- lisp/org-macs.el | 54 - lisp/org.el| 469 + 6 files changed, 585 insertions(+), 97

[PATCH 13/35] Fix subtle differences between overlays and invisible text properties

2022-01-29 Thread Ihor Radchenko
* lisp/org-clock.el (org-clock-in): (org-clock-find-position): (org-clock-out): * lisp/org.el (org-add-planning-info): (org-scan-tags): (org-global-tags-completion-table): (org-make-tags-matcher): (org-tags-expand): (org--property-local-values): (org-read-date-analyze):

[PATCH 17/35] org-compat: Work around some third-party packages using outline-* functions

2022-01-29 Thread Ihor Radchenko
--- lisp/org-compat.el | 72 +- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a/lisp/org-compat.el b/lisp/org-compat.el index 14afb4600..05efeca11 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -1311,11 +1311,81 @@ (defvar

[PATCH 10/35] Implement link folding

2022-01-29 Thread Ihor Radchenko
* lisp/ol.el (org-link--link-folding-spec): (org-link--description-folding-spec): New variables controlling link folding settings. (org-link--reveal-maybe): Handle revealing folded links. (org-link-descriptive-ensure): Implement `org-link-descriptive' support with org-fold.

[PATCH 07/35] org-at-heading-p: Accept optional argument

2022-01-29 Thread Ihor Radchenko
* lisp/org.el (org-at-heading-p): Use second argument to allow checking for visible headings. Note that by default, unlike `outline-on-heading-p', `org-at-heading-p' returns non-nil for invisible headings. Passing second argument is just like `(outline-on-heading-p)'. (org-indent-line): *

[PATCH 12/35] org-fold: Handle indirect buffer visibility

2022-01-29 Thread Ihor Radchenko
--- lisp/org-capture.el | 5 - lisp/org.el | 8 +++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lisp/org-capture.el b/lisp/org-capture.el index 1d4d6e877..08b35dd99 100644 --- a/lisp/org-capture.el +++ b/lisp/org-capture.el @@ -1171,7 +1171,10 @@ (defun

[PATCH 09/35] Rename old function call to use org-fold

2022-01-29 Thread Ihor Radchenko
--- lisp/ob-core.el | 14 ++-- lisp/ob-lilypond.el | 4 +- lisp/ob-ref.el| 4 +- lisp/ol.el| 13 ++-- lisp/org-agenda.el| 43 +-- lisp/org-archive.el | 12 +-- lisp/org-capture.el | 2 +-

[PATCH 15/35] Alias new org-fold functions to their old shorter names

2022-01-29 Thread Ihor Radchenko
--- lisp/org.el | 8 1 file changed, 8 insertions(+) diff --git a/lisp/org.el b/lisp/org.el index 22fce184e..cbdbf32f1 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -99,6 +99,14 @@ (require 'org-table) (require 'org-fold) (require 'org-cycle) +(defvaralias 'org-hide-block-startup

[PATCH 06/35] org-macs: New function org-find-text-property-region

2022-01-29 Thread Ihor Radchenko
--- lisp/org-macs.el | 32 +--- lisp/org.el | 7 ++- 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index 3c902b603..d5d4c205d 100644 --- a/lisp/org-macs.el +++ b/lisp/org-macs.el @@ -722,7 +722,7 @@

[PATCH 08/35] org-string-width: Reimplement to work with new folding

2022-01-29 Thread Ihor Radchenko
* lisp/org-macs.el (org--string-from-props): Removed since it is no longer needed. (org-string-width): Updated to use `window-text-pixel-size'. --- lisp/org-macs.el | 121 ++- 1 file changed, 57 insertions(+), 64 deletions(-) diff --git

[PATCH 03/35] Separate cycling functions from org.el into new library: org-cycle

2022-01-29 Thread Ihor Radchenko
--- lisp/org-cycle.el | 818 ++ 1 file changed, 818 insertions(+) create mode 100644 lisp/org-cycle.el diff --git a/lisp/org-cycle.el b/lisp/org-cycle.el new file mode 100644 index 0..df0a3761a --- /dev/null +++ b/lisp/org-cycle.el @@ -0,0

[PATCH 14/35] Support extra org-fold optimisations for huge buffers

2022-01-29 Thread Ihor Radchenko
--- lisp/org.el | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index a59d550ca..22fce184e 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -5787,6 +5787,7 @@ (defun org-unfontify-region (beg end _maybe_loudly)

[PATCH 05/35] Disable native-comp in agenda

2022-01-29 Thread Ihor Radchenko
It caused cryptic bugs in the past. --- lisp/org-agenda.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 3a6a4c1b9..72292fb4e 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -1,4 +1,4 @@ -;;; org-agenda.el ---

[PATCH 04/35] Remove functions from org.el that are now moved elsewhere

2022-01-29 Thread Ihor Radchenko
--- lisp/org.el | 1272 ++- 1 file changed, 40 insertions(+), 1232 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index b3c5f3104..d279edae4 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -1178,90 +1178,6 @@ (defgroup org-structure nil :tag

[PATCH 02/35] Separate folding functions from org.el into new library: org-fold

2022-01-29 Thread Ihor Radchenko
--- lisp/org-fold.el | 1135 ++ 1 file changed, 1135 insertions(+) create mode 100644 lisp/org-fold.el diff --git a/lisp/org-fold.el b/lisp/org-fold.el new file mode 100644 index 0..52717fd86 --- /dev/null +++ b/lisp/org-fold.el @@ -0,0

[PATCH 01/35] Add org-fold-core: new folding engine

2022-01-29 Thread Ihor Radchenko
--- lisp/org-fold-core.el | 1490 + 1 file changed, 1490 insertions(+) create mode 100644 lisp/org-fold-core.el diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el new file mode 100644 index 0..121c6b5c4 --- /dev/null +++

[PATCH 00/35] Merge org-fold feature branch

2022-01-29 Thread Ihor Radchenko
It took a while, but I am finally done with rebasing the org-fold branch code onto current main. This branch has been tested by me and other volunteers for over a year. Things are basically stable using recent Emacs versions. There were a couple of back-compatibility issues with older Emacs,

Re: org-element persist logic hangs when quitting emacs

2022-01-29 Thread Ihor Radchenko
Kaushal Modi writes: > Lately (at least as of last 3 days), I have seen that when I try to > quit emacs, it gets stuck on one of my Org files; it's a personal > journal.org that I frequently update using org-capture. So that file > is usually open in one of the buffers. Thanks for the report!