Re: [BUG] org-screenshot cl-lib function name errors [9.5.2 (9.5.2-gbebf0b @ /home/jds6696/.emacs.d/straight/build/org/)]

2022-04-23 Thread Ihor Radchenko
Justin Silverman writes: > I started getting errors in the org-screenshot library. > > Errors such as void function incf or plusp. I was able to fix them by adding > (require 'cl-lib) and changing incf -> cl-incf and plusp -> cl-plusp Should be fixed in https://git.sr.ht/~bzg/org-contrib/commit

Re: [PATCH] org-element-export-snippet-parser: Fix snippets without ending @@

2022-04-23 Thread Ihor Radchenko
Ihor Radchenko writes: > The fix is attached. > > Nicolas, unless you have any objections, I will install the attached > patch to bugfix. Applied. I installed the patch onto main as 96529e933 (Bastien asked to refrain from modifying bugfix until Org 9.5.4, unless there is a critical bug). Bes

Re: [PATCH] lisp/org-capture.el: Add hook & hook options to org-capture

2022-04-23 Thread Ihor Radchenko
Valentin Herrmann writes: > * lisp/org-capture.el: > (org-capture-templates): Document the new template options. > (org-capture-before-view-hook): Add new hook for parity with the > template options. > (org-capture): Implement the new template options. > (org-capture-finalize): Implement the new

Re: #3 Org mode profiling meetup on Sat, Apr 23 (was: #2 Org mode profiling meetup on Sat, Mar 26)

2022-04-23 Thread Ihor Radchenko
Ihor Radchenko writes: > Ihor Radchenko writes: > >> I will post the link to the meeting one hour before the meeting start. > > https://teamjoin.de/Org-dev-profiling-202204-23-d708k Summary of the discussion is in the attached .org. Best, Ihor summary.org Description: Lotus Organizer

Re: Difference seen in org-version strings when built from git

2022-04-23 Thread Ihor Radchenko
Kaushal Modi writes: > I saw the version as "release_9.5-364-gde022e". That meant that > "release_9.5" happened to be the last fetched tag in my local repo > back then. > > Fix was simple.. I had to do "git fetch --all" before building Org. This is indeed something easy to overlook. Maybe we can

Difference seen in org-version strings when built from git

2022-04-23 Thread Kaushal Modi
On Fri, Dec 17, 2021 at 11:34 PM Ihor Radchenko wrote: > > Kaushal Modi writes: > > > I actually run a wrapper script to update Org and that has all that: > > ... > > I verified that at least the git hash was latest as of then: > > release_9.5-364-g*de022e* > > Odd. Though the commit number is in

Re: [DRAFT][PATCH] org-encode-time compatibility and convenience helper

2022-04-23 Thread Ihor Radchenko
Paul Eggert writes: > On 4/23/22 01:25, Ihor Radchenko wrote: >>> + (should (string-equal >>> + "2022-03-24 23:30:01" >>> + (format-time-string >>> +"%F %T" >>> +(org-encode-time '(01 30 23 24 03 2022 nil -1 nil) >>> ... >> These tests will be exec

[PATCH] Fix inf-loop due to org-eldoc when point is in an org src block

2022-04-23 Thread Kaushal Modi
Hello all, The patches attached in this email fix the issue reported in https://lists.gnu.org/r/emacs-orgmode/2022-04/msg00373.html. They are based off the master branch of https://git.sr.ht/~bzg/org-contrib. patch 1: Minor cleanup in the function that I am touching for the fix in patch 2: re-ind

[BUG] org-eldoc inf-loops when point is in an org src block

2022-04-23 Thread Kaushal Modi
Hello all, For quite some time, this small issue had been bugging me. I enable org-eldoc by default and each time I put the point in an org src block, I would see this error: eldoc error: (error Lisp nesting exceeds ‘max-lisp-eval-depth’) Here's a snippet of the full backtrace where we see the `

Re: [DRAFT][PATCH] org-encode-time compatibility and convenience helper

2022-04-23 Thread Paul Eggert
On 4/23/22 01:25, Ihor Radchenko wrote: + (should (string-equal + "2022-03-24 23:30:01" + (format-time-string +"%F %T" +(org-encode-time '(01 30 23 24 03 2022 nil -1 nil) ... These tests will be executed using system value of TZ. I am not sure if

Re: [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format

2022-04-23 Thread Karl Fogel
On 23 Apr 2022, Ihor Radchenko wrote: Applied. The patch is now on main as 67efaa739. Thanks, Ihor! Best regards, -Karl

Re: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones

2022-04-23 Thread Bernhard Voelker
On 4/20/22 20:19, Paul Eggert wrote: > diff --git a/lib/gettime-res.c b/lib/gettime-res.c > index 611f83ad27..bb4d0b191d 100644 > --- a/lib/gettime-res.c > +++ b/lib/gettime-res.c > @@ -53,6 +53,8 @@ gettime_res (void) > >long int hz = TIMESPEC_HZ; >long int r = hz * res.tv_sec + res.tv_nse

Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-04-23 Thread Tim Van den Langenbergh
Felipe, I have taken the liberty of reformatting the patch you created for ob-scheme. You can find it enclosed. If it is fine with you and the org-mode maintainers it can be applied as-is, particularly since it is a tiny change. I have also added some additional information to the commit message,

Re: #3 Org mode profiling meetup on Sat, Apr 23 (was: #2 Org mode profiling meetup on Sat, Mar 26)

2022-04-23 Thread Ihor Radchenko
Ihor Radchenko writes: > I will post the link to the meeting one hour before the meeting start. https://teamjoin.de/Org-dev-profiling-202204-23-d708k See you, Ihor

[BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)]

2022-04-23 Thread Ignacio Casso
Hello, Link abbreviations do not work inside property drawers and are instead confused with internal links. The following org file illustrates this behavior. #+LINK: org-manual https://orgmode.org/manual/ * Heading :PROPERTIES: :myprop: [[org-manual:Hyperlinks.html]] :END: - Opening thi

Re: [DRAFT][PATCH] org-encode-time compatibility and convenience helper

2022-04-23 Thread Ihor Radchenko
Max Nikulin writes: > I tried to create a compatibility helper that will use currently > recommended way to call `encode-time' with single list argument for > Emacs-27 and newer, but use the only available call style as separated > arguments for older Emacs versions. Thanks for this work! >

Re: [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-04-23 Thread Max Nikulin
On 23/04/2022 14:20, Ignacio Casso wrote: Max Nikulin writes: Ignacio, have you tried recent emacs master branch? Paul reverted most of his changed, see ... Yes, I have just tried, and everything works fine now. Thanks! Greet. I would prefer to keep this issue tracked on https://updates.o

Re: [PATCH] CONTRIBUTE: Link WORG page when explaining commit message format

2022-04-23 Thread Ihor Radchenko
Applied. The patch is now on main as 67efaa739. Best, Ihor

Re: [BUG] org-agenda thinks timestamps after 23:00 correspond to the next day [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-04-23 Thread Ignacio Casso
Max Nikulin writes: > On 05/04/2022 11:20, Kyle Meyer wrote: >> Max Nikulin writes: >> >>> Emacs copy of Org changed the way of calling `encode-time' as a result >>> interpretation of last nils returned by `org-parse-string' altered from >>> ignored to "no DST". >>> >> My suggestion: >>1.