Re: [the culprit] (was: org-set-property (at point)? Save-excursion seems not to work)

2022-04-25 Thread Ihor Radchenko
Uwe Brauer  writes:

>> But it does not help, org-set-property sets always a new property at the
>> end of the property list.
>
>> Any idea what to do (besides touching the function itself)
>
>
> It seems that the culprit is the function 
> org-entry-put
> which always puts a new entry at the end of the property section.

You are right, org-set-property adds the property to the end of property
drawer. I do not think that its docstring suggests anything different.

Do you want to propose a new feature request? I guess patches are welcome.

Best,
Ihor



Re: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones

2022-04-25 Thread Paul Eggert

On 4/25/22 08:37, Paul Eggert wrote:
Yes, I plan to omit the patches that were objected to, and install the 
rest. Once that's done you should be good to go for Org. (Alas my 
workstation died over the weekend, but I should have things up and 
running again soon...)


Got my workstation up, installed the patches into Emacs master, and am 
closing the Emacs bug report.


I'll be happy to review the revised org-encode-time implementation, 
whenever you think it could use a review. (Sorry, I've lost track of 
what the proposal is.)




Re: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones

2022-04-25 Thread Paul Eggert
Yes, I plan to omit the patches that were objected to, and install the 
rest. Once that's done you should be good to go for Org. (Alas my 
workstation died over the weekend, but I should have things up and 
running again soon...)




Re: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones

2022-04-25 Thread Max Nikulin

On 21/04/2022 01:29, Paul Eggert wrote:

On 4/20/22 08:07, Max Nikulin wrote:

I still believe that optional DST and ZONE values is an improvement of 
the `encode-time' interface with no real drawbacks.


Yes, that's the direction we're headed.


Paul, a week has passed since you posted the patch series. Unlike the 
changes related to timestamp representation, nobody argued concerning 6 
element list argument of `encode-time':


[PATCH 1/6] Support (encode-time (list s m h D M Y))

Unless I have missed something, this patch can be pushed without other 
ones and it will be a step forward.




[BUG] org-element--cache: Unregistered buffer modifications detected [9.6 (9.6-??-971eb68 @ /home/zeyrie/.emacs.d/.local/straight/build-28.1/org/)]

2022-04-25 Thread Abilash S
Your bug report will be posted to the Org mailing list.


I m working with an org file where I create a java source block and
every time I use a snippet I am receiving the following warning and along
with it the pointer where the cursor should start auto-fills a tab.
But the default behaviour is for the cursor to be present in he
specified location without any tab or whitespaces.

Warning (org-element-cache): org-element--cache: Unregistered buffer
modifications detected. Resetting.
If this warning appears regularly, please report the warning text to Org
mode mailing list (M-x org-submit-bug-report).
The buffer is: Intro.org
 Current command: (org-cycle 14202 14304)
 Chars modified: 14202
 Buffer modified: 14304
 Backtrace:


Emacs  : GNU Emacs 28.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.17.6)
 of 2022-04-10
Package: Org mode version 9.6 (9.6-??-971eb68 @
/home/zeyrie/.emacs.d/.local/straight/build-28.1/org/)

current state:
==
(setq
 org-agenda-prefix-format '((dashboard-agenda . " %i %-12:c %s ")
(agenda . " %i %-12:c%?-12t% s") (todo . " %i
%-12:c")
(tags . " %i %-12:c") (search . " %i %-12:c"))
 org-link-elisp-confirm-function nil
 org-directory "~/Dropbox/Org-Files/"
 org-after-refile-insert-hook '(save-buffer)
 org-indirect-buffer-display 'current-window
 org-crypt-key nil
 org-hide-emphasis-markers t
 org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-log-done 'time
 org-load-hook '(+org-init-org-directory-h +org-init-appearance-h
+org-init-agenda-h
 +org-init-attachments-h +org-init-babel-h
+org-init-babel-lazy-loader-h
 +org-init-capture-defaults-h +org-init-capture-frame-h
 +org-init-custom-links-h +org-init-export-h
+org-init-habit-h
 +org-init-hacks-h +org-init-keybinds-h
+org-init-popup-rules-h
 +org-init-protocol-h +org-init-protocol-lazy-loader-h
 +org-init-smartparens-h)
 org-startup-folded nil
 org-babel-after-execute-hook
'(+org-redisplay-inline-images-in-babel-result-h)
 org-link-abbrev-alist '(("doom-repo" . "
https://github.com/hlissner/doom-emacs/%s;)
 ("wolfram" . "https://wolframalpha.com/input/?i=%s
")
 ("wikipedia" . "https://en.wikipedia.org/wiki/%s;)
 ("duckduckgo" . "https://duckduckgo.com/?q=%s;)
 ("gmap" . "https://maps.google.com/maps?q=%s;)
 ("gimages" . "https://google.com/images?q=%s;)
 ("google" . "https://google.com/search?q=;)
 ("youtube" . "https://youtube.com/watch?v=%s;)
 ("github" . "https://github.com/%s;))
 org-agenda-files '("~/Dropbox/Org-Files/Org-Agenda.org")
 org-capture-templates '(("t" "Personal todo" entry
  (file+headline +org-capture-todo-file "Inbox") "*
[ ] %?\n%i\n%a"
  :prepend t)
 ("n" "Personal notes" entry
  (file+headline +org-capture-notes-file "Inbox")
"* %u %?\n%i\n%a"
  :prepend t)
 ("j" "Journal" entry (file+olp+datetree
+org-capture-journal-file)
  "* %U %?\n%i\n%a" :prepend t)
 ("p" "Templates for projects")
 ("pt" "Project-local todo" entry
  (file+headline +org-capture-project-todo-file
"Inbox")
  "* TODO %?\n%i\n%a" :prepend t)
 ("pn" "Project-local notes" entry
  (file+headline +org-capture-project-notes-file
"Inbox")
  "* %U %?\n%i\n%a" :prepend t)
 ("pc" "Project-local changelog" entry
  (file+headline
+org-capture-project-changelog-file "Unreleased")
  "* %U %?\n%i\n%a" :prepend t)
 ("o" "Centralized templates for projects")
 ("ot" "Project todo" entry
  #'+org-capture-central-project-todo-file "* TODO
%?\n %i\n %a"
  :heading "Tasks" :prepend nil)
 ("on" "Project notes" entry
  #'+org-capture-central-project-notes-file "* %U
%?\n %i\n %a"
  :heading "Notes" :prepend t)
 ("oc" "Project changelog" entry
  #'+org-capture-central-project-changelog-file "*
%U %?\n %i\n %a"
  :heading "Changelog" :prepend t)
 )
 org-persist-after-read-hook '(org-element--cache-persist-after-read)
 org-refile-targets '((nil :maxlevel . 3) (org-agenda-files :maxlevel . 3))
 org-export-before-parsing-hook 

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-25 Thread Bastien
Ihor Radchenko  writes:

> If you confirm, I can just remove the call to `org-fold-reveal'.

Yes, I do confirm -- thanks for the quick feedback.

-- 
 Bastien



Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-25 Thread Ihor Radchenko
Bastien  writes:

> Ihor Radchenko  writes:
>
>> I think I addressed the raised issues.
>> Just merged org-fold upstream.
>
> Great!  Thanks again for the hard work and the merge.
>
> One glitch: when refiling an entry to a folded section, the section
> gets unfolded.
>
> Can you reproduce this?  Let me know if you need a detailed recipe.

Apparently I did it on purpose at some point when I was tuning the
differences between Emacs handling of overlays and text properties.

If I am correct about the cause, commenting out the org-fold-reveal' in
org-refile should solve the problem.

   ;; (org-fold-reveal)
   (org-paste-subtree level nil nil t)

If you confirm, I can just remove the call to `org-fold-reveal'.

Best,
Ihor



Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-25 Thread Bastien
Hi Ihor,

Ihor Radchenko  writes:

> I think I addressed the raised issues.
> Just merged org-fold upstream.

Great!  Thanks again for the hard work and the merge.

One glitch: when refiling an entry to a folded section, the section
gets unfolded.

Can you reproduce this?  Let me know if you need a detailed recipe.

-- 
 Bastien



[Bug] Date span failure in agenda w/o day of week in timestamp?

2022-04-25 Thread Russell Adams
Consider this sample file:

--
* Test with day of week

<2022-04-25 Mon 15:00>--<2022-04-26 Tue 02:00>

* Fails w/o DOW, end time at 2100 not 0200

<2022-04-28 21:00>--<2022-04-29 02:00>

--

Results in this agenda:

--
Week-agenda (W17):
Monday 25 April 2022 W17
   8:00.. 
  10:00.. 
  12:00.. 
  14:00.. 
  14:31.. now - - - - - - - - - - - - - - - - - - - - - - - - -
  testdate:   15:00.. (1/2):  Test with day of week
  16:00.. 
  18:00.. 
  20:00.. 
Tuesday26 April 2022
  testdate:2:00.. (2/2):  Test with day of week
Wednesday  27 April 2022
Thursday   28 April 2022
  testdate:   21:00.. (1/2):  Fails w/o DOW, end time at 2100 not 0200
Friday 29 April 2022
  testdate:   21:00.. (2/2):  Fails w/o DOW, end time at 2100 not 0200
Saturday   30 April 2022
Sunday  1 May 2022
--

So if the DOW is omitted from the end date, then it defaults to 24
hours?

I discovered this using gnus-icalendar to import ical invites. Gnus
appears to omit the DOW when creating the timestamp.

I thought DOW was optional in timestamps?

Org mode version 9.5.2 (release_9.5.2-25-gaf6f12 @ 
/usr/local/share/emacs/28.1/lisp/org/)
GNU Emacs 28.1 (build 2, amd64-portbld-freebsd13.0, X toolkit, cairo version 
1.17.4, Xaw3d scroll bars)

--
Russell Adamsrlad...@adamsinfoserv.com
https://www.adamsinfoserv.com/



[the culprit] (was: org-set-property (at point)? Save-excursion seems not to work)

2022-04-25 Thread Uwe Brauer
>>> "UB" == Uwe Brauer  writes:

> Hi 
> I tried 

> (defun my-org-set-property ()
>   (interactive)
>   (save-excursion 
> (org-set-property nil nil)))

> Or 

> (defun my-org-set-property ()
>   (interactive)
>   (save-excursion 
> (call-interactively #'org-set-property)))


> But it does not help, org-set-property sets always a new property at the
> end of the property list.

> Any idea what to do (besides touching the function itself)


It seems that the culprit is the function 
org-entry-put
which always puts a new entry at the end of the property section.

Uwe Brauer 


smime.p7s
Description: S/MIME cryptographic signature


Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-25 Thread Ihor Radchenko


I think I addressed the raised issues.
Just merged org-fold upstream.

Kévin Le Gouguec  writes:

> My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd):
>
> $ git switch feature/org-fold-universal-core-tidy
> $ make autoloads
> $ emacs -Q -L lisp -eval "(setq org-startup-folded t)" repro.org
>
> Restarting Emacs with the above between each step:
>
> (1) C-s abc ⇒ no logbook is unfolded,
> (2) C-s def ⇒ no logbook is unfolded,
> (3) C-s ghi ⇒ some logbooks are unfolded.
>
> Assuming you can reproduce: is it expected that logbooks are expanded in
> case (3)?  I don't see what's "conceptually" different in situation (3)
> vs. (1) and (2), so I'm puzzled to get different results.

I had a hard time to reproduce your recipe because it was related to
font-locking. The only way was increasing the font size, so that line
widths were larger than the frame width.

I believe I fixed the issue now.

> Also, a bit of idle curiosity:
>
>> (defun org-fold--isearch-reveal ( _)
>>   "Reveal text at POS found by isearch."
>>   (org-fold-show-set-visibility 'isearch))
>
> org-fold-show-set-visibility calls either
> org-fold-show-set-visibility--overlays, or
> org-fold-show-set-visibility--text-properties, and AFAICT neither of
> these handle 'isearch as an argument…  Is there a (cdr (assq 'isearch
> org-fold-show-context-detail)) missing?
>
> (This comes from a very cursory reading of the code; apologies if I've
> missed something)

You are right. I supposed to use org-fold-show-context. Fixed now.

Best,
Ihor




Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

2022-04-25 Thread Ihor Radchenko


I think I addressed the raised issues.
Just merged org-fold upstream.

Kévin Le Gouguec  writes:

> My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd):
>
> $ git switch feature/org-fold-universal-core-tidy
> $ make autoloads
> $ emacs -Q -L lisp -eval "(setq org-startup-folded t)" repro.org
>
> Restarting Emacs with the above between each step:
>
> (1) C-s abc ⇒ no logbook is unfolded,
> (2) C-s def ⇒ no logbook is unfolded,
> (3) C-s ghi ⇒ some logbooks are unfolded.
>
> Assuming you can reproduce: is it expected that logbooks are expanded in
> case (3)?  I don't see what's "conceptually" different in situation (3)
> vs. (1) and (2), so I'm puzzled to get different results.

I had a hard time to reproduce your recipe because it was related to
font-locking. The only way was increasing the font size, so that line
widths were larger than the frame width.

I believe I fixed the issue now.

> Also, a bit of idle curiosity:
>
>> (defun org-fold--isearch-reveal ( _)
>>   "Reveal text at POS found by isearch."
>>   (org-fold-show-set-visibility 'isearch))
>
> org-fold-show-set-visibility calls either
> org-fold-show-set-visibility--overlays, or
> org-fold-show-set-visibility--text-properties, and AFAICT neither of
> these handle 'isearch as an argument…  Is there a (cdr (assq 'isearch
> org-fold-show-context-detail)) missing?
>
> (This comes from a very cursory reading of the code; apologies if I've
> missed something)

You are right. I supposed to use org-fold-show-context. Fixed now.

Best,
Ihor




org-set-property (at point)? Save-excursion seems not to work

2022-04-25 Thread Uwe Brauer
Hi 

I tried 

(defun my-org-set-property ()
  (interactive)
  (save-excursion 
(org-set-property nil nil)))

Or 

(defun my-org-set-property ()
  (interactive)
  (save-excursion 
(call-interactively #'org-set-property)))


But it does not help, org-set-property sets always a new property at the
end of the property list.

Any idea what to do (besides touching the function itself)

Regards

Uwe Brauer 

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine.