Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Ihor Radchenko
"Christopher M. Miles" writes: > 668 28%- > org-agenda-prepare-buffers > ... > 523 22% - > org--tag-add-to-alist I have a suspicion where the bottleneck is. Can you try the attached patch? >Fr

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-12 Thread Ihor Radchenko
Max Nikulin writes: >> + (bare (and (string-match org-link-bracket-re l) >> +(match-string 1 l >> +(when bare >> + (if (and org-babel-tangle-use-relative-file-links >> + (string-match org-link-types-re bare) >> +

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-12 Thread Ihor Radchenko
Hraban Luyat writes: >>> @Ihor: I have rebased the patch and attached it. Applied onto main via 8a781d35d. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8a781d35dc68f20fa2a5546c98ba3d9b77ee3cda Thanks again for your contribution! -- Ihor Radchenko, Org mode contributor, Lea

Re: Suspected bug: '#+STARTUP: indent' messes up inlinetasks' tag alignment

2022-08-12 Thread Ihor Radchenko
alain.coch...@unistra.fr writes: > Then, to observe the problem, I can for example compare > > (1) visiting the file pb.org containing: > >#+STARTUP: noindent >* headline 1 :htag: >*** inelinetask :itag: >*** END >

Re: [PATCH v3] Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-12 Thread Ihor Radchenko
Max Nikulin writes: > was a really bad one. It leads to a separate directory for each short > ID. However I still believe that the purpose of > `org-attach-id-ts-folder-format' is avoid concentration of huge number > of file in a single directory. Distribution of attachments over > subdirecto

Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-12 Thread Ihor Radchenko
Janek F writes: > Considering the other messages, let's not get lost in details, the default > function does not need to consider all edge cases. It simply should not error > out on ids in a different format. You are indeed right, but we may use multiple different approaches to achieve this. S

[PATCH v2] Re: Adding target and custom id links doesn't ask for description

2022-08-12 Thread Ihor Radchenko
Carlos Pita writes: >> Carlos, have you tried Ihor's patch? I like the intention, but I do not >> see any effect. >> > > Yes, I've tested it with target and custom_id links and, as you said, there > is no change in behavior. The entire URL is still pasted and no chance to > edit it is given to th

Re: org-cite-insert + fido-mode

2022-08-12 Thread András Simonyi
Could you try Alt-j? best wishes, András On Sat, 13 Aug 2022 at 03:22, Tyler Grinn wrote: > > "Bruce D'Arcus" writes: > > > You need to use whatever keybinding exits. > > I've tried every key in the mode map. >

Re: org-cite-insert + fido-mode

2022-08-12 Thread Tyler Grinn
"Bruce D'Arcus" writes: > You need to use whatever keybinding exits. I've tried every key in the mode map.

Re: org-cite-insert + fido-mode

2022-08-12 Thread Bruce D'Arcus
You need to use whatever keybinding exits. On Fri, Aug 12, 2022, 8:53 PM Tyler Grinn wrote: > > I need help inserting a citation with fido-mode (icomplete) enabled. I > call org-cite-insert, select the citation I want, and press return, and > it asks for another citation to add, filling the min

org-cite-insert + fido-mode

2022-08-12 Thread Tyler Grinn
I need help inserting a citation with fido-mode (icomplete) enabled. I call org-cite-insert, select the citation I want, and press return, and it asks for another citation to add, filling the minibuffer with the most likely option. I see no way to insert the citations I've already selected, it

[Patch] Show org file title in org-clock clocktable

2022-08-12 Thread Duy Nguyen
Hello, Please find attached a patch to allow users to show the org file titles (i.e. the value of #+title) instead of the file name in the org-clock clocktable. I created this patch as I am using a combination of org-roam and org-agenda to manage my tasks, where each project has its own org-roam

Re: [PATCH] Re: how to beamer export overlay figure?

2022-08-12 Thread edgar
On 2022-08-12 14:53, Fraga, Eric wrote: Excellent. I forgot about SVG. I actually think that it's kind of useless, anyway (won't hurt). Attached: example of work-arounds to {preserve,reserve,allocate} space for pictures in case someone needs it. -

Re: [PATCH] Re: Adding target and custom id links doesn't ask for description

2022-08-12 Thread Carlos Pita
> > > Carlos, have you tried Ihor's patch? I like the intention, but I do not > see any effect. > Yes, I've tested it with target and custom_id links and, as you said, there is no change in behavior. The entire URL is still pasted and no chance to edit it is given to the user. Best regards -- Car

Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-12 Thread Janek F
I use org-roam which creates links between org-files using the ID, and I would like to be able to manually add such links to common pages even if autocompletion doesn't work smoothly. Considering the other messages, let's not get lost in details, the default function does not need to consider a

Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-12 Thread Max Nikulin
On 21/07/2022 02:12, Janek F wrote: However I tend to customize IDs for important files by hand, causing any attempt to use org-attach on that file to fail if the ID is shorter than six characters:     org-attach-id-ts-folder-format: Args out of range: "ftt", 0, 6 This method should be adjust

[PATCH] Re: how to beamer export overlay figure?

2022-08-12 Thread Fraga, Eric
On Friday, 12 Aug 2022 at 14:35, ed...@openmail.cc wrote: > It worked! Thanks. I send a counter-patch :) (for SVG). Excellent. I forgot about SVG. So I throw one back at you! ;-) Just deleted a spurious message line. Maybe somebody with submit access can have a look and see if this is suitable

Re: how to beamer export overlay figure?

2022-08-12 Thread edgar
On 2022-08-12 11:50, Fraga, Eric wrote: Attached is a patch that seems to do what you want. Are you able to try this? I'm sure there's a better way to do this but at least this seems to work. It worked! Thanks. I send a counter-patch :) (for SVG). --

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Ihor Radchenko
"Christopher M. Miles" writes: >> Also, I suggest to use M-x write-file in the profiler buffer when >> sharing something as deeply nested as you got. The resulting file is >> much more comfortable to view - it will preserve all the actual profiler >> data. > > I see, I tried it, it indeed kept th

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Christopher M. Miles
Bill Burdick writes: > You'll have this with recursive code and recursion is fairly normal in Lisp > programs. > > -- Bill I think this profiler report invocation stack is not recursive code. WDYT? > > On Fri, Aug 12, 2022 at 8:22 AM Christopher M. Miles > wrote: > > Ihor Radchenko writes

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >>> I do not see much issue with deep nesting of the code. >> >> Is this deep nested code normal in Emacs Lisp? >> >> Usually (based on my less than 20 times profiling experience), Emacs >> wouldn't have deeper code than 40 levels. But m

Re: [BUG] Warning (org-element-cache): org-element--cache: Org parser error in notmuch-show.el::10751. Resetting. [9.5.4 (release_9.5.4-702-g5a49cc @ /home/grfz/src/org-mode/lisp/)]

2022-08-12 Thread Ihor Radchenko
Gregor Zattler writes: > Dear org-mode developers, Ihor, > > I just got this warning: > > Warning (org-element-cache): org-element--cache: Org parser error in > notmuch-show.el::10751. Resetting. > The error was: (error "rx ‘**’ range error") Thanks for reporting! > Backtrace: > " backtrace

[BUG] Warning (org-element-cache): org-element--cache: Org parser error in notmuch-show.el::10751. Resetting. [9.5.4 (release_9.5.4-702-g5a49cc @ /home/grfz/src/org-mode/lisp/)]

2022-08-12 Thread Gregor Zattler
Dear org-mode developers, Ihor, I just got this warning: Warning (org-element-cache): org-element--cache: Org parser error in notmuch-show.el::10751. Resetting. The error was: (error "rx ‘**’ range error") Backtrace: " backtrace-to-string(nil) org-element-at-point() org-element-context()

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-12 Thread Max Nikulin
On 12/08/2022 09:21, Hraban Luyat wrote: @Max: what do you think of when-let? That seems more appropriate for this situation. Thoughts? At first I thought about compatibility, but this form is available since Emacs-25, so it is not a problem. Maybe I missed something, but I do not see clear

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Ihor Radchenko
"Christopher M. Miles" writes: >> I do not see much issue with deep nesting of the code. > > Is this deep nested code normal in Emacs Lisp? > > Usually (based on my less than 20 times profiling experience), Emacs > wouldn't have deeper code than 40 levels. But my attachment profiler > report has

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Bill Burdick
You'll have this with recursive code and recursion is fairly normal in Lisp programs. -- Bill On Fri, Aug 12, 2022 at 8:22 AM Christopher M. Miles wrote: > > Ihor Radchenko writes: > > > "Christopher M. Miles" writes: > > > >> When I profiling Org Agenda generation, I found that org code is

Suspected bug: '#+STARTUP: indent' messes up inlinetasks' tag alignment

2022-08-12 Thread Alain . Cochard
Hello. I use emacs -Q -l ~/.emacs.git with ~/.emacs.git containing only: (add-to-list 'load-path "~/Org/Coch-git/org-mode/lisp") (require 'org-inlinetask) which gives: Org mode version 9.5.4 (release_9.5.4-727-gb42883 @ /home/cochard/Org/Coch-git/org-mode/lisp/) GNU Emacs 27.2 (

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-12 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> When I profiling Org Agenda generation, I found that org code is deeply >> invoked in Emacs profiler report. >> >> My Question: >> >> - What reason caused this situation? >> - Can Org Mode optimize those deeply invoked code? > > Coul

Re: how to beamer export overlay figure?

2022-08-12 Thread Fraga, Eric
Attached is a patch that seems to do what you want. Are you able to try this? I'm sure there's a better way to do this but at least this seems to work. -- : Eric S Fraga, with org release_9.5.4-720-g4db67d in Emacs 29.0.50 From d17d91eb8441876a87e7405de63b3e594bb8ecc6 Mon Sep 17 00:00:00 2001 F

Re: how to beamer export overlay figure?

2022-08-12 Thread Fraga, Eric
On Thursday, 11 Aug 2022 at 23:33, Max Nikulin wrote: > I have not tried it, but the manual suggests > > #+ATTR_BEAMER: :overlay <2-> > > Does it work for lists only and not for images? No, it definitely does not work for images. I've been looking at the code. It should be possible to add this f