org-agenda-dim-blocked-tasks don't use org-todo face

2022-12-11 Thread Mark Kerr
The org-todo face is used for todo keywords in non-blocked items. When org-agenda-dim-blocked-tasks is set to true, however, the todo keyword is instead displayed using org-agenda-dimmed-todo-face. The org-priority face, however, is still used for blocked tasks. Is this by design or due to an

Re: Org functions in source blocks

2022-12-11 Thread William Denton
On 10 December 2022, Max Nikulin wrote: @I$A and the "remote" function are available in table formulas only. Moreover you quoted remote, so this s-expression is not evaluated. In addition, unlike in table formulas, in elisp function arguments are separated by space, not by comma. Thanks for

Re: Images generated by R code blocks do not display

2022-12-11 Thread William Denton
On 10 December 2022, Ihor Radchenko wrote: Ihor Radchenko writes: I now reported this to Emacs upstream. I do not see anything wrong on Org side in this case. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59902 Since the bug will affect older Emacs versions, I pushed a workaround to

Re: Flyspell causes severe slowdown when manipulating footnotes

2022-12-11 Thread arozbiz
Thanks. It definitely helps, but it's still quite slow. What's made the biggest difference is is advising the relevant functions to turn flyspell off beforehand and then turn it back on. ``` (defun azr/org-footnote-disable-flyspell (orig-fun args) (flyspell-mode -1) (apply orig-fun args)

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-11 Thread Tom Gillespie
> Please use :package-version and let the mapping be handled by > customize-package-emacs-version-alist. Got it. Here's the updated patch (I think I did it correctly?). From 47a47aa9453a54a4f5f2e9188e2ad072a77c50cb Mon Sep 17 00:00:00 2001 From: Tom Gillespie Date: Sat, 10 Dec 2022 12:11:17

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-11 Thread Tom Gillespie
Looks like string-replace doesn't support that notation, so both too aggressive and without sufficient control. I've switched to replace-regexp-in-string which does what we want. Here's the updated patch. From 12ca29965e867acd64fecaecd14f2f74e90d7e99 Mon Sep 17 00:00:00 2001 From: Tom Gillespie

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-11 Thread Kyle Meyer
Tom Gillespie writes: [...] >> :package-version instead of :version? > > I think because org is part of emacs core we use the emacs version? Please use :package-version and let the mapping be handled by customize-package-emacs-version-alist. > I see "24.1" included with other org defcustoms.

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-11 Thread Tom Gillespie
Here is an updated version of the patch with the convention corrected and the docstring updated for clarity. It would be great to try to get this into any 9.6 patches before the 29 release, but I'm not sure if that is possible. If it is missing we are likely to get a lot of messages from unhappy

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-11 Thread Tom Gillespie
Hi Max, Thank you for the feedback. More replies in lines. Best! Tom > I am not sure concerning "exactly". > > lisp/ob-core.el:248 > `org-confirm-babel-evaluate' is called with 2 arguments. In your patch > `org-confirm-babel-evaluate-cell' has a single argument. You're right, and in point of

Re: [PATCH] oc-csl: Improve LaTeX bibliography formatting

2022-12-11 Thread András Simonyi
Dear All, first of all, apologies for the delay, unfortunately, I haven't been able to work on my WIP patches for a while. Now I've attached a new version of the patch, which hopefully addresses all issues discussed earlier. best wishes, András On Tue, 8 Nov 2022 at 06:26, Ihor Radchenko

Re: [BUG] hyperbole action key on path name results in org-element-cache warning [9.6-pre (release_9.5.5-997-ge58bd0 @ /home/grfz/src/org-mode/lisp/)]

2022-12-11 Thread Robert Weiner
Hi Ihor: So if we want to determine the Org type of an element outside of an Org buffer (when using org-type minor modes for example), how would we change this 'let' code: (let* ((context ;; Only consider supported types, even if they are not ;; the closest one.

Re: Flyspell process called frequently when using Org export (was: Flyspell causes severe slowdown when manipulating footnotes)

2022-12-11 Thread Rudolf Adamkovič
Ihor Radchenko writes: > Rudolf Adamkovič writes: > >> Unrelated to the footnotes mentioned above > > Note how I change the email subject to mark a new topic. > In Emacs, it is M-x message-change-subject TIL! Thank you. > I am unable to reproduce using the latest Org. I apologize for not

Re: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)]

2022-12-11 Thread Jeremie Juste
Hello Ihor On Thursday, 8 Dec 2022 at 09:07, Ihor Radchenko wrote: > I am not sure if I like the approach you used in the commit. > > -(unless (listp (car value)) (setq value (list value))) > +(unless (listp (car value)) (setq value (mapcar 'list value))) > > In the above, you

Autoloading side effects (was: Re: [BUG] org-mouse is activated without explicit require)

2022-12-11 Thread Max Nikulin
On 11/12/2022 16:45, Ihor Radchenko wrote: We cannot do much about Emacs' handling of autoloads, but what we can (and should) do is changing org-mouse to become a global minor mode. Then, loading org-mouse will cause no side effects. I am afraid, requirement that loading should not cause side

Failed to connect to MPV

2022-12-11 Thread Alexei Gilev
Hi, I'm trying to use org-media-note and mpv together. However, I keep getting this error message. When I eval (mpv-play "file.mp3"), the audio plays (I can't stop it though or see where the MPV window is on Emacs or my computer...). But when I try to use the org-media-note hydra to open the

Requesting a new release of org-contrib.

2022-12-11 Thread Malcolm Purvis
Emacs 29 and the new main branch (emacs-30) require the 't' condition in a cl-case to be the last entry. This breaks org-checklist in version 0.4 of org-contrib. The fix has already been applied (https://git.sr.ht/~bzg/org-contrib/commit/6422b265f1150204f024e33d54f2dcfd8323005c) but it is

Re: [PATCH] Merge loaded org-persist index with index file contents

2022-12-11 Thread Timothy
Hi Max, > Please, avoid mixing of system clock and filesystem timestamps. > > (file-attribute-modification-time (file-attributes file)) > > should be more reliable. Thanks for the tip, I’ve updated the patch to use this. > In general, I would prefer to avoid relying on timestamps at all,

Re: PATCH: include controlling language= in my previous patch

2022-12-11 Thread Pedro Andres Aranda Gutierrez
Hi Ihor, thanks for the patience. I have a comment on the message you refer to... If comes from 2014. So I have resorted to my fresh Emacs29, opened it with emacs -Q for a clean environment. With the MWE ``` #+CAPTION: caption of block 1 #+BEGIN_SRC asm vmpovapd %%zmm0, %zmm1 #+END_SRC

Re: [MAINTENANCE] Org orphanage?

2022-12-11 Thread Ihor Radchenko
Bastien writes: > I think it is a very good idea and a natural evolution of org-contrib, > thanks for suggesting this. > ... > We can announce this along with the Org 9.6 release. So, we now have https://orgmode.org/worg/org-orphanage.html It is very bare bones. We can add the following: 1.

Re: [MAINTENANCE] Do we have any backwards-compatibility policy for third-party packages?

2022-12-11 Thread Ihor Radchenko
Tim Cross writes: > - Adding a section regarding pubic/private API and naming conventions to > the Hacking section of the manual. This section could outline what the > processes are for adding/changing APIs. I think we can add a section to Hacking. But what should we list there? At

Re: [PATCH] Merge loaded org-persist index with index file contents

2022-12-11 Thread Max Nikulin
On 11/12/2022 14:59, Timothy wrote: + (setq org-persist--index combined-index +org-persist--index-age (current-time) Please, avoid mixing of system clock and filesystem timestamps. (file-attribute-modification-time (file-attributes file)) should be more reliable. See

Re: PATCH: include controlling language= in my previous patch

2022-12-11 Thread Ihor Radchenko
Note: This email thread is a followup for https://orgmode.org/list/cao48bk_6bqkgp1mgnzaaryku2+st6r1d4bziq5nzmwnewqf...@mail.gmail.com Pedro Andres Aranda Gutierrez writes: > I have a second version of my previous patch, inlcuing and extra variable > to control whether you want to include the

Re: PATCH: don't emit empty attributes for lstlistings in LaTeX listings backend

2022-12-11 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > attached is a small patch for the Latex export backend that suppresses > emitting empty labels and captions when exporting src blocks using > 'listings. This cleans up the emitted LaTeX. For record. There is a new version of this patch in

Re: [BUG] org-mouse is activated without explicit require

2022-12-11 Thread Ihor Radchenko
Matt Lundin writes: > I'm not too familiar with how emacs handles autoloads. However, I find > org-mouse is automatically loaded if I call describe-function and then > tab complete after typing "", "org-", "org-m", etc. This seems enough to > load the entirely of the org-mouse.el file. > > The

Re: [BUG] org-mouse.el breaks org-open-at-point

2022-12-11 Thread Ihor Radchenko
Matt Lundin writes: > - Expected behavior > > - calling org-open-at-point with the keyboard "C-c C-o" should produce > a list of links in the entry as advertised in the docstring ("When > point is on a headline, display a list of every link in the entry, > so it is possible to

Flyspell process called frequently when using Org export (was: Flyspell causes severe slowdown when manipulating footnotes)

2022-12-11 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Unrelated to the footnotes mentioned above Note how I change the email subject to mark a new topic. In Emacs, it is M-x message-change-subject > ... , but I noticed that Org > starts and kills Ispell all the time. I see the following messages > repeated over and

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-11 Thread Ihor Radchenko
Tom Gillespie writes: > + (format-time-string > + (string-replace "<" "" > + (string-replace ">" "" (cdr > org-time-stamp-formats) `string-replace' is very aggressive. You may want something like "\\`<" and "\\'>", matching

[FR] Allow passing nested list structures to variables in src blocks (was: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /u

2022-12-11 Thread Ihor Radchenko
Johan Tolö writes: > I do pass org plain lists to R source code blocks which is why I > found the current issue. It is easy enough for me to adapt my R > code whenever there is a change in the way it is handled. It is > unfortunate that it will no longer be possible to access any > nested

[PATCH] Merge loaded org-persist index with index file contents

2022-12-11 Thread Timothy
Hi All, I’ve recently pushed a batch of improvements/fixes to org-persist, particularly with the handling of url containers. Expect to actually see caching of remote images now . I’ve also noticed that the org-persist index is written when Emacs closes, and so this sequence of event can happen:

PATCH: include controlling language= in my previous patch

2022-12-11 Thread Pedro Andres Aranda Gutierrez
Hi, I have a second version of my previous patch, inlcuing and extra variable to control whether you want to include the language= or not. It is made in a backwards-compatible way. Default is to include it and you have to (setq org-latex-listings-src-omit-language t) to omit language= I guess