[PATCH v2] org-faq.org: Inline comments

2023-07-07 Thread Max Nikulin
On 29/06/2023 17:47, Ihor Radchenko wrote: Max Nikulin writes: I think, it is time to add a FAQ entry, see the attachment. The proposed FAQ entry is overwhelming. It would work fine as a blog, but not as a quick answer to a question. I recommend leaving only the @@comment:...@@ part See a

[PATCH v2] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")

2023-07-07 Thread Max Nikulin
On 06/07/2023 16:54, Ihor Radchenko wrote: You are removing `org-protocol-flatten' function, which is a breaking change. We should leave an obsolete alias. I have added an alias for this function hardly known to anybody else. Also, you are defining `flatten-tree' function, which is outside

Re: eval with :dir in included file

2023-07-07 Thread Ihor Radchenko
Dominique Dumont writes: > Is there a way to tell org-mode to search "stacks/public-ips" directory > starting from the directory of the *included* file ? No, currently. We do something similar in `org-export--update-included-link', but not for :dir. -- Ihor Radchenko // yantar92, Org mode

eval with :dir in included file

2023-07-07 Thread Dominique Dumont
Hi I have a file with this code block: ~~~ file terraform-admin.org ** Retrieve public IPs :PROPERTIES: :CUSTOM_ID: retrieve-public-ips :END: #+begin_src shell :results verbatim :dir "stacks/public-ips" :exports both terragrunt output ips #+end_src ~~~ Exporting this file works fine. I have

Re: [BUG] org-list-struct-apply-struct overrides src block indentation (was: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)])

2023-07-07 Thread Sébastien Miquel
Ihor Radchenko writes: The cause is the following line in `org-list-struct-apply-struct' [[file:~/Git/org-mode/lisp/org-list.el::indent-line-to (+ (org-current-text-indentation) delta)))]] It calls `indent-line-to' that replaces spaces with tabs according to current value of

Re: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)]

2023-07-07 Thread Sébastien Miquel
Ihor Radchenko writes: Sebastien, it looks like one of the tests is failing on the older Emacs: https://builds.sr.ht/~bzg/job/1020247 Does this specify anywhere what version of emacs it is using ? Most likely, because `current-column' did not take into account 'display property until

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-07 Thread Ihor Radchenko
Jack Kamm writes: > ":results graphics file" is used this way in ob-R and ob-julia, and also > in the testing files test-ob-octave.el and ob-maxima-test.org. > > ":results graphics" just means that the result from > org-babel-execute:lang isn't written to the file by >

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-07 Thread Ihor Radchenko
Jack Kamm writes: > In fact, :results file also works this way for other Babel languages. > And I used this behavior before for plotting with ob-reticulate blocks. > > I attach a patch to fix the documentation in the manual about this. Your patch appear to only add more confusion, IMHO. I feel

Re: How to go to an Org headline programmatically?

2023-07-07 Thread Richard Lawrence
Hi Marcin, Marcin Borkowski writes: > I want to find an Org headline in Elisp. No need to make it visible, > for example - just move the point to the heading with a given title (it > may even be within `save-excursion', as in "go there, do something, go > back"). `org-link-search' seems to do

Re: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)]

2023-07-07 Thread Ihor Radchenko
Ihor Radchenko writes: > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2e2ed4055 Sebastien, it looks like one of the tests is failing on the older Emacs: https://builds.sr.ht/~bzg/job/1020247 Most likely, because `current-column' did not take into

Re: inconsistency links and code line labels

2023-07-07 Thread Ihor Radchenko
Dan Drake writes: > Hello -- I'm wondering about my question from here: > > https://emacs.stackexchange.com/questions/77768/why-the-inconsistency-with-org-mode-code-line-labels-and-links > > Copying my question: in a source code special block, I can add code line > labels, which have ref: in the

Re: [BUG] org-indent-mode breaks indentation in source blocks

2023-07-07 Thread Ihor Radchenko
Ihor Radchenko writes: > Looks similar to what we are trying to solve in > https://list.orgmode.org/orgmode/ZIZLzousCaylbUz1@ws/ > > I will take a closer look after installing the patch we are discussing there. It looks like the linked fix also fixed this bug: 1. cd

[BUG] org-list-struct-apply-struct overrides src block indentation (was: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)])

2023-07-07 Thread Ihor Radchenko
Using a similar example, another indentation bug has been revealed: 1. emacs -Q 2. Create an Org file with the following contents: - 1 - 2 - 3 - 4 - 5 #+begin_src yaml a: b: c: d: #+end_src Everything indented using spaces, including "d:" that uses 8

Re: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)]

2023-07-07 Thread Ihor Radchenko
Sébastien Miquel writes: > Ihor Radchenko writes: >> May you now rebase the patch onto the latest main, add a Link: to this >> discussion to the commit message, and apply the attached extra comments? > > Here it is. Thanks for helping with this. Applied, onto main.

Re: [PATCH] org-element-timestamp-interpreter: Return daterange anyway, if DATERANGE is non-nil

2023-07-07 Thread Ilya Chernyshov
Ihor Radchenko writes: > Some general stylistic comments: > 1. You left some whitespace-only blank lines and spaces at the end of >lines. Please, clean them up. > 2. Please, use double space between sentences in the commit message and >link to this thread. See >