Re: [O] #+ATTR_LaTeX no longer honoured

2013-05-20 Thread Daniel F
It's strange that you say that link is not up-to date (altho I can see that
the version you've linked to is also linked from the main page),
because it says here: http://orgmode.org/manual/index.html#Top

 This manual is for Org version 8.0.3 (release_8.0.3).

Is it possible to maybe put some sort of message that would say that the
manual is outdated?


On Mon, May 20, 2013 at 12:31 AM, Nicolas Goaziou n.goaz...@gmail.comwrote:

 Hello,

 Eric Abrahamsen e...@ericabrahamsen.net writes:

  Paul Stansell paulstans...@gmail.com writes:
 
  Hello,
 
  I've noticed that #+ATTR_LaTeX seems to be no longer honoured (I'm
  using release_8.0.3-133-ga5872)
 
  This is demonstrated for the attached org file.  It's the exact
  example from http://orgmode.org/manual/Images-in-LaTeX-export.html.
 
  I expect the exported latex file (C-c C-e l l) to contain something like
 
\includegraphics[width=5cm,angle=90]{./dummy.png}
 
  but I instead it contains
 
\includegraphics[width=.9\linewidth]{./dummy.png}
 
  Thanks,
 
  Paul
 
  PS. I'm using Emacs 24.2.1 and I tested with the minimal org-mode
  set-up from http://orgmode.org/manual/Feedback.html.
 
  I won't even attempt to give an overview of how attribute syntax has
  changed/is changing, or explain why and how the manual is out of date,
  but while we're waiting for someone else to do that, here's the line
  you're looking for:
 
  #+ATTR_LaTeX: :width 5cm :options angle=90

 The manual is up-to-date (sections about HTML and ODT export may lag
 a bit behind), but the URL isn't. In particular, see:

   http://orgmode.org/org.html#LaTeX-specific-attributes

  Very briefly, I think attributes that may be common to multiple backends
  are now given as eg :width or :height (with no equals sign before the
  value), while attributes that are rarer or likely backend-specific are
  stuffed into one :options attribute, with the keys/values written more
  literally.

 AFAIK, :options is specific to latex back-end. Common attributes are set
 the usual way, i.e. with :attribute value syntax. Though it's
 impossible to recognize them all. So :options is handy to add raw
 arguments.

 Anyway, all attributes should be documented in the manual.


 Regards,

 --
 Nicolas Goaziou




-- 
Sincerely yours,
-- Daniil


Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Daniel F
It looks great!
I think I'd only convert defvars to defcustom.

Personally, I don't worry about prefixes that much, because if I am not
using a command very often I just tend do run it using M-x command-name

- Dan


On Fri, May 17, 2013 at 2:41 PM, Max Mikhanosha m...@openchat.com wrote:

 At Fri, 17 May 2013 09:38:29 +0200,
 Rainer M. Krug wrote:
 
  Nice and very useful. Can this be included in /contrib?

 That is my intention, I have the FSF paper signed for Emacs and Org.

 So what I'm looking for some minimum amount of eyes on the code, and
 advice as to minimum set of things I need to adjust before committing it?

 My list is.

 1. Convert defvar to defcustom

 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
dired.el

 3. The prefix C-c M-s seems awkward but Org is so big everything else
is taken, and C-c C-x s is too close to C-c C-x C-s, which is
archive subtree (I initially had it there and moved after archiving
subtree by mistake)

 Its its fine to go in as is, then its fine too, I'm pretty lazy :-)

 Regards,
   Max




-- 
Sincerely yours,
-- Daniil


Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-13 Thread Daniel F
Hi Carsten, Ivan.

Thanks for the feedback. The issue that Ivan mentioned does look important
and I'll try to fix it asap and incorporate the check.
I'll also look into the rehilighting thing, I am not sure if that's
possible. I guess it also would be nice to scroll not just to the right
page, but also to the right line in the text.

As for the as- prefix I just assumed that this is legit because the
package was already present in the org-mode.

Cheers.

- Dan


On Mon, May 13, 2013 at 10:34 AM, Carsten Dominik carsten.domi...@gmail.com
 wrote:

 Hi Daniil,

 I like this a lot and would like to take the patch after you have taken
 Ivans feedback, and maybe more feedback if you get any.

 I would like it even more if following the link would rehighlight the
 selected text.  Is there any way to achieve this?

 I have another question, this would maybe be for the original author,
 Anthony Lander?  I see that there are functions with prefixes that are not
 org-.  This is dangerous because there might be packages around that use
 that name space.  I also think it violates coding rules in Emacs.  I think
 this should be changed - unless you know of a convention that all functions
 dealing with applescripts are supposed to have an as- prefix.

 I can fix this - but I wanted your feedback first.

 Thanks.

 - Carsten

 On 12 mei 2013, at 20:29, Daniil Frumin difru...@gmail.com wrote:

  Hi, all!
 
  I use org-mac-link-grabber.el 
 http://orgmode.org/worg/org-contrib/org-mac-link-grabber.html almost
 every day. However, it lacks support for an app that I'd like to use
 together with org-mode.
 
  Skim.app is a light and fast PDF reader for Mac OS X with a note-taking
 ability. I wrote a little patch for org-mac-link-grabber.el to support
 grabbing links to documents.
 
  What it does:
 
  * Grabs not just the link to file, but a page
 
  * Inserts the selected text as a description, if present. Otherwise
   inserts filename, p. page #
 
  * The shortcut is set to [S]
 
  * Defines a new skim link type
 
  It would be interesting to also add some support for importing notes
 from Skim to org.
 
  Since Skim.app is not present in clean OS X installs, by default support
 for grabbing links from it is disabled. You can enable it by customizing
 group `org-mac-link-grabber'.
 
  So, maybe it's possible to get this patch into the tree? It's my first
 time hacking on org (or even any major elisp extension), so it's probably
 that I've messed up somewhere with a commit format or whatnot.
 
  Cheers.
 
  -- Daniil Frumin
  0001-Adding-Skim.app-support-to-org-mac-link-grabber.el.patch




-- 
Sincerely yours,
-- Daniil