Re: [O] [PATCH 1/3] org-habit: Add org-habit-scheduled-past-days

2019-02-08 Thread John Lee
On Thu, 7 Feb 2019, at 21:27, John Lee wrote: > On Wed, 6 Feb 2019, at 21:32, Nicolas Goaziou wrote: > > I applied them in master. Thank you. > > Thank you! > > > Could you provide an entry for ORG-NEWS file, too? Attached. From ded5296358ec2bcfbe58a662b5112226298bf43f

Re: [O] [PATCH 1/3] org-habit: Add org-habit-scheduled-past-days

2019-02-07 Thread John Lee
On Wed, 6 Feb 2019, at 21:32, Nicolas Goaziou wrote: > I applied them in master. Thank you. Thank you! > Could you provide an entry for ORG-NEWS file, too? Will do.

Re: [O] Closing a task yesterday (or changing the day cutoff to 4am)

2019-02-03 Thread John Lee
Also see variable org-use-effective-time On Sat, 2 Feb 2019, at 15:30, Leo Gaspard wrote: > Uwe Koloska writes: > > Maybe the variable 'org-extend-today-until' can help. > > Indeed, thank you! >

Re: [O] [PATCH 1/3] org-habit: Add org-habit-scheduled-past-days

2019-02-03 Thread John Lee
changes in response to review feedback) is "greying out" habits that you just did, by applying face 'org-agenda-done when a habit is scheduled for the future. On Sun, 3 Feb 2019, at 16:03, John Lee wrote: > * lisp/org-habit.el (org-habit-scheduled-past-days): New variable &g

[O] [PATCH 1/3] org-habit: Add org-habit-scheduled-past-days

2019-02-03 Thread John Lee
* lisp/org-habit.el (org-habit-scheduled-past-days): New variable * lisp/org-agenda.el (org-agenda-get-scheduled): override `org-scheduled-past-days' for habits if `org-habit-scheduled-past-days` is not nil TINYCHANGE --- lisp/org-agenda.el | 4 +++- lisp/org-habit.el | 15 +++

Re: [O] org-habit: allow overriding org-scheduled-past-days and always including time of day

2019-02-03 Thread John Lee
On Sun, 18 Nov 2018, at 23:40, Nicolas Goaziou wrote: > * lisp/org-habit.el (org-habit-scheduled-past-days): New variable. > > > (when (or (and (> ddays 0) (< diff ddays)) > > - (> diff org-scheduled-past-days) > > + (> diff (if habitp > > +

[O] [PATCH 3/3] org-habit: Use face 'org-agenda-done for habits scheduled for future

2019-02-03 Thread John Lee
* lisp/org-agenda.el (org-agenda-get-scheduled): Use the face. This has the effect that if you just did the habit, it is "greyed out" in the agenda. TINYCHANGE --- lisp/org-agenda.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index

[O] [PATCH 2/3] org-habit: Always show time of day designation for habits

2019-02-03 Thread John Lee
* org-agenda.el (org-agenda-get-scheduled): Always show the time of day designation for habits TINYCHANGE --- lisp/org-agenda.el | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 9145cafa8..39ae85f30 100644 ---

[O] [PATCH 1/3] org-habit: Add org-habit-scheduled-past-days

2019-02-03 Thread John Lee
* lisp/org-habit.el (org-habit-scheduled-past-days): New variable * lisp/org-agenda.el (org-agenda-get-scheduled): override `org-scheduled-past-days' for habits if `org-habit-scheduled-past-days` is not nil TINYCHANGE --- lisp/org-agenda.el | 8 +++- lisp/org-habit.el | 15

Re: [O] Mark vacation days

2019-02-03 Thread John Lee
I don't know a good way to do this out of the box. Here are two ways you could go about it, but they both involve a bit of programming. They would all use org-agenda-day-face-function similar to the code you already posted. 1. Least programming: Add emacs diary entries (rather than recording

Re: [O] org-habit: allow overriding org-scheduled-past-days and always including time of day

2019-02-02 Thread John Lee
On Sun, 18 Nov 2018, at 23:40, Nicolas Goaziou wrote: > Hello, Hi, sorry Nicolas I totally missed your review comments! > John Lee writes: For context since it's months ago now: > > My own workflow around this is similar to GTD, so I'm using SCHEDULED > > as basically a way

[O] [PATCH] org-habit: allow overriding org-scheduled-past-days and always including time of day

2018-11-05 Thread John Lee
I guess I'm supposed to add the [PATCH] tag to the subject line? So this email is just to do that. Sorry if I've missed some instructions about this... On Mon, 5 Nov 2018, at 00:31, John Lee wrote: > Hi > > Here's a couple of patches that add new org-habit variables. I hope the &

[O] org-habit: allow overriding org-scheduled-past-days and always including time of day

2018-11-04 Thread John Lee
yeballing it to see which ones are around now in time. This motivates `org-habit-always-show-time'. I have not yet submitted the FSF copyright assignment form but am prepared to do so. >From 7bcf7b70b201af7a3d3cbbcf6a95511944370627 Mon Sep 17 00:00:00 2001 From: John Lee Date: Sun, 4 Nov 2018 2