Re: [PATCH] Bug: fragile org refile cache

2021-05-04 Thread Maxim Nikulin
On 02/05/2021 13:59, Ihor Radchenko wrote: Maxim Nikulin writes: Some additions. org-outline-path-cache is used solely by org-refile-get-targets (maybe there are some calls in other packages) but it efficiency is questionable. It was not clear for me earlier that the cache is reset before each

Re: [PATCH] org-protocol: Fix missing '+' in js snippet

2021-05-02 Thread Maxim Nikulin
On 30/04/2021 14:21, Bastien wrote: Maxim Nikulin writes: On 28/04/2021 12:40, Bastien wrote: Would you like to volunteer as the maintainer for org-protocol.el? For now org-protocol.el indicates that Sebastian Rose, the original author, is the maintainer, but I don't think he would

Re: [PATCH] Bug: fragile org refile cache

2021-05-01 Thread Maxim Nikulin
On 29/04/2021 23:08, Ihor Radchenko wrote: My experience is exactly opposite. Or maybe I miss something. Can you elaborate? Some additions. org-outline-path-cache is used solely by org-refile-get-targets (maybe there are some calls in other packages) but it efficiency is questionable. It was

Re: [PATCH] Bug: fragile org refile cache

2021-04-30 Thread Maxim Nikulin
On 29/04/2021 23:08, Ihor Radchenko wrote: Did you do any benchmarks? I just tried Outline path without cache: I have expanded your tests to make them more close to org-get-outline-path org-get-outline-path without cache | 5.459114059 | 12 | 1.205358000987 | org-get-outline-path with cach

Re: stability of toc links

2021-04-30 Thread Maxim Nikulin
On 30/04/2021 13:24, Timothy wrote: Dominique Dumont writes: For what it's worth, DNS servers faces a similar problem where host names can contain any unicode character, but DNS servers support only ascii char. In DNS cases, this is worked around using punycode. (1) Using the example above, a

Re: [PATCH] Bug: fragile org refile cache

2021-04-29 Thread Maxim Nikulin
On 29/04/2021 23:08, Ihor Radchenko wrote: Maxim Nikulin writes: Curiously my experience is that avoiding this lazy cache with backtracking and maintaining custom structure during sequential scan of the buffer works several times faster. My experience is exactly opposite. Or maybe I miss

Re: [PATCH] org-protocol: decode "+" in query part as space (v2)

2021-04-29 Thread Maxim Nikulin
I have realized that only a half of new apostrophes in doc strings were properly escaped, so I am attaching updated patch. I still consider the change as a minor improvement. On 06/04/2021 21:47, Maxim Nikulin wrote: When I tried org-protocol for the first time, I was quite surprised that

Re: [PATCH] Bug: fragile org refile cache

2021-04-29 Thread Maxim Nikulin
On 29/04/2021 21:12, Ihor Radchenko wrote: There is org-outline-path-cache used by org-get-outline-cache. It avoids computing parent's outline path multiple times, which is already a great improvement. Curiously my experience is that avoiding this lazy cache with backtracking and maintaining c

Re: [PATCH] Bug: fragile org refile cache

2021-04-29 Thread Maxim Nikulin
On 29/04/2021 08:29, Ihor Radchenko wrote: I do not observe the breakage as described in the first message, mostly because I use refile cache exclusively for org-refile. Maybe I could avoid org-goto as well. Actual reason to use it was that it does not ask for file name as the first step in th

Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use

2021-04-28 Thread Maxim Nikulin
On 28/04/2021 15:37, Utkarsh Singh wrote: +List of preferred separator (in order of preference): +comma, TAB, semicolon, colon or SPACE. I will hardly be using this feature heavily, so I do not insist that the following must be taken into account. Just some considerations... There are locales

[PATCH] Bug: fragile org refile cache

2021-04-28 Thread Maxim Nikulin
Reviewing my attempt to speedup collecting of refile targets https://orgmode.org/list/s209r8$16en$1...@ciao.gmane.io/ I have realized that refile cache is unreliable. With specific customization, cache content and thus refile targets depend on the function called first: `org-refile' ([C-u] C-c C

Re: [PATCH] org-protocol: Fix missing '+' in js snippet

2021-04-28 Thread Maxim Nikulin
Hi Bastien. On 28/04/2021 12:40, you wrote: Hi Maxim, Would you like to volunteer as the maintainer for org-protocol.el? For now org-protocol.el indicates that Sebastian Rose, the original author, is the maintainer, but I don't think he would mind handing it to someone else. I am proud to ge

Bug? C-h v in src block since org-9.4

2021-04-28 Thread Maxim Nikulin
Hi, I am unsure if it is a bug or expected behavior of autoload. Try the following org file in new a "emacs -Q" instance: --- >8 --- #+begin_src elisp (setq org-refile-use-cache t) ;;^- put cursor here and try C-h v #+end_src --- 8< --- With org 9.3.8 I get `org-refile-use-cache' as de

Re: org-store-link and help for a key

2021-04-27 Thread Maxim Nikulin
On 27/04/2021 22:52, Nicolas Goaziou wrote: Maxim Nikulin writes: My expectation is to get link to org-beginning-of-line if help is invoked from an org buffer and link to beginning-of-line if I came to the help page from some other file. I did this on master. I only tested it lightly

Re: org-store-link and help for a key

2021-04-27 Thread Maxim Nikulin
On 27/04/2021 21:25, Bastien wrote: Even though storing links to help buffers describing key bindings is tempting, there is no way to recreate such buffers only based on the key string, because keys are contextual. In org-mode, C-h k C-a will describe org-beginning-of-line while in other modes

Re: [PATCH] optimize org-refile-get-targets

2021-04-25 Thread Maxim Nikulin
On 25/04/2021 19:25, Bastien wrote: Are you still using it? Did anyone tested it? I realized that I break cache a bit, so the patch should not be applied in the current form. I have an idea how to fix it but I have found more problems around (independent of my patch). I did not worried sinc

Re: link syntax fixing bug?

2021-04-25 Thread Maxim Nikulin
On 21/03/2021 05:46, Samuel Wales wrote: the issue is that when i click on google, the space before "hi" does not show up in the earch box. ergo, different results. *** should be orig [[http://www.google.com/search?q=%7E%22retroactive%20whatever%22%20%22hi%22][retro original]] *** should be fix

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-24 Thread Maxim Nikulin
On 21/04/2021 22:45, Juan Manuel Macías wrote: I have tried the Nicolas' patch (latest version) and I see that the items with emphasis are already ordered well. However, it seems that the problem with identical items with or without emphasis still persists: which items should go before and in wh

Re: stability of toc links

2021-04-23 Thread Maxim Nikulin
On 21/04/2021 23:24, Nicolas Goaziou wrote: In particular, I'm not sure to understand how one system can generate an ID based on the heading content and still limit itself to alphanumeric characters. For example, what ID are generated with the following document? My impression is that such con

Re: [PATCH] org-protocol: Fix missing '+' in js snippet

2021-04-23 Thread Maxim Nikulin
On 19/04/2021 17:53, David Asabina wrote: javascript:location.href = \\='org-protocol://capture?url=\\='+ \\ -encodeURIComponent(location.href) + \\='&title=\\=' \\ +encodeURIComponent(location.href) + \\='&title=\\=' + \\ encodeURIComponent(document.title) + \\='

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-21 Thread Maxim Nikulin
On 21/04/2021 03:37, Nicolas Goaziou wrote: Maxim Nikulin writes: (let ((s (org-sort-remove-invisible "A wrapping [[https://orgmode.org?a=b&c=d#e][link]] emphasis/" I expect "A wrapping link emphasis". Yet, your expectations are wrong. There is no link in the tex

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-20 Thread Maxim Nikulin
On 20/04/2021 20:57, Nicolas Goaziou wrote: Maxim Nikulin writes: (org-sort-remove-invisible "A") #("A" 0 1 (:parent (#("A" 0 1 ... This is a string. Thank you, from second attempt I have managed to strip text properties. Since the intended usage of retu

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-20 Thread Maxim Nikulin
On 20/04/2021 00:50, Nicolas Goaziou wrote: Maxim Nikulin writes: On 19/04/2021 23:08, Nicolas Goaziou wrote: + ;; Space role in sorting. + ;; Test would fail for locales with ignored space, e.g. en_US, it works + ;; in C and currently rare locales having significant space

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-20 Thread Maxim Nikulin
Hi, On 19/04/2021 23:08, Nicolas Goaziou wrote: In my opinion, a more severe limitation comes from sequential regexp-based approach. Consider stripping markers from 1. "a =b *c* d= e" 2. "*b* /i/" Fair enough. Here comes another, more involved, attempt. Maybe first variant deserves to be c

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-19 Thread Maxim Nikulin
On 19/04/2021 23:08, Nicolas Goaziou wrote: + ;; Space role in sorting. + ;; Test would fail for locales with ignored space, e.g. en_US, it works + ;; in C and currently rare locales having significant space (es_ES, pl_PL) + (should + (equal "- Time stamp\n- Timer\n" +

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-19 Thread Maxim Nikulin
On 19/04/2021 15:33, Nicolas Goaziou wrote: Could you try the following instead? --8<---cut here---start->8--- (defun org-sort-remove-invisible (s) "Remove invisible part of links and emphasis markers from string S." (let ((remove-markers (lam

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-17 Thread Maxim Nikulin
On 10/04/2021 07:01, Juan Manuel Macías wrote: Nicolas Goaziou writes: Could you apply the same fix to the `org-verbatim-re' match above, and provide an appropriate commit message? Done! I've attached the corrected patch. Sorry for the flaws in me previous patch: I'm a bit of a novice at submi

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-16 Thread Maxim Nikulin
On 16/04/2021 21:59, Maxim Nikulin wrote: Ukrainian sort works better than Russian one with such example: printf "Иванова Алла\nИванов Адам\nИванова Светлана\n" \   | LANG=uk_UA.UTF-8 sort Иванов Адам Иванова Алла Иванова Светлана printf "Иванова Алла\nИванов Адам\nИва

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-16 Thread Maxim Nikulin
Hi Juan, On 16/04/2021 01:21, you wrote: #+begin_src emacs-lisp :tangle list-var.el (message "%S" (sort '("-\s\sv" "-\sv" "-\sa" "-\s\sa") #'string-collate-lessp)) #+end_src #+begin_src sh exec 2>&1 LC_ALL=en_US.UTF-8 emacs --batch -Q -l list-var.el #+end_src #+RESUL

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-15 Thread Maxim Nikulin
I can reproduce the issue with emacs-27.1 from ubuntu-21.04 beta live image running in qemu. Org mode is current git HEAD. It seems that something is changed in emacs since locale is correct: ubuntu@ubuntu:~$ printf '%s- v\n- /v/\n- a\n- /a/\n' '' \ | LANG=C.UTF-8 sort - /a/ - /v/ - a - v ubu

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-14 Thread Maxim Nikulin
On 14/04/2021 22:42, Maxim Nikulin wrote: I have generated es_ES.UTF-8 locale using     dpkg-reconfigure locales Depending on linux distribution you run, the locale may be ready to use or not. I tend to think that in minimal environment of virtual machine it was missed. I forgot to add a

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-14 Thread Maxim Nikulin
On 14/04/2021 02:08, Juan Manuel Macías wrote: The situation is that with locales configured for Spanish from Spain (en_ES.UTF-8) the list is not ordered correctly, unless those three spaces from org-sort-remove-invisible are removed. But I couldn't say why or if that would be appropriate as a p

Re: [Patch] to correctly sort the items with emphasis marks in a list

2021-04-13 Thread Maxim Nikulin
On 10/04/2021 18:41, Juan Manuel Macías wrote: Nicolas Goaziou writes: Do you have a simple test case to reproduce the problem? Currently sorting the following trivial lists causes no issue: - b - *a* and - *b* - a The current result is wrong: - /a/ - /v/ - a - b I c

Re: Using backticks for the inline code delimeter?

2021-04-06 Thread Maxim Nikulin
On 05/04/2021 06:06, Nicolas Goaziou wrote: Joost Kremers writes: I tend to agree that allowing local modifications of Org's syntax is pretty much pointless, but then why is `org-emphasis-alist` a user option? In practice, the faces, i.e., the values, are meant to be customizable, not the key

[PATCH] org-protocol: decode "+" in query part as space

2021-04-06 Thread Maxim Nikulin
Hi, Some time ago, when I tried org-protocol, I was quite surprised that query parameters generated using URLSearchParams JavaScript class are decoded incorrectly. "+" characters representing space are passed as is. I hope, I have found a proper place in the code to handle such case. It does

Re: Using backticks for the inline code delimeter?

2021-04-04 Thread Maxim Nikulin
On 02/04/2021 18:23, Andreas Eder wrote: On Do 01 Apr 2021 at 09:32, autofrettage wrote: Please evaluate the design of Org Mode (and other things) without putting a value on how similar it is to other things. A bicycle would appear more familiar to a car driver if we replaced the handlebar with

Re: Idea for handling timezones

2021-04-04 Thread Maxim Nikulin
The notes below are quite general and unrelated to particular message. On 04/04/2021 07:51, Tom Gillespie wrote: followed by a space and then the repeat or delay for example [+1-01-01 10:11:00,992315771-04:00 Sat] or [-480-08-20 05:00+01:00] or more temporally local [2021-03-03 17:43-07:00

[PATCH 3/3] test-org-protocol.el: Add expected failures for file:/// URLs

2021-04-04 Thread Maxim Nikulin
* testing/lisp/test-org-protocol.el (test-org-protocol/org-protocol-store-link-file, test-org-protocol/org-protocol-capture-file): Add tests to document that existing calls to `org-protocol-sanitize-uri' could make passed URLs invalid by changing number of slashes after scheme. Till a fix of the p

[PATCH 2/3] org-protocol.el: Fix detection of old-style URIs

2021-04-04 Thread Maxim Nikulin
* lisp/org-protocol.el (org-protocol-check-filename-for-protocol): Avoid incorrect regexp in check whether command line argument uses new syntax. Fix failures of org-protocol tests. Question mark was not escaped in the previous version 928e67df7e, so any string was matched by lazy "*". Match in n

[PATCH 1/3] test-org-protocol.el: Fix the case for parse parameters with complex argument

2021-04-04 Thread Maxim Nikulin
* testing/lisp/test-org-protocol.el (test-org-protocol/org-protocol-parse-parameters): Specify that the case simulating real life capture uses new style parameters string to prevent test failure. It looks like a typo survived since addition of this case in 2216f4d2c7. --- testing/lisp/test-org-pr

Broken org-protocol tests

2021-04-04 Thread Maxim Nikulin
Hi, Is there any reason why org-protocol tests are not run by default? Is dependency on server.el considered as too heavy for routine testing? I know, the tests are broken, but I suspect, it is a consequence that additional efforts are required to run them. Almost unrelated note: either I mi

Re: Using backticks for the inline code delimeter?

2021-04-01 Thread Maxim Nikulin
On 01/04/2021 02:24, Sébastien Miquel wrote: George Mauer writes: is there a straightforward way to extend the org parser to do this? For the cosmetic part, there's this  piece of code from https://archive.casouri.cat/note/2020/better-looking-verbatim-markup-in-org-mode/index.html Personall

Re: [PATCH 2/2] Add quotes to emacsclient arguments in examples

2021-03-29 Thread Maxim Nikulin
On 28/03/2021 23:38, Maxim Nikulin wrote: > * doc/org-manual.org, lisp/org-protocol.el: Quote emacsclient arguments > in examples to prevent interpreting of ampersands as intent > to run processes in background by bash and similar shells. > Single quotes may cause a problem with cmd

Re: [PATCH] org-protocol: Make org protocol defaults work on windows

2021-03-28 Thread Maxim Nikulin
On 20/11/2020 23:26, Robert wrote: > Attached a little patch to make the default org-protocol > handlers work on windows. Unsure, but the issue might be addressed by the following change: https://code.orgmode.org/bzg/org-mode/commit/928e67df org-protocol: Allow slashes after sub-protocol I am cur

[PATCH 2/2] Add quotes to emacsclient arguments in examples

2021-03-28 Thread Maxim Nikulin
* doc/org-manual.org, lisp/org-protocol.el: Quote emacsclient arguments in examples to prevent interpreting of ampersands as intent to run processes in background by bash and similar shells. Single quotes may cause a problem with cmd.exe, so use double quotes despite they are a bit less safe in bas

[PATCH 1/2] org-manual.org: Fix typo in org-protocol capture example

2021-03-28 Thread Maxim Nikulin
* doc/org-manual.org: Use "&" as parameter separator in query part of example for org-protocol capture URI. --- doc/org-manual.org | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/org-manual.org b/doc/org-manual.org index 258576b24..e2fbdceb4 100644 --- a/doc/org-manual.org

Re: Bug: Org manual, 16.15.2 The ‘capture’ protocol, possible error [9.4.4 (release_9.4.4 @ /home/admin/Programming/Software/emacs/lisp/org/)]

2021-03-24 Thread Maxim Nikulin
On 21/03/2021 14:04, Jean Louis wrote: > emacsclient org-protocol://capture?template=X?url=URL?title=TITLE?body=BODY Certainly extra question marks should be replaced by "&". emacsclient 'org-protocol://capture?template=X&url=URL&title=TITLE&body=BODY' However I am in doubts if such

Re: org-adapt-indentation not honored prior to Org 9.4?

2021-03-24 Thread Maxim Nikulin
On 24/03/2021 21:08, TRS-80 wrote: On 2021-03-22 15:37, Mike Kupfer wrote: In 27.1, if I visit foo.org and type "* header RET", point is put in the first column.  In 27.2, point is put in column 3. You are not alone, mate.  We discussed this not too long ago in the following thread: There we

Re: [PATCH] Re: Bug: Plain https links with brackets are not recognised [9.4.4 (release_9.4.4-625-g763c7a @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-03-24 Thread Maxim Nikulin
On 19/03/2021 22:07, Ihor Radchenko wrote: Maxim Nikulin writes: I could not guess how to benchmark font-lock. I have tried to open file (to get everything loaded), kill the buffer, I usually just use profiler-start/open buffer/profiler-report. However, there is also https://github.com

Re: trivial software engineering'ish question: switching org's

2021-03-22 Thread Maxim Nikulin
On 22/03/2021 00:44, Greg Minshall wrote: hi. i occasionally want to switch from the org package to a git version, then back again. and, i want to avoid the dread "mixed installation". Do you really need to switch or just to launch it a couple of times? Is it required to run namely compiled

Re: org-capture-template: table lines including newline of sorts

2021-03-21 Thread Maxim Nikulin
On 15/03/2021 03:41, Uwe Brauer wrote: On 2021-03-13 02:24, Uwe Brauer wrote: Do you need to add more pipes to keep the table structure on the line after the newline? I don't think so. I am afraid, then you should significantly modify implementation for table-line capture type. Your

Re: greedy substitution in org-open-file

2021-03-21 Thread Maxim Nikulin
On 13/02/2021 11:38, Kyle Meyer wrote: +(defun org--open-file-format-spec (format specification) + (with-temp-buffer +(insert format) +(goto-char (point-min)) +(while (search-forward "%" nil t) + (cond ((eq (char-after) ?%) + (delete-char 1)) +((lookin

Re: bug#44824: [PATCH] org.el: Avoid xdg-open silent failure

2021-03-20 Thread Maxim Nikulin
On 19/03/2021 10:50, Kyle Meyer wrote: Maxim Nikulin writes: A few comments in addition to Eli's advice to drop the (eq system-type 'gnu/linux) condition... Feel free to commit the change suggested in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44824#82 instead of this patch. +

Re: yank freeze (org-ref / Edit notes problem)

2021-03-20 Thread Maxim Nikulin
On 20/03/2021 04:11, Christian Barthel wrote: OK, I guess I found a solution: I have had a similar issue with org-capture were emacs freezed as well. However, org-capture did work in xterm and I thought about some weird usage of the X11 clipboard manager. After doing some more research, I fou

Re: [PATCH] Re: Bug: Plain https links with brackets are not recognised [9.4.4 (release_9.4.4-625-g763c7a @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-03-19 Thread Maxim Nikulin
On 16/03/2021 19:35, Ihor Radchenko wrote: +;;; Link regexps + +(ert-deftest test-ol/plain-link-re () + "Test `org-link-plain-re'." + (should + (equal +'("https" "//example.com/qwe()") +(org-test-with-temp-text +"(Some text in parenthesis followed by link with brackets https:

Re: How to get shell source blocks to read my profile?

2021-03-18 Thread Maxim Nikulin
On 16/03/2021 20:21, George Mauer wrote: I do still wonder what would be the disadvantage of just configuring it to do --login by default and doing all configuration in profile scripts. At the first glance it at least should not cause great trouble. Most shell stuff is written in fool-proof

Re: export org table to html, exclude certain rows

2021-03-18 Thread Maxim Nikulin
On 18/03/2021 20:34, Uwe Brauer wrote: Does there exist a similar feature for rows? Have you tried "/"? https://orgmode.org/manual/Advanced-features.html

Re: Syntax Proposal: Multi-line Table Cells/Text Wrapping

2021-03-18 Thread Maxim Nikulin
On 18/03/2021 03:29, Atlas Cove wrote: I'd like to propose an addition to the table syntax that would allow for text wrapping in tables, I personally have myself managing very large org tables, and having to scroll through them is often cumbersome. As a result, I often yearn for greater contro

Re: [PATCH] Re: Bug: Plain https links with brackets are not recognised [9.4.4 (release_9.4.4-625-g763c7a @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-03-17 Thread Maxim Nikulin
On 16/03/2021 19:35, Ihor Radchenko wrote: I am testing the new regexp for a few days now. Because the regexp is quite complex and because font-lock apparently fontifies even invisible (folded) text, loading time on large org files with many links became noticeably longer. Though it was 7.2Mb fi

Re: How to get shell source blocks to read my profile?

2021-03-16 Thread Maxim Nikulin
On 16/03/2021 00:49, George Mauer wrote:   shell-file-name: "/bin/zsh -i" I am afraid, you should be prepared to face some problem accidentally. The value of this variable is used to execute the specified file ("zsh -i" in the "/bin" directory, I do not think, you have such file), not as a p

Re: [PATCH] Re: Bug: Plain https links with brackets are not recognised [9.4.4 (release_9.4.4-625-g763c7a @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-03-15 Thread Maxim Nikulin
On 13/03/2021 12:24, Ihor Radchenko wrote: Here is the right one I think, some unit tests would be great to avoid future regressions. Since it is heuristics, some cases will be always broken, so tests could clarify intentions. I have not tested the regexp on real cases, so you have full rig

Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file

2021-03-10 Thread Maxim Nikulin
Christopher, if your are still interested in a patch against this issue then you could find one in https://orgmode.org/list/eff43744-12e1-a359-39f2-6d8169350...@gmail.com/ It managed to pass unnoticed by Bastien's dog somehow. I have realized that I used "'" for function references, that should b

Re: org-refile failed due to default option stored by org-goto

2021-03-09 Thread Maxim Nikulin
On 05/03/2021 05:53, Samuel Wales wrote: diff --git a/lisp/org-refile.el b/lisp/org-refile.el index 1e6872b46..8f98e9cf9 100644 --- a/lisp/org-refile.el +++ b/lisp/org-refile.el @@ -617,7 +617,9 @@ this function appends the default value from (tbl (mapcar (lambda (x)

[PATCH] optimize org-refile-get-targets

2021-03-06 Thread Maxim Nikulin
On 05/03/2021 04:03, Samuel Wales wrote: interesting. that would be great to speed it up. [i just meant that the file list used to be correct.] I am a bit disappointed. I have managed to get x2 performance boost. At first, the result was x2 better but I realized that I did not added heading

Re: Org mode links: Open a PDF file at a given page and highlight a given string

2021-03-05 Thread Maxim Nikulin
On 03/03/2021 23:11, Juan Manuel Macías wrote: Maxim Nikulin writes: Please, do not forget to pass stings coming from user input through shell-quote-argument. So, maybe it would look better like this (`start-process' instead of `start-process-shell-command')?: My intention was ju

org-refile failed due to default option stored by org-goto

2021-03-04 Thread Maxim Nikulin
On 03/03/2021 00:15, Maxim Nikulin wrote: There is one issue however. Default option option does not work if after cache clean other command is called, e.g. - jump using C-u C-c C-j - clean cache C-u C-u C-u C-c C-w - try to jump or to refile [C-u] C-c C-w to default offered option - "

Re: org-refile-use-cache and jumps using org-refile or org-goto

2021-03-04 Thread Maxim Nikulin
On 03/03/2021 09:34, Samuel Wales wrote: until recently in maint, ido and ido hacks with both refile and refile goto [note: org-refile with a goto arg, not org-goto] has worked perfectly. with no cache. now, there is an issue, where with no cache that i know of, the first use, or the first use

Re: Org mode links: Open a PDF file at a given page and highlight a given string

2021-03-03 Thread Maxim Nikulin
On 03/03/2021 09:31, Juan Manuel Macías wrote: (start-process-shell-command "zathura" nil (concat "zathura " clean-path " -P "

Re: greedy substitution in org-open-file

2021-03-03 Thread Maxim Nikulin
Discussion of the original patch: https://orgmode.org/list/4b51d104.9090...@jboecker.de/T/#u https://lists.gnu.org/archive/html/emacs-orgmode/2010-01/msg00450.html https://orgmode.org/list/4bb9c078.9050...@jboecker.de/ The patch may make it a little easier to break things by misconfiguring org-f

Re: Org mode links: Open a PDF file at a given page and highlight a given string

2021-03-03 Thread Maxim Nikulin
On 03/03/2021 05:36, Kyle Meyer wrote: Rodrigo Morales writes: [...] + create a Org link to specific pages of a PDF and highlight a given string. #+begin_src emacs-lisp :results silent (setq org-file-apps '(("\\.pdf::\\([0-9]+\\)::\\([^:]+\\)\\'" . "zathura -P %1 -f %2 %s"))) #+end_s

org-refile-use-cache and jumps using org-refile or org-goto

2021-03-02 Thread Maxim Nikulin
It seems, something goes a bit wrong. However it is rather confusion than anything really broken. Maybe everybody uses helm, ivy, etc., so nobody is affected. Usually I jump from one note to another heading with C-u C-c C-j (org-goto interface with target completion). I have not setup helm or

Re: [bug] org-yank in stars corrupts outline

2021-02-27 Thread Maxim Nikulin
On 27/02/2021 07:52, Samuel Wales wrote: i have org-yank-adjusted-subtrees t * org-yank is funny *** kill this line (with newline) then try yanking at ^ places (remove the ^ first) the fault lies in the stars insertion above and arbitrary demotion *** x asdfnaksdj fnkadsn fkjans df ^a^sdkfjnaks

Re: bug#44824: [PATCH] org.el: Avoid xdg-open silent failure

2021-02-19 Thread Maxim Nikulin
On 19/02/2021 21:54, Eli Zaretskii wrote: From: Maxim Nikulin Date: Fri, 19 Feb 2021 19:29:49 +0700 On Windows Emacs always uses pipes, because we don't have PTYs there. And there's no xdg-open on MS-Windows anyway, so it's a moot point. Should I consider your response as

Re: bug#44824: [PATCH] org.el: Avoid xdg-open silent failure

2021-02-19 Thread Maxim Nikulin
On 18/02/2021 21:48, Eli Zaretskii wrote: From: Maxim Nikulin Date: Thu, 18 Feb 2021 19:56:03 +0700 I could not estimate effect of such change on windows, so pipe process is used only on linux. I am unsure concerning mac however. On Windows Emacs always uses pipes, because we don't have

[PATCH] org.el: Avoid xdg-open silent failure

2021-02-18 Thread Maxim Nikulin
On 31/01/2021 23:33, Eli Zaretskii wrote: From: Maxim Nikulin Date: Sun, 31 Jan 2021 22:57:57 +0700 Cc: 44...@debbugs.gnu.org To fix the problem it is better to use (make-process :connection-type 'pipe ...) that unfortunately has no higher level wrappers. Wouldn't it work t

Re: greedy substitution in org-open-file

2021-02-15 Thread Maxim Nikulin
On 13/02/2021 11:38, Kyle Meyer wrote: All right, here's a format-spec-inspired fix. At the very least it needs doc updates and a comment or two. Thank you. I am hardly familiar with elisp so it would be difficult for me to express the same. My comments are mostly a matter of taste. Sorry,

Re: Typing latency

2021-02-13 Thread Maxim Nikulin
On 11/02/2021 23:59, Ihor Radchenko wrote: Maxim Nikulin writes: It is not namely typing latency, but I have noticed lags while moving over collapsed headings with "up" key (with "down" it is not so apparent) e.g. in overview view. It has happened after linux upgrade, e

Re: greedy substitution in org-open-file

2021-02-12 Thread Maxim Nikulin
On 12/02/2021 14:16, Kyle Meyer wrote: #+begin_src elisp (setq org-file-apps '(("\\.pdf::\\([0-9]+\\)\\'" . "xpdf %s %1"))) #+end_src Not relevant for the underlying issue, but doesn't xpdf require a colon before the page number (i.e. ":%1")? At least for the application in debian & ubunt

Re: Typing latency

2021-02-11 Thread Maxim Nikulin
On 09/02/2021 01:24, Sébastien Miquel wrote: I often get some unpleasant latency when editing org-mode  1. Is anyone experiencing something similar ? It is not namely typing latency, but I have noticed lags while moving over collapsed headings with "up" key (with "down" it is not so apparen

Re: OT: M-S-$ Not Working

2021-02-10 Thread Maxim Nikulin
On 07/02/2021 00:18, Tim Cross wrote: I've not seen many editors with the same level of support for different alphabets and writing direction as Emacs and there are many keyborad layouts which don't include the '$' key. At the end of the day, it really just comes down to mapping of key codes - t

Re: local variables and export processing in hooks

2021-02-10 Thread Maxim Nikulin
On 09/02/2021 19:06, Eric S Fraga wrote: On Tuesday, 9 Feb 2021 at 12:30, to...@tuxteam.de wrote: Perhaps a file local variable? I tried but this doesn't seem to be propagated to the export as the export works on a copy of the buffer, not the buffer itself. That's what #+BIND is for, suppose

Re: OT: M-S-$ Not Working

2021-02-06 Thread Maxim Nikulin
On 06/02/2021 13:28, Tim Cross wrote: In general, standard Emacs key bindings are robust and reliable. If a standard key binding like M-S $ doesn't work, first step is to try emacs -Q. Sorry, but I do not agree that key bindings are robust in emacs. I use English and Russian keyboard layouts.

Re: [Resolved]Re: OT: M-S-$ Not Working

2021-02-06 Thread Maxim Nikulin
On 06/02/2021 00:38, Bo Grimes wrote: I have no idea what 3rd level is, but before I ticked it I turned off my number lock, and C-S-$ worked! So I ticked it and it stopped working. So I unticked it and ticked Number keypad always enters digits, which is, of course, why I use Num Lock to begin

Re: OT: M-S-$ Not Working

2021-02-05 Thread Maxim Nikulin
On 05/02/2021 06:25, Bo Grimes wrote: OS: PopOS 20.10, DE: GNOME 3.38.2 WM: Mutter GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.14) M-S-$ does not spellcheck word. Does C-h l view-lossage show something useful after an attempt to perform spellcheck? Is there anything in th

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-31 Thread Maxim Nikulin
On 31/01/2021 23:33, Eli Zaretskii wrote: To fix the problem it is better to use (make-process :connection-type 'pipe ...) that unfortunately has no higher level wrappers. Wouldn't it work to let-bind process-connection-type to nil around the function that starts the async subprocess? ...

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-31 Thread Maxim Nikulin
On 31/01/2021 22:05, Eli Zaretskii wrote: From: Maxim Nikulin Date: Sun, 31 Jan 2021 18:15:27 +0700 Now I see that the problem with eshell is the same. I am not familiar with eshell, but it creates new shell process for every executed command. Actual handler is killed when underlying handler

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-31 Thread Maxim Nikulin
Bhavin, thank you very much for your clear report. I have tried once more with eshell session and this time I was lucky enough to reproduce the problem in both gnome and kde sessions on Ubuntu-20.04 focal On 30/01/2021 23:28, Eli Zaretskii wrote: From: Maxim Nikulin Date: Sat, 30 Jan 2021 22

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-30 Thread Maxim Nikulin
On 30/01/2021 20:49, Eli Zaretskii wrote: How about asking the xdg-open developers to help us figure out the reason? I do not think, it is xdg-open problem. It just calls kde-open5 that spawns actual handler and immediately exits. I didn't say it was their problem, I suggested to ask them t

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-30 Thread Maxim Nikulin
On 30/01/2021 15:42, Eli Zaretskii wrote: This works: M-! xdg-open /tmp/test.pdf RET This doesn't work: M-& xdg-open /tmp/test.pdf RET This doesn't work: M-x shell RET xdg-open /tmp/test.pdf RET Geraldo, "M-x shell" case is rather strange. Could you, please, confirm ones more that okular wi

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-28 Thread Maxim Nikulin
On 28/01/2021 18:31, gbio...@gmail.com wrote: If I try in eshell buffer 'xdg-open /tmp/test.pdf && sleep 3' my cursor blinks with the Okular icon for a few seconds and then nothing happens. If I correctly get what you describe as "blinks", it could last for some time after process failure.

bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-28 Thread Maxim Nikulin
I hope, the following link to another emacs-orgmode mail list archive will not be mangled by the debbugs web interface, unlike the previous one: https://lists.gnu.org/archive/html/emacs-orgmode/2021-01/msg00327.html

Re: bug#44824: 27.1; Org export as pdf and open file does not open it

2021-01-27 Thread Maxim Nikulin
On 27/01/2021 10:36, Lars Ingebrigtsen wrote: Executing the command "xdg-open /path/to/file.pdf" in a terminal (Konsole) works. The problem may be related to SIGHUP sent to children due to pty created by emacs and closed as soon as the handler exits: https://orgmode.org/list/ru4d75$11sc$1.

Re: [PATCH] Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file

2021-01-21 Thread Maxim Nikulin
On 21/01/2021 07:58, Christopher Miles wrote: I "=git am=" your first patch, but failed to apply your second patch. Seems not continuous. So I modify code manually. I found I can't find the local variable ~shell-command~, and ~shell-command-switch~. Can your provide complete patch? So I can tes

Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file

2021-01-20 Thread Maxim Nikulin
On 20/01/2021 10:21, Christopher Miles wrote: Thanks for your working. I will modify my mailcap config temporary until Org Mode fix this issue. You're right, this change might break some behavior of some users. I don't understand Emacs sub-process mechanism. Can't help on this problem. But I'm i

greedy substitution in org-open-file

2021-01-20 Thread Maxim Nikulin
Looking into the code related to 'pty problem with start-process-shell-command, I have realized that the following case is not handled correctly: #+begin_src elisp (setq org-file-apps '(("\\.pdf::\\([0-9]+\\)\\'" . "xpdf %s %1"))) #+end_src I hope, I adapted an example from [[help:org-file-a

Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file

2021-01-19 Thread Maxim Nikulin
On 19/01/2021 08:53, Christopher Miles wrote: For this problem, do you have any workable solution patch? Maybe for a while it is better to avoid xdg-open or other handlers that launch actual viewers in background. E.g. to replace xdg-open with actual handlers in mailcap. I attach a draft p

Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file

2021-01-18 Thread Maxim Nikulin
On 05/09/2020 14:52, Bastien wrote: stardiviner writes: When I press =[C-u C-u C-c C-o]= to open an image file link with system external program. It can't open the image file. I cannot reproduce the problem here. If you still have this issue, can you provide a minimal reproducible example?

Re: Possibility to copy text outside EMACS and send it to orgmode document

2021-01-06 Thread Maxim Nikulin
On 06/01/2021 13:41, Gerardo Moro wrote: Basically that: as I copy (Control-C) text from the browser (Chrome), I would like those copied sentences to be sent to a ordered list in an OrgMode document: - copied text 1 - copied text 2 - etc. Any ideas? This would be very useful. To add to emac

Re: Inserting LaTex expressions using a filter fails

2021-01-06 Thread Maxim Nikulin
On 06/01/2021 01:33, Mart van de Wege wrote: I'm trying to replace U+00BD in an org buffer with \sfrac{1}{2} during export to LaTex, and obviously I'm doing something wrong, or I don't understand the documentation. Do you really need to replace unicode characters? If you are just trying to avo

Re: Yet another browser extension for capturing notes - LinkRemark

2020-12-27 Thread Maxim Nikulin
On 26/12/2020 20:49, Ihor Radchenko wrote: > Maxim Nikulin writes: I have reordered some parts of discussion Also, do you pass any of the parsed metadata to org-protocol? If you do, it would be trivial to get it into capture templates on Elisp (and org-capture-ref) side. I decided t

<    1   2   3   >