Re: WIP: Org-plot work

2020-09-07 Thread Mario Frasca
fork on gitlab, my user name is mariotomo.Sent from a Google-owned 华为 Mobile Original Message Subject: Re: WIP: Org-plot workFrom: TEC To: Bastien CC: org-mode-email ,Mario Frasca ,Eric Schulte Bastien writes:> Sure, please go ahead.Will do! :)> Great -- because I know Mario sh

Fwd: [patch] simplify-compact initial data extraction from plist

2020-07-12 Thread Mario Frasca
Anyone? Forwarded Message Subject:[patch] simplify-compact initial data extraction from plist Date: Sat, 27 Jun 2020 10:18:21 -0500 From: Mario Frasca To: emacs-orgmode@gnu.org this is a result of some help I received a few days ago in the #emacs irc chat

Re: empty/nil in table cells

2020-07-10 Thread Mario Frasca
On 09/07/2020 16:59, Nicolas Goaziou wrote: and it simplifies a lot writing functions. How so? thank you Michael, for answering Nicolas' question, in a different and much structured way than I did in my original message. the formula you provided —I reduced it slightly, hard coding a constan

Re: empty/nil in table cells

2020-07-09 Thread Mario Frasca
I think we really need a bug-tracking mechanism, you know? see attachment On 09/07/2020 16:59, Nicolas Goaziou wrote: Hello, Mario Frasca writes: I've been experimenting with associating the empty cell with the value nil, Where? both ways, What do you mean? and it simplifies

empty/nil in table cells

2020-07-09 Thread Mario Frasca
Hi people, I've been experimenting with associating the empty cell with the value nil, both ways, and it simplifies a lot writing functions. also, I've removed the error generation when reading from outside the table (instead of giving up with a user-error, I now get a nil). it works for me,

Re: [PATCH] allow for multiline headers

2020-07-04 Thread Mario Frasca
Hi Nicolas, On 04/07/2020 03:58, Nicolas Goaziou wrote: I'm sure this PLOT extension is useful. My point is that complexity should be moved to Org Babel, if possible, not into affiliated keywords. IOW, it would be nice if gnuplot source code blocks were as easy to use as your extension. I do

Re: bug: Row descriptor <...> leads outside table

2020-07-03 Thread Mario Frasca
:@2$3='(string)::@3$3='(string)::@4$3='(string)::@5$3='(string)::@6$3='(string)::@7$3='(string) On 03/07/2020 09:53, Mario Frasca wrote: hi again, I haven't found how to solve this, short of removing the evaluation of `user-error' from the org-table.el co

bug: Row descriptor <...> leads outside table

2020-07-03 Thread Mario Frasca
tor -6 leads outside table the third TBLFM line "solves" the problem, in one of the ugliestests ways. how would you people approach this? On 29/06/2020 12:03, Mario Frasca wrote: Hi, I need some help understanding how to use org-mode/org-table for references leading outside my tabl

Re: [PATCH] allow for multiline headers

2020-07-01 Thread Mario Frasca
Good morning Nicolas, On 01/07/2020 05:46, Nicolas Goaziou wrote: There are multiple ways to draw a diagram from a table. […] I didn't check but I think Org Plot predates Org Babel. It probably wouldn't exist otherwise. I'm happy it exists.  it has a very low entrance threshold, just use it

Re: [PATCH] allow for multiline headers

2020-06-29 Thread Mario Frasca
On 29/06/2020 13:36, Nicolas Goaziou wrote: IMO, Org Plot should be very basic, and complexity should go into Babel code blocks, which are more capable. IMO, we are keeping org-plot artificially basic.  But you know what?  I'm just happy with my additions, my point was to share them with the

question on user-error reference leading out of table

2020-06-29 Thread Mario Frasca
Hi, I need some help understanding how to use org-mode/org-table for references leading outside my table. I have a series of daily figures, and I am computing the series of running sums.  column one is the daily data, column two is the running sum of the preceding 14 values from column 1.

Re: [PATCH] allow for multiline headers

2020-06-29 Thread Mario Frasca
stly from the point of view of org-plot, I think this (separating the bottom "summary" line) would be useful (I had to remove the "country summary" bottom line from a demographics histogram table).  for sure, if I follow your hint to use gnuplot code and refer to the table,

Re: [PATCH] allow for multiline headers

2020-06-28 Thread Mario Frasca
On 28/06/2020 18:17, Nicolas Goaziou wrote: This could be extracted as an independent function, which would return the header, or nil. We can also imagine a function returning a cons cell (HEADER . BODY), both HEADER and BODY being list of rows (possibly empty). not only this … it could also be

[PATCH] partial rewrite of gnuplot-to-grid-data

2020-06-28 Thread Mario Frasca
according to me, this looks better, I'm curious about the reactions from the list. in particular, I was surprised finding a duplicated evaluation of (string-to-number (nth col (nth row table))) inside a (dotimes (col num-cols) (dotimes (row num-rows) …)) >From 9822748dfbdb99f1ea534e695e818d

Re: [bug] select TODO items and unexpected behaviour

2020-06-28 Thread Mario Frasca
On 28/06/2020 01:32, Kyle Meyer wrote: Thanks for reporting. Looks like org-todo's call to org-map-entries has been broken since its introduction in 7.8.05. Should be fixed with 8a2eb7d1b. 3ed035ce3 with this patch, you don't need to locally redefine the org-loop-over-headlines-in-active-reg

Re: [bug] select TODO items and unexpected behaviour

2020-06-28 Thread Mario Frasca
06/2020 01:32, Kyle Meyer wrote: Mario Frasca writes: this behaviour comes after somehow my `org-loop-over-headlines-in-active-region' became nil. Perhaps not the "somehow" but the default value of this option is different between the last release and master. It changed from nil

Re: [bug] select TODO items and unexpected behaviour

2020-06-27 Thread Mario Frasca
if I change those 'right and 'left, to :right and :left, the handling them over and over as symbols will not start confusing them as variables, and keep them as symbols. On 27/06/2020 16:43, Mario Frasca wrote: this behaviour comes after somehow my `org-loop-over-headlines-in-act

Re: [bug] select TODO items and unexpected behaviour

2020-06-27 Thread Mario Frasca
op-over-headlines-in-active-region' at the "inside-looping" setting.  just guessing. On 27/06/2020 16:16, Mario Frasca wrote: when I select subsequent TODO items, whole lines, and I do M-, they get demoted by one star, so something like * header * a1 * a2 * a3 * header after I hit M

[bug] select TODO items and unexpected behaviour

2020-06-27 Thread Mario Frasca
when I select subsequent TODO items, whole lines, and I do M-, they get demoted by one star, so something like * header * a1 * a2 * a3 * header after I hit M- will become * header ** a1 ** a2 ** a3 * header which is what I expected, even if I would not expect the region to be deactivated.

Re: [PATCH] allow for multiline headers

2020-06-27 Thread Mario Frasca
Hi Nicolas and the whole world, On 24/06/2020 02:19, Nicolas Goaziou wrote: This could be extracted as an independent function, which would return the header, or nil. We can also imagine a function returning a cons cell (HEADER . BODY), both HEADER and BODY being list of rows (possibly empty).

[patch] simplify-compact initial data extraction from plist

2020-06-27 Thread Mario Frasca
this is a result of some help I received a few days ago in the #emacs irc chat room on freenode. I was wondering why we were adding a semicolon in front of names, before creating symbols, and I understand this is because such symbols work as keys.  next, I could not find how we were taking adv

Re: [PATCH] may we focus on readability?

2020-06-16 Thread Mario Frasca
On 16/06/2020 11:56, Nicolas Goaziou wrote: what about waiting until bureaucracy is over? I'm fine with it, but I'm accumulating several adjustments, and it's being difficult to keep track of each of them separately. Of course, this assumes you're planning to sign FSF papers. I have signed

Re: [PATCH] may we focus on readability?

2020-06-15 Thread Mario Frasca
is o.k. see it yourself, when we have the agreement allowing you accept changes longer than 15 lines, I'll consider the needed refactoring and test-writing. ciao, Mario On 15/06/2020 09:49, Mario Frasca wrote: Hi Nicolas, I think that the hint on testing is very correct, I'm afraid

Re: [PATCH] may we focus on readability?

2020-06-15 Thread Mario Frasca
Hi Nicolas, I think that the hint on testing is very correct, I'm afraid I changed the semantics of one of the original tests, and I found that there's other cl functions other than just cl-some, also cl-every, cl-notevery, and cl-notany.  I'll have a closer look at this.  and write some tests

[PATCH] may we focus on readability?

2020-06-14 Thread Mario Frasca
I'm rewriting a complicated construction where there's an equality test on the length of the list of non matching elements, with a simpler cl-some invocation.  The replacing code is self explanatory. >From 918b0e7ba2db438cc9b81131317501b93a45b1d8 Mon Sep 17 00:00:00 2001 From: mfrasca Date: Sun,

Re: [PATCH] allow for multiline headers

2020-06-13 Thread Mario Frasca
Hi Nicolas, On 13/06/2020 17:18, Nicolas Goaziou wrote: Hello, Mario Frasca writes: I can leave existing loops in peace, or edit them keeping them cl-loop-free.  as for myself, I find it practical and readable. Then you'll enjoy reading, e.g., `org-contacts-try-completion-prefix'

Re: [PATCH] allow for multiline headers

2020-06-13 Thread Mario Frasca
what about these two groups of tests, and the header collapse function? >From ceb21024159a75dbdb9fef32eebe1fc8c7076d2f Mon Sep 17 00:00:00 2001 From: mfrasca Date: Fri, 12 Jun 2020 11:42:34 -0500 Subject: [PATCH] lisp/org-table.el: Allow collapsing header into single line * lisp/org-table.el (o

Re: [PATCH] allow for multiline headers

2020-06-13 Thread Mario Frasca
hi Nicolas, is there an agreement on cl-lib usage within the project?  I was hinted at cl-loop in this mailing list, and I liked it, in particular the `collect' clause, the destructuring feature, and less parentheses.  I had no exposure to cl-loop before the hint received here. I can leave e

[PATCH] allow for multiline headers

2020-06-12 Thread Mario Frasca
it misses unit tests, I need to make the collapse optional, and I need to hear from users what they think of it.  this patch allows me to write a table like the following, having a three-lines header: |  n | data | prove, |  casi, | ratio |   prove, |    casi, | |    |  | valore | valore | 

Re: issue tracker?

2020-06-07 Thread Mario Frasca
good day Bastien On 07/06/2020 04:38, Bastien wrote: anybody can 'vote-for' a bug, and you keep a counter on voted-for. It would require people to register on updates.orgmode.org. I'm not sure the expected benefit is really worth it for now. why would it?  you already trust email senders on i

Re: issue tracker?

2020-06-06 Thread Mario Frasca
Hi Bastien, The tool is experimental: if it proves useful, let's try to keep it, otherwise let's drop it: our main focus should be in recruiting new developers to help with the codebase. very interesting approach. sounds like you don't want to manage the status changes a bit tighter.  I know

Re: issue tracker?

2020-06-05 Thread Mario Frasca
On 02/06/2020 06:57, Bastien wrote: Please go ahead. Readhttps://orgmode.org/worg/org-contribute.html and submit your first patch following the rules we have for the commit messages (they are not easily understood for newcomers). After a few well-formatted useful patches, we can perhaps add you

Re: tables, positioning of `#+Plot:' lines

2020-06-05 Thread Mario Frasca
On 05/06/2020 15:08, Nicolas Goaziou wrote: Since TBLFM lines are the odd ones, the mistake was to allow them after the table, while every other affiliated keyword in the Org universe goes before the object it applies to. ah, I did not know that.  that's good.  and we don't want to correct tha

tables, positioning of `#+Plot:' lines

2020-06-05 Thread Mario Frasca
I was wondering about the position of the `#+plot:' lines.  we have a table, and if we want to have formulas, we put these in a `#+TBLFM:' line following the table.  the documentation of org-plot states that `#+PLOT:' lines are looked for: following, or preceding the table, but then only the "p

Re: a couple of items

2020-06-04 Thread Mario Frasca
hi.  thank you.  seeing hand written code in the target language is always useful, when writing a translator.  :+1:  :-) On 04/06/2020 06:53, Eric S Fraga wrote: On Wednesday, 3 Jun 2020 at 16:06, Mario Frasca wrote: consider this table, partially from the Wikipedia: If you are willing to

Re: `with` as a list.

2020-06-03 Thread Mario Frasca
On 03/06/2020 10:29, Bastien wrote: The few lines above is what we called the "changelog". It should be the first part of the commit message -- after which you can add more free-form context and explanations, if needed. this "Changelog", and I'm sure I am the stiffy one, isn't clear from the

a couple of items

2020-06-03 Thread Mario Frasca
consider this table, partially from the Wikipedia: #+PLOT: with:histogram ind:1 | Region |   Area | Production |Productivity | |    |  (Mha) |  (Mtonnes) |  (tonnes/ha) | |+++--| | Western Europe |  2.490 |  5.730 |    2.3012

Re: `with` as a list.

2020-06-03 Thread Mario Frasca
(let ((ind (1- (plist-get params :ind))) + (with (plist-get params :with))) (when (and (>= ind 0) (eq '2d (plist-get params :plot-type))) (if (= (length (delq 0 (mapcar @@ -320,7 +334,7 @@ line directly before or after the table." 0) (plist-put params

Re: `with` as a list.

2020-06-03 Thread Mario Frasca
On 03/06/2020 10:13, Bastien wrote: Also you need to sign the FSF copyright assignment if you want to make big changes like this one. yes, I received the ASSIGNMENT –GNU EMACS pdf last night, I'm now seeing how I print & sign it.  it might take some time.

Re: `with` as a list.

2020-06-03 Thread Mario Frasca
ing. ciao, Mario On 03/06/2020 10:13, Bastien wrote: Mario Frasca writes: see attachment Thanks for the effort -- the commit message is not correctly formatted though. See https://orgmode.org/worg/org-contribute.html#commit-messages and perhaps also read previous commit messages. Also yo

Re: [PATCH] some minimal refactoring for the sake of unit-testing, and a, couple of tests.

2020-06-03 Thread Mario Frasca
-get params :plot-type) (`2d (org-plot/gnuplot-to-data table data-file params)) diff --git a/testing/lisp/test-org-plot.el b/testing/lisp/test-org-plot.el new file mode 100644 index 0..b23075050 --- /dev/null +++ b/testing/lisp/test-org-plot.el @@ -0,0 +1,207 @@ +;;; test-org-plot.el --

Re: `with` as a list.

2020-06-03 Thread Mario Frasca
:ind))) + (with (plist-get params :with))) (when (and (>= ind 0) (eq '2d (plist-get params :plot-type))) (if (= (length (delq 0 (mapcar @@ -320,7 +334,7 @@ line directly before or after the table." 0) (plist-put params :timeind t) ;; Check for text ind col

Re: [PATCH] implementing `with' as a list, and respecting `deps' order.

2020-06-03 Thread Mario Frasca
nt to review the page yourself. the `#commit-messages' section is very clear, I had totally missed it.  sorry. I'm reviewing the commit message accordingly, and will reply to my initial message, attaching the new patch. ciao, MF On 02/06/2020 22:38, Kyle Mey

[PATCH] some minimal refactoring for the sake of unit-testing, and a, couple of tests.

2020-06-02 Thread Mario Frasca
params)) diff --git a/testing/lisp/test-org-plot.el b/testing/lisp/test-org-plot.el new file mode 100644 index 0..b23075050 --- /dev/null +++ b/testing/lisp/test-org-plot.el @@ -0,0 +1,207 @@ +;;; test-org-plot.el --- Tests for Org Plot library -*- lexical-binding: t; -*- + +;; Copyright (C)

[PATCH] docstrings to match the code, and minor cosmetics.

2020-06-02 Thread Mario Frasca
From 43cc6264deb89fcc665d123b06c7c2aebb35ab3a Mon Sep 17 00:00:00 2001 From: Mario Frasca Date: Tue, 2 Jun 2020 16:22:07 + Subject: [PATCH] docstrings to match the code, and minor cosmetics. ---  lisp/org-plot.el | 21 ++---  1 file changed, 14 insertions(+), 7 deletions

[PATCH] implementing `with' as a list, and respecting `deps' order.

2020-06-02 Thread Mario Frasca
From 436bfd0b9fd656f52ea9d7e6a6a665a32564ae93 Mon Sep 17 00:00:00 2001 From: Mario Frasca Date: Tue, 2 Jun 2020 15:46:20 + Subject: [PATCH] implementing `with' as a list, and respecting `deps' order. ---  doc/org-manual.org    |  7 ++--  lisp/org-plot.el

Re: issue tracker?

2020-06-01 Thread Mario Frasca
On 01/06/2020 10:53, Bastien wrote: Let us know what would help you contribute more. as mentioned, I would like to correct docstrings, refactor the code in a few points, and add unit tests. --- (defun org-plot/gnuplot-script (data-file num-cols params &optional preface)   "Write a gnuplot s

Re: issue tracker?

2020-06-01 Thread Mario Frasca
ao, best regards, MF On 01/06/2020 09:45, Bastien wrote: Hi Mario, Mario Frasca writes: myself, I recently posted a patch, received zero reaction, and have the impression it's now lost in the logs of this mailing list.  indeed pretty inefficient! Sorry for that. As others have ment

Re: `with` as a list.

2020-05-31 Thread Mario Frasca
On 31/05/2020 19:19, Kyle Meyer wrote: You've been sending a diff, presumably from the point you branched off of to the tip of your branch. In that case, you're already presenting each iteration you've sent as one change; it just lacks a commit message. right, that's indeed what I did, and this

Re: `with` as a list.

2020-05-31 Thread Mario Frasca
On 30/05/2020 16:29, Mario Frasca wrote: I hope to be back soon with a single commit... one doubt.  what's the point of having me squash all in a single commit, when I do not have write access to the repository?  if we were on github, I would be working on a pull request, which would h

Re: `with` as a list.

2020-05-30 Thread Mario Frasca
On 30/05/2020 15:25, Kyle Meyer wrote: Could you update this header to match the style used by other tests (see, e.g., test-org-num.el)? apparently, I managed to pick precisely the wrong example! ;;; test-org-clock.el --- Tests for org-clock.el

Re: `with` as a list.

2020-05-30 Thread Mario Frasca
oops .. you mentioned `cl-loop' and I found it interesting, in particular the de-structuring part. so I rewrote the (dolist (col-with …) …) as (cl-loop for (col . with) in … do …). so I could simplify `(car col-with)' and `(cdr col-with)', then I replaced the `do' with a `collect', so I coul

Re: `with` as a list.

2020-05-30 Thread Mario Frasca
(> (length (delq 0 (mapcar (lambda (el) diff --git a/testing/lisp/test-org-plot.el b/testing/lisp/test-org-plot.el new file mode 100644 index 0..2bbd09b5f --- /dev/null +++ b/testing/lisp/test-org-plot.el @@ -0,0 +1,50 @@ +;;; test-org-plot.el --- Tests for org-plot.el + +;; Cop

Re: `with` as a list.

2020-05-30 Thread Mario Frasca
On 30/05/2020 09:23, Mario Frasca wrote: The code above looks fine to me.  Another option would be to use number-sequence and then filter out the ind value. no, that would break functionality: I need to keep the given order. ah, no, sorry, you are totally right here.  I'll see if using n

Re: `with` as a list.

2020-05-30 Thread Mario Frasca
Hi Kyle, thank you for writing back, I have a couple of questions in reply. btw. are you on irc.freenode.net?  I'm `mariotomo' there.  and I just joined `#org-mode'.  I don't think that my terminal will ring a bell if I'm mentioned there. On 30/05/2020 01:22, Kyle M

[PATCH] [FEATURE] Re: `with` as a list.

2020-05-28 Thread Mario Frasca
t breaking what he wrote.  … I guess I can write also test cases for what already exists, but I will very likely need assistance. best regards, Mario Frasca On 22/05/2020 11:07, Mario Frasca wrote: good day to you all now and then I use emacs to make graphs.  now recently I was plotting point d

Re: issue tracker?

2020-05-27 Thread Mario Frasca
myself, I recently posted a patch, received zero reaction, and have the impression it's now lost in the logs of this mailing list.  indeed pretty inefficient! something which flashed to my mind while writing this email: we're dealing with an emacs software, part of emacs, can we just use M-x

`with` as a list.

2020-05-22 Thread Mario Frasca
ined test cases for the new behaviour, I'm willing to do that (learning the way this test environment works), but I don't find the location of the other tests related to the area of the program, which I'm tweaking. best regards all, Mario Frasca diff --git a/lisp/org-plot.el b/

Re: [O] better interaction with gnuplot-mode

2014-11-08 Thread Mario Frasca
On 11/04/2014 10:33 AM, Nicolas Goaziou wrote: > Mario Frasca writes: > >> being the comment in the subject field of an email, it can't be a >> multiline comment, can it? > > First line is a summary and cannot exceed 72 (or is it 68? I cannot > remember) char

[O] better interaction with gnuplot-mode

2014-11-02 Thread Mario Frasca
/ MF From be72bf875a9abd64869f1c0bd1c6ad50fa93e514 Mon Sep 17 00:00:00 2001 From: Mario Frasca Date: Sun, 2 Nov 2014 08:53:27 -0500 Subject: [PATCH 2/2] correct the callback for the and register it as soon as possible. --- lisp/org-plot.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[O] better interaction with gnuplot-mode

2014-11-02 Thread Mario Frasca
/ MF From be72bf875a9abd64869f1c0bd1c6ad50fa93e514 Mon Sep 17 00:00:00 2001 From: Mario Frasca Date: Sun, 2 Nov 2014 08:53:27 -0500 Subject: [PATCH 2/2] correct the callback for the and register it as soon as possible. --- lisp/org-plot.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions