Re: [O] Bug: org-babel-expand-noweb-references is very slow [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.3/lisp/org/)]

2019-10-14 Thread Nicolas Goaziou
gt; > <> > <> > <> > <> > #+end_src > > C-c C-v C-v is already very slow, takes ~15 seconds to resolve the references > (can be seen in the Emacs Profiler), even though the inclusion graph is > very simple. Please try a more recent version of Org. Release 9.1.9 is pretty old. It might be fixed already. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ob-ocaml: Support for pretty-printed outputs

2019-10-13 Thread Nicolas Goaziou
rom org-babel-ocaml-parse-output, from > org-babel-execute:ocaml, the code being modified. Since no-one commented your patch, I applied it. I added TINYCHANGE cookie at the end of the commit message, since I don't know if you signed the FSF papers already. Thank you for your contribution! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Document "help:" Org link type in manual

2019-10-13 Thread Nicolas Goaziou
Hello, Robert Irelan writes: > Patch attached Thank you. However, I couldn't apply your patch since manual changed quite a bit in this area not so long ago. I adapted your patch to the new structure and applied it. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-13 Thread Nicolas Goaziou
urce code lines should > be wrapped in code elements or not. > * doc/org-manual.org: Document the new option Applied. Would you mind adding an ORG-NEWS entry about it? Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug and quick bugfix

2019-10-13 Thread Nicolas Goaziou
) IIRC, the label has to be included in the caption command. I applied a different solution. Let me know if that works for you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-10 Thread Nicolas Goaziou
gesting. Once everything is in place, your ideas could be integrated as an alternate priority system within Org. In any case, I cannot help much you with this, as the time I can devote to Org is virtually non-existent these days. Hopefully, someone else can guide you, if necessary. Do not worry much about breaking code: do write tests! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-08 Thread Nicolas Goaziou
able. Any thoughts? I agree with the nil default value. > +(defcustom org-html-wrap-src-lines t > + "If t, wrap individual lines of source blocks in \"code\" elements. When non-nil, wrap... Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Another two small patches. Please merge the two patches and factor out the (- org-lowest-priority ...) while you're at it. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline)

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > * org.el (org-get-priority): Fix to allow the use of custom priority > getters. > Provide the headline as argument to the custom priority getter > function. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: org-publish-resolve-external-link doesn't respect org-export-with-broken-links for fuzzy links

2019-10-08 Thread Nicolas Goaziou
Hello, Robert Irelan writes: > Patch to fix attached Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

2019-10-08 Thread Nicolas Goaziou
g. It could mean, e.g., a string. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-latex.el: Extend :placement attribute to source blocks

2019-09-16 Thread Nicolas Goaziou
Hello, Mario Schlegel writes: > * lisp/ox-latex.el (org-latex-src-block): Extend :placement attribute > to source blocks when the minted package is used. Applied. Thank you! Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: Prevent loss of `re-search-forward' results

2019-09-16 Thread Nicolas Goaziou
Hello, Max Mouratov writes: > * org.el (org-activate-links): `match-beginning' and `match-end` should > be called shortly after `re-search-forward'. Otherwise, they may return > values corresponding to a different invocation of `re-search-forward'. Applied. Thank you! Regards, --

Re: [O] org-icalendar: Change dates to today in VEVENT export

2019-09-16 Thread Nicolas Goaziou
. I suggest to fix `org-timestamp-from-time' so that it matches `org-element-timestamp-parser' return value. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-macs: Fix indentation for fullwidth characters

2019-09-16 Thread Nicolas Goaziou
(let ((ind (1- (current-column > +(let ((ind (- (current-column) (char-width > (char-before) I used `current-indentation' instead. Thank you for the bug report, and the patch. Regards, -- Nicolas Goaziou

Re: [O] Patch: strip (unneeded) quotes from singular value results

2019-09-16 Thread Nicolas Goaziou
g-babel-strip-quotes result) Applied, after changing `org-babel-strip-quotes' to `org-strip-quotes'. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [RFC] Org document concept + document property drawers

2019-09-06 Thread Nicolas Goaziou
ng that? I think that if used correctly (i.e., not called too often), the overhead can be acceptable. In fact, by experience, this kind of function is hardly useful. I generally use Org Element higher up in functions, and can operate on the element with Org Element function without requesting another full parsing. YMMV. Regards, -- Nicolas Goaziou

Re: [O] Both italic and bold at the "edges": a bug?

2019-09-06 Thread Nicolas Goaziou
t in the > same place? They are allowed. Try exporting this document to, e.g., LaTeX. You may be talking about fontification, which is but an approximation of the real Org syntax (but it could be improved). Regards, -- Nicolas Goaziou

Re: [O] [Patch] Hide the file column in a clock report.

2019-09-05 Thread Nicolas Goaziou
Hello, Michaël Cadilhac writes: > Here attached. Let me know if that's all good! It is. Applied. Could you provide an ORG-NEWS entry? Thank you! Regards, -- Nicolas Goaziou

Re: [O] Completely hide the :PROPERTIES: drawer in org-mode.

2019-09-05 Thread Nicolas Goaziou
Hello, Michaël Cadilhac writes: > Apologies for the delay. > > Is that alright? It is. Applied. Thank you! Regards, -- Nicolas Goaziou

Re: [O] org-icalendar: Change dates to today in VEVENT export

2019-09-05 Thread Nicolas Goaziou
(nconc (list :year-start (nth 5 dt) > +:year-end (nth 5 dt) > +:month-start (nth 4 dt) > +:month-end (nth 4 dt) > +:day-start (nth 3 dt) > +:day-end (nth 3 dt)) This function already exists: `org-timestamp-from-time'. Could you use that instead? Othewise, LGTM. Regards, -- Nicolas Goaziou

Re: [O] Bug? SCHEDULED lines treated differently when text precedes them

2019-09-05 Thread Nicolas Goaziou
Christoph Groth writes: > I understand now that Org does what it should. However, I find this > behavior quite dangerous. It caught me after more than 10 years of > using Org. If there's a list of long-term issues with Org somewhere, > this problem may deserve being added to it. I don't

Re: [O] Bug: Language code for Brazilian in org-latex-babel-language-alist and org-latex-polyglossia-language-alist

2019-09-05 Thread Nicolas Goaziou
(This is so in > an up to date org-plus-contrib-20190904/ox-latex.el). Fixed, too! Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug? SCHEDULED lines treated differently when text precedes them

2019-09-05 Thread Nicolas Goaziou
Scheduling"). Elswhere, only the timestamp is meaningful to Org. Regards, -- Nicolas Goaziou

Re: [O] Bug: org-edit-src keeps splitting the window [9.2.5 (release_9.2.5-504-g3c24be @ /home/immanuel/.emacs.d/straight/build/org/)]

2019-09-03 Thread Nicolas Goaziou
Hello, Immanuel Litzroth writes: > You want me to do that and send a new patch or are you going > to do it after you apply the patch? The former, if you don't mind. Regards, -- Nicolas Goaziou

Re: [O] Bug: org-edit-src keeps splitting the window [9.2.5 (release_9.2.5-504-g3c24be @ /home/immanuel/.emacs.d/straight/build/org/)]

2019-09-02 Thread Nicolas Goaziou
existing window or split the current window. If BUFFER is current in a window, use it. Otherwise, split the current window, according to SPLIT-FUN, in order to display it. Also, I think this should be notified in ORG-NEWS file. Thank you! Regards, -- Nicolas Goaziou

Re: [O] [RFC] Org document concept + document property drawers

2019-09-01 Thread Nicolas Goaziou
-keyword-regexp))) While this is technically correct today, please don't write a predicate only based on regexps, use the parser for that. For example, the parser can understand #+begin_example #+keyword: not a keyword #+end_example whereas your function cannot. Also, you could use `org-match-line' in this case. Regards, -- Nicolas Goaziou

Re: [O] Bug: tangling with elisp as lang in a noweb reference doesn't work [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/local/share/emacs/26.2/lisp/org/)]

2019-08-30 Thread Nicolas Goaziou
lambda (text) > (with-temp-buffer > (funcall (intern (concat lang "-mode"))) > ... > #+END_SRC Fixed! Thank you for the report and the analysis. Regards, -- Nicolas Goaziou

Re: [O] Fold headline from inside of body?

2019-08-27 Thread Nicolas Goaziou
ant to avoid folding > the entire document). Well, `C-c C-p TAB' does that. :) You can bind it to something else if you absolutely need to make it shorter. Regards, -- Nicolas Goaziou

Re: [O] [bug] Export to latex truncates long subsections (WE attached)

2019-08-26 Thread Nicolas Goaziou
working example is attached to this email. The LaTeX code generated by Org looks correct. I tried to remove all \label{...}, all \href{...} from the ".tex" file, but the problem is still the same. It may be a LaTeX issue, not an Org one. You may want to investigate in this direction. HTH, Regards, -- Nicolas Goaziou

Re: [O] Bug: org-babel-tangle-comment-links does not start-line but start-point. [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/local/share/emacs/26.2/lisp/org/)]

2019-08-24 Thread Nicolas Goaziou
12 > (progn > ;; start 15 > (message "start") > ;; end 15 > ;; start 90 > (message "end") > ;; end 90 > ) > ;; end 12 > #+end_example Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug header argumednt :file does not produce a file or a link to the file

2019-08-23 Thread Nicolas Goaziou
~:file~ header argument no longer assume "file" ~:results~ Regards, -- Nicolas Goaziou

Re: [O] Org mode pollutes the narrow-map

2019-08-23 Thread Nicolas Goaziou
gt; I think it would be better to bind them (to C-x n s, C-x n b and C-x > n e) in org-mode-map. This is the approach taken by AUCTeX, for > example. (To be clear, I mean AUCTeX has some narrowing commands and > it binds them to C-x n e and C-x n g in its own keymaps.) It sounds reasonable. I changed the bindings in master. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug header argumednt :file does not produce a file or a link to the file

2019-08-23 Thread Nicolas Goaziou
2. A link to that file is placed below the source code block > > Instead all I get is a table and no external file is created You probably need to specify that the output is a file, which is not the default for "sh" language. You may want to add ":results file" to the header of the source block. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Fixing org-store-link for eshell

2019-08-22 Thread Nicolas Goaziou
' to silence compilation warning. Thank you! Regards, -- Nicolas Goaziou

Re: [O] org-babel-insert-result doesn't comma escape properly

2019-08-22 Thread Nicolas Goaziou
uld handle this > properly. And trying that on the above ECM gives the right result. But then, another regression tests fail. > I do not see why it was needed. I think it was to store the location of the inner part of the block. Regards, -- Nicolas Goaziou

Re: [O] Bug: org-babel-tangle-file [9.2.4 (9.2.4-3-g7bc6f8-elpaplus @ /home/stettberger/.emacs.d/elpa/org-plus-contrib-20190701/)]

2019-08-22 Thread Nicolas Goaziou
Hello, Christian Dietrich writes: > I think a found a bug in org-babel-tangle-file. It closes an user-opened > buffer if called with a symlink that points to the same file. Please see > the attached patch, which fixes the problem for me. Applied. Thank you! Regards, -- Nicolas Goaziou

Re: [O] CUSTOM_ID vs ID

2019-08-18 Thread Nicolas Goaziou
user-labels'. HTML could use a similar mechanism but no one bothered implementing it yet. In any case, Org provides a robust default solution. I think it is a reasonable expectation as a default. Regards, -- Nicolas Goaziou

Re: [O] CUSTOM_ID vs ID

2019-08-18 Thread Nicolas Goaziou
Hello, Jorge P. de Morais Neto writes: > But why does Org not use the dedicated target text as an anchor? That's because the text could contain anything, including invalid HTML characters. So we normalize them using only alphanum characters. Regards, -- Nicolas Goaziou

Re: [O] Org syntax inside verbatim/literal blocks

2019-08-17 Thread Nicolas Goaziou
Štěpán Němec writes: > Hm, but the version in my patch does seem to work correctly, i.e. it is > exported as (snipped) > > You need to exit by pressing @kbd{C-c '} again@footnote{@cindex escape > character > @cindex comma > Upon exit, lines starting with @samp{*}, @samp{,*}, @samp{#+} and

Re: [O] Asynchronous session evaluation

2019-08-17 Thread Nicolas Goaziou
number of supported languages over time. This sound interesting. I hope this is not going to bit-rot while we're waiting for feedback. If you think this is stable enough, however, you could simply integrate in the master branch after Org 9.3 release. It would require an entry in ORG-NEWS, though. WDYT? Regards, -- Nicolas Goaziou

Re: [O] BUG (smallish) The exemple of the documentation of the LaTeX LANGUAGE option is incorrect

2019-08-17 Thread Nicolas Goaziou
t; "lualatex"))) > #+end_src > > #+end_example > > i. e.: > * The name of the list has to be quoted. > * The exact list name has as "s" after "package". > * I'd give a full ~emacs-lisp~ snippet (but I agree that this is > disputable...). Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] patch: adding split-window-right option for src block editing

2019-08-17 Thread Nicolas Goaziou
Hello, "Fraga, Eric" writes: > Please find attached two patch files, both the one I have already sent > and now one with a change to the NEWS file. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Org syntax inside verbatim/literal blocks

2019-08-17 Thread Nicolas Goaziou
le with @cindex commands. Regards, -- Nicolas Goaziou

Re: [O] Org syntax inside verbatim/literal blocks

2019-08-15 Thread Nicolas Goaziou
m section 16.3 (Escape Character). Certainly. Would you want to provide a patch to the manual? Regards, -- Nicolas Goaziou

Re: [O] Bug: Language code for Brazilian in org-latex-babel-language-alist and org-latex-polyglossia-language-alist

2019-08-15 Thread Nicolas Goaziou
uese is a variant. > That to say that I’ve never seen the language code "bt-br" to refer to > "brazilian", whereas the usual code is "pt-br" (hyphen or underscore). > So this looks very much like a typo. Fixed. Thank you! Regards, -- Nicolas Goaziou

Re: [O] Org syntax inside verbatim/literal blocks

2019-08-09 Thread Nicolas Goaziou
ppend", which is usually > used in the sense of "add to the end", though). > > But all I could find in the manual regarding "verbatim", "escaping" etc. > are sections 12.2 and 16.3, neither of which mentions comma. See "Literal Examples" section, fourth footnote. Regards, -- Nicolas Goaziou

Re: [O] Issue with internal links

2019-08-08 Thread Nicolas Goaziou
tions'. Regards, -- Nicolas Goaziou

Re: [O] Latex single dollar math delimiter question

2019-08-05 Thread Nicolas Goaziou
://orgmode.org/worg/dev/org-syntax.html#Entities_and_LaTeX_Fragments I don't know if there's a way to express it in a non-boring way in the manual. Regards, -- Nicolas Goaziou

Re: [O] CUSTOM_ID vs ID

2019-07-29 Thread Nicolas Goaziou
defeats the intended purpose. Regards, -- Nicolas Goaziou

Re: [O] CUSTOM_ID vs ID

2019-07-28 Thread Nicolas Goaziou
ld I ever have both an ID and a CUSTOM_ID property for > a heading? You may want to refer to a heading from anywhere with id:... but need a clean anchor in HTML export, for example. FWIW, I never use ID property. Regards, -- Nicolas Goaziou

Re: [O] org-store-link stores spaces as "%20"

2019-07-17 Thread Nicolas Goaziou
Hello, Wolfram Volpi writes: > org-store-link stores spaces in links as "%20". > Like this:  [[file:../home.org::target%20A]] FWIW, I cannot reproduce it. You may need to upgrade Org. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ox-rss: Fix typos

2019-07-16 Thread Nicolas Goaziou
Hello, Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Cross reference in TeXinfo export

2019-07-15 Thread Nicolas Goaziou
e @ref{Top,comprehensive Org mode manual,,org,comprehensive Org mode manual} instead. But what should we do when a section is specified, e.g., @ref{Section Name, description,,org,} ? Regards, -- Nicolas Goaziou

Re: [O] patch: adding split-window-right option for src block editing

2019-07-15 Thread Nicolas Goaziou
cessary for Org for the time being. Regards, -- Nicolas Goaziou

Re: [O] Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]

2019-07-14 Thread Nicolas Goaziou
Hello, Marcin Borkowski writes: > Thanks. How about this? Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] BEGIN - END markers in manual and guide

2019-07-14 Thread Nicolas Goaziou
Therefore, I do not object to this change, but I do think it is not necessary. Regards, -- Nicolas Goaziou

Re: [O] Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]

2019-07-12 Thread Nicolas Goaziou
Hello, Marcin Borkowski writes: > Thanks. I meant that - according to the manual - `t' should be > synonymous with `near' and not `all'. I can fix the commit message, but > could you confirm that I'm right first? AFAICT, your guess sounds right. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Export with verbatim LaTeX removes spaces

2019-07-09 Thread Nicolas Goaziou
see below. I applied a variant of your patch. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]

2019-07-09 Thread Nicolas Goaziou
Hello, Marcin Borkowski writes: > Hello there, > > any comments? Thank you for the patches. I applied the first one. Could you expound the commit message in the second one: what bug is it? Regards, -- Nicolas Goaziou

Re: [O] [RFC] Link-type for attachments, more attach options

2019-07-09 Thread Nicolas Goaziou
"Attachments" have no description. The should have one, unless they are not meant to appear in the toc, in which case, you should set "UNNUMBERED" property to "notoc". Regards, -- Nicolas Goaziou

Re: [O] Bug: Plain list indentation on 'org-indent-item' with 'org-list-demote-modify-bullet' [9.2.4 (9.2.4-3-g7bc6f8-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20190701/)]

2019-07-09 Thread Nicolas Goaziou
bar baz bar baz bar baz bar baz bar baz bar baz bar baz bar baz bar baz >bar baz bar baz bar baz bar baz bar baz bar baz bar baz bar baz bar baz >bar baz bar baz bar baz > >#+begin_src emacs-lisp >(+ 1 1) >#+end_src > > >#+RESULTS: >: 2 > #+end_verbatim Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: org manual 15.10.2 Packages that conflict with Org mode doesn't include EDE [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.2/lisp/org/)]

2019-07-07 Thread Nicolas Goaziou
You may be exaggerating a little bit. Well. Feel free to provide an entry in "Conflicts", then. Thank you! Regards, -- Nicolas Goaziou

Re: [O] [RFC] Link-type for attachments, more attach options

2019-07-06 Thread Nicolas Goaziou
t; > + (expand-file-name > + (funcall org-attach-id-to-path-function id) > + (expand-file-name org-attach-id-dir))) Creates path -> Return a file name. > +of the entry. Creates relative links if `org-attach-dir-relative' > +is t. Nitpick: is t -> is non-nil. If tests pass, feel free to apply the patches in master. Thank you! Regards, -- Nicolas Goaziou

Re: [O] Bug: org manual 15.10.2 Packages that conflict with Org mode doesn't include EDE [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.2/lisp/org/)]

2019-07-06 Thread Nicolas Goaziou
an entry in the "Conflicts" section. It's true that Org shouldn't have used `C-c .` and `C-c !` in the first place, but that ship sailed long ago. Regards, -- Nicolas Goaziou

Re: [O] Bug: babel-plantuml doesn't support multipage diagrams [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/share/emacs/26.2/lisp/org/)]

2019-07-06 Thread Nicolas Goaziou
> #+end_src > > PlantUML supports generating multipage documents as of version 1.2019.6, > but I didn't find how to show all pages (two in my case) in an org > buffer. I don't know PlantUML, so you are in better position for providing a patch :) Regards, -- Nicolas Goaziou

Re: [O] Org Version 9.2.4 Insert Template at Point Doesn't Respect :empty-lines Property

2019-07-06 Thread Nicolas Goaziou
(file+headline "~/org/gtd.org" "Tasks") >"* TODO %?\n %i\n %a" :empty-lines 2) > ("j" "Journal" entry (file+datetree "~/org/journal.org") >"* %?\nEntered on %U\n %i\n %a"))) > > And received

Re: [O] Bug: org-agenda-list attempts to add text properties to agenda header even if org-agenda-overriding-header is set to "" [9.2.4 (release_9.2.4-386-gb855ac @ /home/nick/elisp/org-mode/lisp/)]

2019-07-06 Thread Nicolas Goaziou
Hello, Nick Dokos writes: > Evaluate the following form: > > (let ((org-agenda-overriding-header "")) (org-agenda-list)) > > It fails with > > org-agenda-list: Args out of range: 0, 1 Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] doc: Corrected typo, Java script -> JavaScript

2019-06-22 Thread Nicolas Goaziou
Hello, Rovanion Luckey writes: > - a Java script for displaying webpages derived from Org using an > + a JavaScript for displaying webpages derived from Org using an Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: Docstrings of =org-agenda-todo-ignore-with-date= and =org-agenda-todo-ignore-timestamp= unclear [9.2 (release_9.2-215-g5b39d8 @ /home/mbork/others-works/emacs/org-mode/lisp/)]

2019-06-19 Thread Nicolas Goaziou
If this is enough, I'd be happy to > submit a patch. If so, what would be better: to patch only the > docstrings or the docstrings and the manual. I would say the latter. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: Org-habit: org-log-note-headings configuration is not processed [9.2.3 (9.2.3-11-g42abf5-elpaplus @ /home/pyro/.emacs.d/elpa/26.2/develop/org-plus-contrib-20190429/)]

2019-06-19 Thread Nicolas Goaziou
to parse logbook records, and it must be picky about the syntax. I.e., we cannot allow any string. In a nutshell, this is unlikely to be fixed. Regards, -- Nicolas Goaziou

Re: [O] How can I customize ID names in html?

2019-06-19 Thread Nicolas Goaziou
Hello, buybuy...@yahoo.co.jp writes: > How can I customize id names in html? [...] > I would like to generate the prefix of ID names to be xyz instead of org. > How can I customize id names (ex. orgccfde4a)? You cannot customize those, but you can use CUSTOM_ID property. HTH, --

Re: [O] org-entry-get backward incompatibility. Bug or feature?

2019-06-19 Thread Nicolas Goaziou
expected to return the full value, which is a timestamp. Timestamps include brackets. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Feature proposal : support "scale=" includegraphics option in the builtin latex exporter.

2019-06-16 Thread Nicolas Goaziou
he may know. Regards, -- Nicolas Goaziou

Re: [O] [RFC] Link-type for attachments, more attach options

2019-06-15 Thread Nicolas Goaziou
+ (car files) > +(completing-read "Open attachment: " > + (mapcar #'list files) nil t))) I think a `pcase' is warranted here: (pcase (org-attach-file-list attach-dir) (`(,file) file) (files (completing-read ...))) > +(path (expand-file-name file attach-dir))) > + (run-hook-with-args 'org-attach-open-hook path) > + (org-open-file path in-emacs)) > + (error "No attachment directory exist." Ahem. :) > diff --git a/testing/examples/att1/fileA b/testing/examples/att1/fileA Would it be possible to use `org-test-with-temp-text-in file instead of creating files? > +(ert-deftest test-org-attach/dir () > + "Test `org-attach-get' specifications." > + (org-test-in-example-file org-test-attachments-file > +;; Link inside H1 > +(org-next-link) > +(save-excursion > + (org-open-at-point) > + (should (equal "Text in fileA\n" (buffer-string Please move `should' in the outermost part of the sexp, if possible. It makes debugging easier (i.e., evaluating the sexp without getting `should' in the way). I probably missed a few things, but it keeps the ball rolling. Thank you again for all the hard work. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-clock.el: Clear org-clock-current-task on clock cancel

2019-06-15 Thread Nicolas Goaziou
earing the variable incorrectly > displays the previous task as ongoing. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [ISSUE] source block coderef link does not work when not under same headline

2019-06-15 Thread Nicolas Goaziou
llows me to navigate back to the source block from any of these links. Regards, -- Nicolas Goaziou

Re: [O] Capture with date prompt defaults to yesterday

2019-06-10 Thread Nicolas Goaziou
could refactor the code around where org-get-cursor-date > is used to make it more explicit when the time of day doesn't matter, and > look further if there are any cases where it does. I think the current state is sufficient. Regards, -- Nicolas Goaziou

Re: [O] org-element discovered inconsistensies

2019-06-10 Thread Nicolas Goaziou
erty Drawer, Sections and Headlines are missing from > this list I added property drawers, sections and headlines. However, paragraphs can have affiliated keywords. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: org-list-make-subtree produces incorrect level [9.2.3 (9.2.3-20-g31873e-elpaplus @ /home/felix/.emacs.d/elpa/org-plus-contrib-20190527/)]

2019-06-09 Thread Nicolas Goaziou
* L1 > ** List Item > > *** L3 > > I think I also observed a case where the resulting level was 2 instead > of 4, so the other way round, but unfortunately I cannot reproduce it. I think this is now fixed in master. Thank you. Regards, -- Nicolas Goaziou

Re: [O] org-element discovered inconsistensies

2019-06-08 Thread Nicolas Goaziou
Hello, ihor writes: > So these are things that I have discovered so far: [...] I think I fixed the issues you pointed out. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] * doc/org-manual.org (External Links): Fix URL

2019-06-07 Thread Nicolas Goaziou
> | > | =/home/dominik/images/jupiter.jpg=| same as > above | Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Manual update

2019-06-07 Thread Nicolas Goaziou
rg-id-link-to-org-use-id', which is changed in v7.9.2. IIRC, I think this patch was applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Capture with date prompt defaults to yesterday

2019-06-07 Thread Nicolas Goaziou
should be midnight. So the fix probably lies elsewhere. (Also, not the "important" section in `org-extend-today-until'). Regards, -- Nicolas Goaziou

Re: [O] PATCHES: Wrap code in , add an attribute for line number value

2019-06-07 Thread Nicolas Goaziou
Hello, Nik Clayton writes: > Attached are two TINYCHANGE patches that provide an alternative way of > displaying line numbers in generated HTML output. Applied. Thank you. Could you also provide an entry in ORG-NEWS? Regards, -- Nicolas Goaziou

Re: [O] Bug report: The link in the CDLaTeX section of the manual (11.5.3) is dead

2019-06-05 Thread Nicolas Goaziou
ository containing > the latest version of the library I chose the former. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: Inaccurate doc-string for org-image-actual-width [9.2.3 (9.2.3-17-g4df705-elpaplus @ /home/yantar92/.emacs.d/elpa/org-plus-contrib-20190513/)]

2019-06-05 Thread Nicolas Goaziou
uot;^[ \t]*#\\+attr_.*?: +.*?:width +\\(\\S-+\\)" > (org-element-property :post-affiliated paragraph) > t) > > If case-fold-search is set to 't, and the value of > org-image-actual-width is set to a list, #+ATTR_ORG: :width > specifications are always ignored, while they should not

Re: [O] Proposal for new document-level syntax

2019-06-03 Thread Nicolas Goaziou
improvement. What would you be able to do with properties drawers that you cannot do currently with regular keywords? This is a genuine question: I don't want to turn down your suggestion, but I think it entails a lot of changes, and I want to be sure there is a real benefit to it. Regards, -- Nicolas Goaziou

Re: [O] org-drill futures

2019-06-02 Thread Nicolas Goaziou
llord/org-drill/ > > I'd like to have this be the version that ends up in contrib. Can anyone > tell me how to achieve this? I would suggest the opposite: move it to GNU ELPA, for example, so we can remove it from contrib. WDYT? Regards, -- Nicolas Goaziou

Re: [O] Proposal for new document-level syntax

2019-06-01 Thread Nicolas Goaziou
e in the document. I think Org keywords already provide everything you need. If they don't, I would suggest to improve them instead of creating something else. WDYT? Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add :target option for the TOC keyword

2019-05-31 Thread Nicolas Goaziou
The latter is fine. I applied you patch. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Vertical bars in org file break export to ics

2019-05-30 Thread Nicolas Goaziou
Unicode code point > 0xFFE4 FULLWIDTH BROKEN BAR looks similar. Or use ": ", i.e., fixed-width area, or \vert as the first bar. Regards, -- Nicolas Goaziou

Re: [O] A recent fix caused other face highlighting issue

2019-05-30 Thread Nicolas Goaziou
her solution? I reverted the commit. I Cc'ed Kévin, as the author of the patch. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-clock.el: Fix restore of frame-title-format

2019-05-28 Thread Nicolas Goaziou
rg-clock-cancel): Use it. > > The problem was that the `org-frame-title-format-backup' variable is > initialized on org-clock.el loading and future changes to `frame-title-format' > is ignored. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Docstring update

2019-05-28 Thread Nicolas Goaziou
Hello, "Cheong Yiu Fung" writes: > Fix docstring of `org-latex-packages-alist'. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org-clock-out overrides frame-title-format [9.2.3 (9.2.3-17-g4df705-elpa @ ~/.emacs.d/elpa/org-20190513/)]

2019-05-28 Thread Nicolas Goaziou
uld be factored out a bit, for example creating a simple function taking care of updating `frame-title-format' if needed. Also, could you provide a proper commit message and use git format-patch to send it again? Regards, -- Nicolas Goaziou

Re: [O] manual errata

2019-05-28 Thread Nicolas Goaziou
Hello, Ian Garmaise writes: > org 9.2 pdf manual > > In Chapter 8, p. 78 > > function org-mark-entry-for-agenda action > C-c C-x C-k > > This function doesn't exist in my version of org-mode (9.2.3) I cannot find any reference to this function in current manual. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add :target option for the TOC keyword

2019-05-21 Thread Nicolas Goaziou
of tests, we usually don't write tests for export back-ends, so you can drop them. Could you send an updated patch? Regards, -- Nicolas Goaziou

Re: [O] switch off validate - how?

2019-05-21 Thread Nicolas Goaziou
| <<<<<<<<<<< this should disappear. > | > ` Fixed. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Ruby tests

2019-05-16 Thread Nicolas Goaziou
tributors with commit rights. I pushed your fixes. Thank you. Regards, -- Nicolas Goaziou

  1   2   3   4   5   6   7   8   9   10   >