[O] bug#35419: [Proposal] Buffer Lenses and the Case of Org-Mode (also, Jupyter)

2019-04-24 Thread Noam Postavsky
Dmitrii Korobeinikov  writes:

> * Implementation
>
>   I am not familiar with Emacs internals to say what's feasible of the
> proposed structure.

Have you looked at Phil Lord's lentic package?  I think it implements a
lot of what you're talking about.

https://github.com/phillord/lentic





[O] bug#18617: bug#18617: 24.3; loading simple-wiki-mode breaks org-mode

2017-11-28 Thread Noam Postavsky
# not an Emacs bug
tags 18617 notabug
close 18617
quit

Kaushal Modi  writes:

> A quick look at the code shows that it pollutes the namespace with
> undeclared and un-let-bound variables like "tag" (and there could be
> more like that).
>
> If we investigate further, we might find a culprit like that that's
> causing this problem.

Looks like this is a bug in simple-wiki-mode, not in Emacs.





Re: [O] Fontification error

2017-03-19 Thread Noam Postavsky
On Sun, Mar 19, 2017 at 1:05 PM, Kyle Meyer <k...@kyleam.com> wrote:
>>
>> * lisp/org-src.el (org-src-font-lock-fontify-block): Let-bind
>> `inhibit-modification-hooks' to nil, since this function can be called
>> from jit-lock-function which binds that variable to t (Bug#25132).
>>
>> Call modification hooks in org-src fontify buffers
>> ae8264c5cccf19d5b25a340a605bf2f07de1577e
>> Noam Postavsky
>> Sun Jan 29 11:01:32 2017 -0500
>>
>> At the moment, the minimum ECM I know of is to install spacemacs and
>> open an org file containing:
>
> [+cc Noam because I'm not sure if he follows this list.]

[Thanks, I don't follow this list indeed]

>
> I backported this commit to the Org repo, but I don't have any good
> guesses at what's leading to the error below.

I think the problem is that the let-binding's scope is too big, it's
applying to a text property change on the original org buffer, which
seems to cause problems with one of its modifcation hooks due to
narrowing. Actually, I initially posted the patch with a smaller
binding, but then enlarged it before I pushed it; I don't remember
why...

Could someone who can reproduce this problem try shrinking the scope
of (let ((inhibit-modification-hooks nil))...) to stop after the
(insert " ") as in [1], and see if that fixes it?

[1]: 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25132;att=3;filename=v1-0001-Call-modification-hooks-in-org-src-fontify-buffer.patch;msg=22



[O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template ā€˜gā€™: Match data clobbered by buffer modification hooks)

2016-07-26 Thread Noam Postavsky
On Wed, Jul 20, 2016 at 9:47 PM, Stefan Monnier
 wrote:

> - maybe we can even adjust_match_data in every call to replace_range
>   rather than just in the one from Freplace_match.

That would be simpler, though I wasn't sure if it would be correct.