bug#38599: 27.0.50; org-agenda lists invalid Diary entries

2019-12-28 Thread Thomas Fitzsimmons
Hi,

Thomas Fitzsimmons  writes:

[...]

> Justin confirmed the attached patch fixes the problem for him.  Can an
> Org mode maintainer review it?

I also reported this upstream to the Org maintainers and they accepted
the fix.  Org 9.3.1, which contains the fix, has been released.  You can
install it from GNU ELPA.  I'm marking this bug as done.

Thomas





Re: Fix time regexp in org-get-entries-from-diary

2019-12-23 Thread Thomas Fitzsimmons
Hi Nicolas,

Nicolas Goaziou  writes:

> Hello,
>
> Thomas Fitzsimmons  writes:
>
>> I filed a bug report in Emacs debbugs, but probably should have sent it
>> here instead:
>>
>>http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599
>>
>> The attached patch appears to fix the bug.  Does it look OK?
>
> Applied. Thank you.

Thanks.

> I added your name to the list of contributors who haven't signed FSF
> papers. Please let me know if you did so I can update your status.

I have signed FSF papers for contributions to GNU Emacs.

Thomas



Fix time regexp in org-get-entries-from-diary

2019-12-19 Thread Thomas Fitzsimmons
Dear Org developers,

I filed a bug report in Emacs debbugs, but probably should have sent it
here instead:

   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599

The attached patch appears to fix the bug.  Does it look OK?

Thanks,
Thomas

>From 6102f07d61ee5d128701b7d3799b2e278aa79248 Mon Sep 17 00:00:00 2001
From: Thomas Fitzsimmons 
Date: Sun, 15 Dec 2019 12:20:05 -0500
Subject: [PATCH] Fix time regexp in org-get-entries-from-diary

* lisp/org-agenda.el (org-get-entries-from-diary): Make time regular
expression more precise.

Reported-by: Justin Abrahms 
---
 lisp/org-agenda.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 6391e0e9c..f07c86b9a 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5135,6 +5135,7 @@ (defun org-get-entries-from-diary (date)
 	  (cons 'org-diary-default-entry diary-list-entries-hook))
 	 (diary-file-name-prefix nil) ; turn this feature off
 	 (diary-modify-entry-list-string-function 'org-modify-diary-entry-string)
+	 (diary-time-regexp (concat "^" diary-time-regexp))
 	 entries
 	 (org-disable-agenda-to-diary t))
 (save-excursion
-- 
2.24.1



[O] bug#23765: 24.5; exco-calendar-show-day calls user-error if org-startup-with-latex-preview

2016-06-21 Thread Thomas Fitzsimmons
Hi Brian,

"Brian T. Sniffen"  writes:

> With org-startup-with-latex-preview set to non-nil, M-x excorporate, work
> through autoconfiguration, then M-x calendar.  Hit 'e'.  Get told
> "user-error: Can't preview LaTeX fragment in a non-file buffer".
>
> Unset org-startup-with-latex-preview, then go back to calendar and hit
> 'e'.  See pretty org-mode calendar.

Thanks for the report.  I just pushed a fix, in Excorporate 0.7.4.  It
should hit GNU ELPA overnight.  Can you update and confirm it fixes the
bug?

Thanks,
Thomas





[O] bug#23765: 24.5; exco-calendar-show-day calls user-error if org-startup-with-latex-preview

2016-06-21 Thread Thomas Fitzsimmons
"Sniffen, Brian" <bsnif...@akamai.com> writes:

> ˘
>> On Jun 14, 2016, at 10:24 PM, Thomas Fitzsimmons <fitz...@fitzsim.org> wrote:
>> 
>> Hi Brian,
>> 
>> "Brian T. Sniffen" <bsnif...@akamai.com> writes:
>> 
>>> With org-startup-with-latex-preview set to non-nil, M-x excorporate, work
>>> through autoconfiguration, then M-x calendar.  Hit 'e'.  Get told
>>> "user-error: Can't preview LaTeX fragment in a non-file buffer".
>>> 
>>> Unset org-startup-with-latex-preview, then go back to calendar and hit
>>> 'e'.  See pretty org-mode calendar.
>> 
>> Thanks for the report.  I just pushed a fix, in Excorporate 0.7.4.  It
>> should hit GNU ELPA overnight.  Can you update and confirm it fixes the
>> bug?
>
> That works.

I noticed that with the fix, C-x s (save-some-buffers) always prompts
about *Excorporate*.  I pushed 0.7.5 to prevent that (while still fixing
your issue).  I'm marking this bug report as "done".

> Thanks for the great software; I’m excited about having one command to
> predict where I am, get the invitees, tell my phone to dial in, and
> give me a buffer for notes.

Sounds good; a feature I have planned (retrieve message body) should
help with some of these.

Thomas