Re: [O] [BUG] Tag selection is inconsistent when loaded from #+SETUPFILE in orgmode 8.0.x

2013-07-03 Thread Bastien
Hi Anupam,

Anupam Sengupta anupa...@gmail.com writes:

 Thanks a lot for the fix.  The test files are now behaving properly
 after the fix (I am on orgmode git development head at commit
 36848fdec9eb8c9c17a2e98cd742af1f9f9b23db as on 23rd May).

 *However*, while testing this fix, I think I have uncovered a few more bugs(?)
 with the +SETUPFILE interaction with the in-buffer tag selection.

 Specifically, if the +SETUPFILE contains /any/ of the following
 directives (not exhaustive, just what my setup happened to have), then
 the tag listing in the completion buffer is showing _duplicated lists_
 of the tags read from the setup file:

I finally fixed this.  Thanks,

-- 
 Bastien



Re: [O] [BUG] Tag selection is inconsistent when loaded from #+SETUPFILE in orgmode 8.0.x

2013-05-23 Thread Anupam Sengupta

Hi Bastien,


 Loading tags from a #+SETUPFILE is causing inconsistent behavior
 in the tag-selection for both in-buffer selection via C-c C-q
 (`org-set-tags-command`) and in-agenda selection via :
 (`org-agenda-set-tags`).

Bastien Thanks a lot for reporting this and for the test case, it
Bastien should be fixed now.

Bastien All: the fix involves checking for a #+setupfile directive
Bastien when processing Org buffers for building the agenda.  This
Bastien may lead to some slow down when your agenda is built from
Bastien many files.  Let me know if you notice some weirdness.

Thanks a lot for the fix.  The test files are now behaving properly
after the fix (I am on orgmode git development head at commit
36848fdec9eb8c9c17a2e98cd742af1f9f9b23db as on 23rd May).

*However*, while testing this fix, I think I have uncovered a few more bugs(?)
with the +SETUPFILE interaction with the in-buffer tag selection.

Specifically, if the +SETUPFILE contains /any/ of the following
directives (not exhaustive, just what my setup happened to have), then
the tag listing in the completion buffer is showing _duplicated lists_
of the tags read from the setup file:

+STARTUP
+OPTIONS
+TYP_TODO
+CHOOSE_TODO

I have expanded the test case to include this scenario:

The setup file
==
##+STARTUP: align

##+OPTIONS: timestamp:t
##+TYP_TODO: TODO(t) DELEGATED(l!) | DONE(d)
##+CHOOSE_TODO: NO(,-) YES(,0)

#+TAGS: { @work(w) @home(h) }

The test orgmode file
=
#+SETUPFILE: ~/setup.org
#+TAGS: call(l) email(e)

* The top entry 
   :@work:call:
  SCHEDULED: 2013-05-14 Tue


Note that in the setup file, I have commented out every option other
than +STARTUP and +TAGS.  In this case, the in-buffer tag selection
results in a tag selection display of:


Inherited:
Current:@work call

  [l] call[e] email
{ [w] @work   [h] @home   }
{ [w] @work   [h] @home   }   - Note the duplicated listing


If you comment the +STARTUP option in the setup.org file, then the tag
selection behaves as expected.  Alternatively, if you enable any of
the other options, then the issue reoccurs.

Thanks!
--
Anupam


[O] [BUG] Tag selection is inconsistent when loaded from #+SETUPFILE in orgmode 8.0.x

2013-05-14 Thread Anupam Sengupta
Hi,

Loading tags from a #+SETUPFILE is causing inconsistent behavior in the
tag-selection for both
   in-buffer selection via C-c C-q (`org-set-tags-command`) and
   in-agenda selection via :   (`org-agenda-set-tags`).

A test-case using orgmode 8.0.3 on Emacs 24.3 (with the bare minimum
init file setting to get orgmode loaded).

The Org files are:

test.org:
=
#+SETUPFILE: ~/setup.org
#+TAGS: @Work(w) @Home(h)

* The top entry
  SCHEDULED: 2013-05-14 Tue
  
setup.org:
==
#+TAGS: email(e) call(c)



With the setup above, invoking C-c C-q on the first entry in the _buffer_
displays *only* the two tag entries from setup.org; i.e.:


Inherited:  
Current:

  [e] email   [c] call


And invoking C-c C-q in the _agenda_ for this entry displays *only* the
two entries from the in-buffer tag settings:


Inherited:  
Current:

  [w] @Work   [h] @Home 



In prior versions of orgmode (prior to 8.0.x), all four tags would be
displayed in the tag selection buffer.

I have attached the test files.


Regards,
--
Anupam

#+SETUPFILE: ~/setup.org
#+TAGS: @Work(w) @Home(h)

* The top entry
  SCHEDULED: 2013-05-14 Tue
#+TAGS: email(e) call(c)