Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Nick Dokos
Ilya Shlyakhter ilya_...@alum.mit.edu wrote: A corrected patch is attached. One more thing that you'll need to do is put your patches in attachments of a type that will allow patchwork to snag the patch: application/octet-stream does not. And if they don't end up in patchwork, they might get

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Carsten Dominik
Hi Ilya, hi Nick, thanks for looking into this. I am amazed by the deep understanding of Org's internals that shows in this thread. Both patches seem to be OK as far as I can see and can be applied without adverse effects. The patch for org-clock.el will at most achieve a factor of two (because

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Ilya Shlyakhter
On 3/16/2012 2:10 AM, Nick Dokos wrote: One more thing that you'll need to do is put your patches in attachments of a type that will allow patchwork to snag the patch: Thanks, I was wondering why they're not showing up. Here is another try (attached) for the org.el patch. ilya From

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Ilya Shlyakhter
On 3/16/2012 2:10 AM, Nick Dokos wrote: One more thing that you'll need to do is put your patches in attachments of a type that will allow patchwork to snag the patch: And here is the org-clock.el patch again. From 4f7f91ae62d425f7a89738b28006b1743a6bea4d Mon Sep 17 00:00:00 2001 From: Ilya

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Nick Dokos
Carsten Dominik carsten.domi...@gmail.com wrote: Hi Ilya, hi Nick, thanks for looking into this. I am amazed by the deep understanding of Org's internals that shows in this thread. On Ilya's part, certainly - for my part, I have only the vaguest clue about what Ilya did - I just saw a

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Carsten Dominik
Applied, thanks! - Carsten On Mar 16, 2012, at 3:13 PM, Ilya Shlyakhter wrote: On 3/16/2012 2:10 AM, Nick Dokos wrote: One more thing that you'll need to do is put your patches in attachments of a type that will allow patchwork to snag the patch: Thanks, I was wondering why they're not

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-16 Thread Carsten Dominik
This one again did not make it to patchwork, but I have applied it anyway, thanks. - Carsten On Mar 16, 2012, at 3:20 PM, Ilya Shlyakhter wrote: On 3/16/2012 2:10 AM, Nick Dokos wrote: One more thing that you'll need to do is put your patches in attachments of a type that will allow

[O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-15 Thread Ilya Shlyakhter
The attached patch speeds up tags matching ( 50s -- 5s for my most common search ), by turning on org-trust-scanner-tags within the matcher. (When it's off, getting a non-inherited property's value causes a call to org-entry-properties to fetch all properties into a cache, including ALLTAGS;

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-15 Thread Nick Dokos
Ilya Shlyakhter ilya_...@alum.mit.edu wrote: The attached patch speeds up tags matching ( 50s -- 5s for my most common search ), by turning on org-trust-scanner-tags within the matcher. (When it's off, getting a non-inherited property's value causes a call to org-entry-properties to fetch

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-15 Thread Ilya Shlyakhter
, | If your function needs to retrieve the tags including inherited tags | at the *current* entry, 'Function' here refers to the FUNC parameter of org-map-entries, not the MATCHER parameter. The matcher is constructed by org-make-tags-matcher, so we know everything it does -- it does not move

Re: [O] [PATCH] tags search: faster tags matcher by trusting scanner tags

2012-03-15 Thread Ilya Shlyakhter
Here is a similar patch for org-clock's use of tags/properties matcher. On Fri, Mar 16, 2012 at 12:31 AM, Ilya Shlyakhter ilya_...@alum.mit.eduwrote: , | If your function needs to retrieve the tags including inherited tags | at the *current* entry, 'Function' here refers to the FUNC