Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-12 Thread Bastien
Hi Michael, Michael Brand writes: > Your solution is wrong when there is a “%” not immediately followed by > “(”: Argh, right. I applied your patch, thanks again for the detailed examples. -- Bastien

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-12 Thread Michael Brand
Hi Bastien On Sat, Aug 11, 2012 at 11:59 PM, Bastien wrote: > Unless I miss something obvious, the current version returns exactly > the same thing than the one you propose -- can you double-check or let > me know what is wrong with the current solution? Your solution is wrong when there is a “%

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-11 Thread Bastien
Hi Michael, Michael Brand writes: > This part that I changed between > http://patchwork.newartisans.com/patch/1405 > and > http://patchwork.newartisans.com/patch/1408 > got lost, the attached patch restores it. Unless I miss something obvious, the current version returns exactly the same thing

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-11 Thread Michael Brand
Hi Bastien On Sat, Aug 11, 2012 at 6:55 PM, Bastien wrote: > Michael Brand writes: >> [...] >> Also a small change against your latest patch to not stop at “%” >> without following “(” and possibly miss a “%(” before. This part that I changed between http://patchwork.newartisans.com/patch/1405

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-11 Thread Bastien
Hi Michael, Michael Brand writes: > Thank you for making `org-capture-inside-embedded-elisp-p' much > clearer. I was not sure if you really wanted to omit switching to > Emacs Lisp Mode although it is useful for example for “%(length ")")”. > So I attach a new patch where I restored this part, n

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-11 Thread Michael Brand
Hi Bastien On Fri, Aug 10, 2012 at 10:53 AM, Bastien wrote: > Please try the attached patch and let me know if it works. Thank you for making `org-capture-inside-embedded-elisp-p' much clearer. I was not sure if you really wanted to omit switching to Emacs Lisp Mode although it is useful for exa

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-10 Thread Bastien
Hi Michael, Michael Brand writes: > Maybe there are still some simplifications? Please try the attached patch and let me know if it works. If you're okay, I'll then apply it under your name. >From 757d415af6247ea85f260daaeeb9f143f41e6103 Mon Sep 17 00:00:00 2001 From: Bastien Guerry Date: Fr

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-10 Thread Bastien
Michael Brand writes: > Yes. This is useful in general for me, thank you for the hint. I > propose the attached patch for the already existing .dir-locals.el and > .dir-settings.el. Applied, thanks to you and Ivan. -- Bastien

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-09 Thread Michael Brand
Hi Ivan On Thu, Aug 9, 2012 at 11:09 PM, Ivan Andrus wrote: > I'm probably missing something, but isn't this what directory local variables > are for? Yes. This is useful in general for me, thank you for the hint. I propose the attached patch for the already existing .dir-locals.el and .dir-set

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-09 Thread Ivan Andrus
On Aug 9, 2012, at 4:53 PM, Bastien wrote: > Hi Michael, > > Michael Brand writes: > >> You omitted the Local variables sentence-end-double-space: t. Isn't >> this a good idea for all the users like me that have set this to nil >> in their config? I wanted to add it to more files as soon as I w

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-09 Thread Michael Brand
Hi Bastien On Thu, Aug 9, 2012 at 4:53 PM, Bastien wrote: > I've check against current Emacs trunk, and only three files/packages > uses this: rst.el, filesets.el and mh-e. > > So I'd rather not pollute the hundred files of Org with this. That's all right. > (org-at-regexp-p org-capture-templa

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-09 Thread Bastien
Hi Michael, Michael Brand writes: > You omitted the Local variables sentence-end-double-space: t. Isn't > this a good idea for all the users like me that have set this to nil > in their config? I wanted to add it to more files as soon as I will > change them. I've check against current Emacs tr

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-09 Thread Michael Brand
Hi Bastien Thank you for reviewing my patch. On Wed, Aug 8, 2012 at 1:05 AM, Bastien wrote: > I've reworked some parts of your patch, You omitted the Local variables sentence-end-double-space: t. Isn't this a good idea for all the users like me that have set this to nil in their config? I want

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-08-07 Thread Bastien
Hi Michael, Michael Brand writes: > Thank you for the help. I have chosen the solution with require org-capture. > > The patch is now finished and attached: I've reworked some parts of your patch, specifically, I used `org-at-regexp-p' instead of `org-capture-inside-embedded-elisp-p'. Can you

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-06-24 Thread Michael Brand
Hi all On Sun, Jun 17, 2012 at 4:07 AM, Nick Dokos wrote: > Either require org-capture in org-feed or move the function to org.el, which > both org-capture and org-feed require. Thank you for the help. I have chosen the solution with require org-capture. The patch is now finished and attached:

Re: [O] Add the capture feature "%(sexp)" to org-feed

2012-06-16 Thread Nick Dokos
Michael Brand wrote: > I am almost done with adding the capture feature "%(sexp)" to > org-feed.el. Because for this I would like to use > org-capture-escaped-% from org-capture.el in org-feed.el I renamed > this function to org-template-escaped-% and call it in org-feed.el. > The only thing what

[O] Add the capture feature "%(sexp)" to org-feed

2012-06-16 Thread Michael Brand
Hi all I am almost done with adding the capture feature "%(sexp)" to org-feed.el. Because for this I would like to use org-capture-escaped-% from org-capture.el in org-feed.el I renamed this function to org-template-escaped-% and call it in org-feed.el. The only thing what is missing is that unles