Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread François Pinard
Max Mikhanosha m...@openchat.com writes: At Mon, 20 May 2013 13:45:48 -0500, Russell Adams wrote: What advantages would org-screenshot provide by comparison? To me the most useful feature is actually screenshot rotation shortcuts, I also have my own screenshot tool (this was my first own

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread Russell Adams
On Tue, May 21, 2013 at 08:03:45AM -0400, François Pinard wrote: I also have my own screenshot tool (this was my first own addition to Org mode, soon after I started to use it, quite a while ago now!) which is intermediate in features between Russell's and Max's. I can't take credit, that

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread Haider Rizvi
Max Mikhanosha m...@openchat.com writes: Hi All, I've been writing some documentation in OrgMode with screenshots, and as with any screenshot taking, it takes a while to get one just right. A few tiny helper utilities, quickly snowballed into this :-) It may need some cleanup, but IMHO its

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread Feng Shu
Haider Rizvi hari...@gmail.com writes: Max Mikhanosha m...@openchat.com writes: Hi All, I've been writing some documentation in OrgMode with screenshots, and as with any screenshot taking, it takes a while to get one just right. A few tiny helper utilities, quickly snowballed into this

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread François Pinard
Feng Shu tuma...@gmail.com writes: Haider Rizvi hari...@gmail.com writes: Max Mikhanosha m...@openchat.com writes: scrot screencapture import (imagemagick) https://wiki.archlinux.org/index.php/Taking_a_Screenshot http://thread.gmane.org/gmane.emacs.orgmode/69221/focus=69272 Thanks for

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread Viktor Rosenfeld
Hi, Haider Rizvi wrote: Max Mikhanosha m...@openchat.com writes: Hi All, I've been writing some documentation in OrgMode with screenshots, and as with any screenshot taking, it takes a while to get one just right. A few tiny helper utilities, quickly snowballed into this :-) It

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-21 Thread Viktor Rosenfeld
Forgot to attach the patch in my last mail. Sorry about the double posting. Viktor Rosenfeld wrote: Hi, Haider Rizvi wrote: Max Mikhanosha m...@openchat.com writes: Hi All, I've been writing some documentation in OrgMode with screenshots, and as with any screenshot

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-20 Thread François Pinard
Max Mikhanosha m...@openchat.com writes: [...] (require 'org-screenshot) [...] Thanks, Max, for sharing this! :-) François P.S. I appreciate the org-screenshot-image-directory function: by making it easy to override, the feature has been immediately useful to me.

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-20 Thread Russell Adams
On Thu, May 16, 2013 at 11:21:56PM -0400, Max Mikhanosha wrote: Hi All, I've been writing some documentation in OrgMode with screenshots, and as with any screenshot taking, it takes a while to get one just right. Max, I use this for all screenshots. This inserts a link named by buffer with a

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-20 Thread Russell Adams
On Mon, May 20, 2013 at 08:14:16PM -0400, Max Mikhanosha wrote: To me the most useful feature is actually screenshot rotation shortcuts, that cycle image before point, with other files in the `(org-screenshot-image-directory)'. That is useful! Taking screenshot itself and inserting link is

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Bastien
Hi Max, Max Mikhanosha m...@openchat.com writes: To try it out, you'll need /usr/bin/scrot which is available as scrot package on most distributions. Then (require 'org-screenshot) and try C-c M-s (org-screenshot-take) in an Org File. Make sure to turn on inline image display (C-c C-x

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Rainer M. Krug
Bastien b...@gnu.org writes: Hi Max, Max Mikhanosha m...@openchat.com writes: To try it out, you'll need /usr/bin/scrot which is available as scrot package on most distributions. Then (require 'org-screenshot) and try C-c M-s (org-screenshot-take) in an Org File. Make sure to turn on

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Max Mikhanosha
At Fri, 17 May 2013 09:38:29 +0200, Rainer M. Krug wrote: Nice and very useful. Can this be included in /contrib? That is my intention, I have the FSF paper signed for Emacs and Org. So what I'm looking for some minimum amount of eyes on the code, and advice as to minimum set of things I need

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Daniel F
It looks great! I think I'd only convert defvars to defcustom. Personally, I don't worry about prefixes that much, because if I am not using a command very often I just tend do run it using M-x command-name - Dan On Fri, May 17, 2013 at 2:41 PM, Max Mikhanosha m...@openchat.com wrote: At

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Carsten Dominik
On 17.5.2013, at 09:38, Rainer M. Krug rai...@krugs.de wrote: Bastien b...@gnu.org writes: Hi Max, Max Mikhanosha m...@openchat.com writes: To try it out, you'll need /usr/bin/scrot which is available as scrot package on most distributions. Then (require 'org-screenshot) and try

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Carsten Dominik
On 17.5.2013, at 09:38, Rainer M. Krug rai...@krugs.de wrote: Bastien b...@gnu.org writes: Hi Max, Max Mikhanosha m...@openchat.com writes: To try it out, you'll need /usr/bin/scrot which is available as scrot package on most distributions. Then (require 'org-screenshot) and try

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Bastien
Hi Max, Max Mikhanosha m...@openchat.com writes: My list is. 1. Convert defvar to defcustom 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in dired.el Seems fine to me. 3. The prefix C-c M-s seems awkward but Org is so big everything else is taken, and C-c C-x

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Max Mikhanosha
At Fri, 17 May 2013 15:05:05 +0200, Carsten Dominik wrote: Nice and very useful. Can this be included in /contrib? Certainly! Ok cool, I've already cleaned up the docstrings, I'll change some defvars to defcustoms and commit it later today. Regards, Max

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Brett Viren
Hi Max, Max Mikhanosha m...@openchat.com writes: I have committed org-screenshot to master This sounds like a great idea. And just to prove that no good deed goes unpunished, here is a bug report: In an org-mode file I run M-x org-screenshot-take, scrot runs and I can either click on a

Re: [O] RFQ - new contribution - org-screenshot.el

2013-05-17 Thread Max Mikhanosha
At Fri, 17 May 2013 13:20:16 -0400, Brett Viren wrote: Hi Max, Max Mikhanosha m...@openchat.com writes: I have committed org-screenshot to master This sounds like a great idea. And just to prove that no good deed goes unpunished, here is a bug report: In an org-mode file I run

[O] RFQ - new contribution - org-screenshot.el

2013-05-16 Thread Max Mikhanosha
Hi All, I've been writing some documentation in OrgMode with screenshots, and as with any screenshot taking, it takes a while to get one just right. A few tiny helper utilities, quickly snowballed into this :-) It may need some cleanup, but IMHO its too awesome not to share it with the list. To