Re: [O] update to ob-clojure.el

2014-04-17 Thread Bastien
Hi Greg and Oleh, Soapy Smith writes: > I'm not sure about removing nrepl and slime, as there may be some still > using them, especially nrepl. As long as it is not getting in the way, > perhaps at this time it would be better to leave them in? Agreed. > I'm not sure > the open-source and/or

Re: [O] update to ob-clojure.el

2014-04-14 Thread Oleh
>> I've made an update to ob-clojure.el, which wasn't working for me with >> the new cider (the required function was removed). >> >> I haven't looked into 'nrepl or 'slime options for evaluation, is >> anyone using them? >> >> Eric, should 'nrepl option be removed as obsolete? And maybe 'slime as

Re: [O] update to ob-clojure.el

2014-04-13 Thread Soapy Smith
On Thu, 2014-04-10 at 10:36 +0200, Oleh wrote: > Hi all, > > I've made an update to ob-clojure.el, which wasn't working for me with > the new cider (the required function was removed). > > I haven't looked into 'nrepl or 'slime options for evaluation, is > anyone using them? > > Eric, should 'nr

Re: [O] update to ob-clojure.el

2014-04-11 Thread Bastien
Hi Oleh, Oleh writes: >> As long as we have to support Emacs 23, I think you shouldn't replace >> "case" with "cl-case". > > I've reverted it. I'll keep this in mind for future commits, thanks. Thanks for the patch -- and since we are nitpicking, here is another one (a famous one I'd say): use

Re: [O] update to ob-clojure.el

2014-04-10 Thread Oleh
Hi Nicolas, > >> I've made an update to ob-clojure.el, which wasn't working for me with >> the new cider (the required function was removed). > > As long as we have to support Emacs 23, I think you shouldn't replace > "case" with "cl-case". I've reverted it. I'll keep this in mind for future comm

Re: [O] update to ob-clojure.el

2014-04-10 Thread Nicolas Goaziou
Hello, Oleh writes: > I've made an update to ob-clojure.el, which wasn't working for me with > the new cider (the required function was removed). As long as we have to support Emacs 23, I think you shouldn't replace "case" with "cl-case". Regards, -- Nicolas Goaziou

[O] update to ob-clojure.el

2014-04-10 Thread Oleh
Hi all, I've made an update to ob-clojure.el, which wasn't working for me with the new cider (the required function was removed). I haven't looked into 'nrepl or 'slime options for evaluation, is anyone using them? Eric, should 'nrepl option be removed as obsolete? And maybe 'slime as well? reg