Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-09-13 Thread Ihor Radchenko
Tor Kringeland writes: > Ihor Radchenko writes: > >> Aha. Not saving is an important piece of information. >> (said the person with compulsive saving syndrome) > > Thanks! This fixes the bug (which was present in both Org 9.5 and 9.6) > for me. However, my original bug, which is only present

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-27 Thread Ihor Radchenko
"Samuel Banya" writes: > 8. I then used C-c C-c, and received the following example output: > ``` > * tes > :LOGBOOK: > - Note taken on [2022-06-27 Mon 22:38] \\ > Adding note with org-log-into-drawer enabled > :END: > t > ``` > > Let me know if this is the desired output in that respect, or

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-27 Thread Samuel Banya
So I went through the same steps as before: 1. Pulled the latest Emacs Org Mode 2. Ran the following command in a terminal to get a clean Emacs without a config: emacs -Q -L ./lisp -l org 3. Create a new org file 4.. Type (literally) the following: * test 5. You will get a file containing "*

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-27 Thread Ihor Radchenko
"Samuel Banya" writes: > I checked 'org.el' which has the related 'org-add-note' function present. > > This appears to call the 'org-add-log-setup' function, and passes the 'note' > argument to it. > > I then took a look at the 'org-add-log-setup' function. > > From the bug's nature itself, it

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-26 Thread Samuel Banya
Gotcha, after this great advice, I am also able to get the following result: ``` - Note taken on [2022-06-26 Sun 22:31] \\ Adding test note * test ``` However, even after toggling 'M-x toggle-debug-on-error', it didn't enter the debugger since I guess this would be considered a 'user error'

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-26 Thread Ihor Radchenko
"Samuel Banya" writes: > Ihor, can you take a look at the .mkv video I attached of my test and let me > know what you did to be able to reproduce this because I'm not observing any > errors on my machine. You misunderstood the email formatting. #+begin_example * test #+end_example actually

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-23 Thread Samuel Banya
Hey Ihor, I can check it out on the weekend, sounds like fun. Will step through the debugger to see what's up and get back to you on this, thanks for tagging me on this. On Wed, Jun 22, 2022, at 10:28 AM, Tor Kringeland wrote: > Ihor Radchenko writes: > > > Confirmed. > > > > Samuel, do you

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-22 Thread Tor Kringeland
Ihor Radchenko writes: > Confirmed. > > Samuel, do you want to try fixing this? > It should be fairly easy to debug. Nice. But these are distinct bugs, it seems like. The one you sent a patch for earlier fixes the former bug (which is also present in Org 9.5). While my original problem is

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-21 Thread Ihor Radchenko
Tor Kringeland writes: > Ihor Radchenko writes: > >> Aha. Not saving is an important piece of information. >> (said the person with compulsive saving syndrome) > > Thanks! This fixes the bug (which was present in both Org 9.5 and 9.6) > for me. However, my original bug, which is only present

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-21 Thread Tim Cross
Tor Kringeland writes: > Ihor Radchenko writes: > >> Aha. Not saving is an important piece of information. >> (said the person with compulsive saving syndrome) > > Thanks! This fixes the bug (which was present in both Org 9.5 and 9.6) > for me. However, my original bug, which is only

Re: [PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-21 Thread Tor Kringeland
Ihor Radchenko writes: > Aha. Not saving is an important piece of information. > (said the person with compulsive saving syndrome) Thanks! This fixes the bug (which was present in both Org 9.5 and 9.6) for me. However, my original bug, which is only present in Org 9.6, is still there. Do the

[PATCH] Re: [BUG] Adding note to heading without newline at the end

2022-06-20 Thread Ihor Radchenko
Tor Kringeland writes: > Ihor Radchenko writes: > >> Can you reproduce the problem starting from emacs -Q? > > I did. The bug only occurs if there is no newline at the end. So for > example if you open a new buffer and don't save it, the bug should > occur. Aha. Not saving is an important