Re: [O] Org-lint and #+call lines

2015-04-28 Thread Thomas S. Dye
Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 t...@tsdye.com (Thomas S. Dye) writes:

 Org-lint gives this warning:

 ,--
 | 31 low   Unknown value no-export for header :eval
 `--

 But, ob-core.el appears to know the value:

 ,
 | ob-core.el: (,eval-no-export (and ,export (or (equal ,eval 
 no-export)
 `

 Is this a false positive?

 Yes, this was an omission in ob-core.el. I fixed it in master. You'll
 need to rebase wip-lint against it.

Another false positive, I think:

  1360 low   Unknown value no for header :eval

Also, after I run org-lint I sometimes lose the cursor.  The frame
around the *Org Lint* window flickers a bit, as if *Org Lint* is being
refreshed over and over.  Apologies in advance for such a vague report.
I'm not sure where to start debugging something like this.

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com



Re: [O] Org-lint and #+call lines

2015-04-28 Thread Nicolas Goaziou
t...@tsdye.com (Thomas S. Dye) writes:

 Another false positive, I think:

   1360 low   Unknown value no for header :eval

Fixed too, and also cherry-picked from wip-lint.

 Also, after I run org-lint I sometimes lose the cursor.  The frame
 around the *Org Lint* window flickers a bit, as if *Org Lint* is being
 refreshed over and over.

It should only refresh if you press `g' in lint buffer.

 Apologies in advance for such a vague report. I'm not sure where to
 start debugging something like this.

You can debug `org-lint--generate-reports'. It is the function
responsible for refreshing the buffer. It should only be called once
after M-x org-lint and every time *Org Lint* buffer is refreshed
(i.e., with `g').


Regards,



Re: [O] Org-lint and #+call lines

2015-04-28 Thread Nicolas Goaziou
t...@tsdye.com (Thomas S. Dye) writes:

 Org-lint gives this warning:

 ,--
 | 31 low   Unknown value no-export for header :eval
 `--

 But, ob-core.el appears to know the value:

 ,
 | ob-core.el: (,eval-no-export (and ,export (or (equal ,eval 
 no-export)
 `

 Is this a false positive?

Yes, this was an omission in ob-core.el. I fixed it in master. You'll
need to rebase wip-lint against it.

Thank you.

Regards,



Re: [O] Org-lint and #+call lines

2015-04-27 Thread Nicolas Goaziou
Hello,

t...@tsdye.com (Thomas S. Dye) writes:

 So, I decided to track wip-lint.  Now, the linting stops with this
 error:

 ,
 | Org linting process starting...
 | let: Wrong type argument: listp, :results replace org
 `

 The *Org Lint* buffer is empty, except for the header line.

 Here is the offending line in the Org mode file:

 ,--
 | #+call: r-duplicate-ids() :results replace org
 `--

Fixed. Thank you.


Regards,

-- 
Nicolas Goaziou



Re: [O] Org-lint and #+call lines

2015-04-27 Thread Nicolas Goaziou
 Is org-lint supposed to catch :results output graphics?

It catches

:results output graphic

Is it

  :results output graphics


Regards,



Re: [O] Org-lint and #+call lines

2015-04-27 Thread Thomas S. Dye
Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 Hello,

 t...@tsdye.com (Thomas S. Dye) writes:

 So, I decided to track wip-lint.  Now, the linting stops with this
 error:

 ,
 | Org linting process starting...
 | let: Wrong type argument: listp, :results replace org
 `

 The *Org Lint* buffer is empty, except for the header line.

 Here is the offending line in the Org mode file:

 ,--
 | #+call: r-duplicate-ids() :results replace org
 `--

 Fixed. Thank you.

Thanks.  This is really helpful.

Is org-lint supposed to catch :results output graphics?

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com



Re: [O] Org-lint and #+call lines

2015-04-27 Thread Nicolas Goaziou
Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 Is org-lint supposed to catch :results output graphics?

 It catches

 :results output graphic

 Is it

   :results output graphics

Nevermind. 

I realized allowed values and combinations are already known to Babel,
so I improved the checker.



Re: [O] Org-lint and #+call lines

2015-04-27 Thread Thomas S. Dye
Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 I realized allowed values and combinations are already known to Babel,
 so I improved the checker.

Looks good.  Org-lint raises many more warnings now.

Thanks,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com



Re: [O] Org-lint and #+call lines

2015-04-27 Thread Thomas S. Dye
Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 Nicolas Goaziou m...@nicolasgoaziou.fr writes:

 Is org-lint supposed to catch :results output graphics?

 It catches

 :results output graphic

 Is it

   :results output graphics

 Nevermind. 

 I realized allowed values and combinations are already known to Babel,
 so I improved the checker.

Org-lint gives this warning:

,--
| 31 low   Unknown value no-export for header :eval
`--

But, ob-core.el appears to know the value:

,
| ob-core.el: (,eval-no-export (and ,export (or (equal ,eval 
no-export)
`

Is this a false positive?

All the best,
Tom

-- 
Thomas S. Dye
http://www.tsdye.com