Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: >> Yes, ideally, we need to know which exact test case fails. But please >> open a new thread as it will be unrelated to java discussed herein. > > Now you lost me. :) > > The linked mail has all the information already has its own thread. You are right.

Re: [PATCH] ob-java: Define the list of all supported header arguments

Ihor Radchenko writes: >> In the linked mail, I discuss the problem starting from this test, >> tracking it down to the problematic line of code. Do you want me to >> look into something further? > > Yes, ideally, we need to know which exact test case fails. But please > open a new thread as it

Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> Could you narrow down the particular test condition which is failing? >> Is it similar to previously discussed cases where MacOS sorting is not >> consistent with Linux? > > In the linked mail, I discuss the problem starting from this test,

Re: [PATCH] ob-java: Define the list of all supported header arguments

Ihor Radchenko writes: > Could you narrow down the particular test condition which is failing? > Is it similar to previously discussed cases where MacOS sorting is not > consistent with Linux? In the linked mail, I discuss the problem starting from this test, tracking it down to the problematic

Re: [PATCH] ob-java: Define the list of all supported header arguments

Ihor Radchenko writes: > Then, it sounds like local.mk does not enable java tests. > > I fixed such scenario on main. > Now, java tests will be skipped when ob-java testing is not requested. That works for me now, with or without java in local.mk. Thanks for the patch and the explanation!

Re: [PATCH] ob-java: Define the list of all supported header arguments

Bruno Barbier writes: > I'm seeing these 3 failures too, running the tests from the command > line. The failure looks like this: > > FAILED ob-java/lint-header-args-block ((should-not (org-lint > '(wrong-header-argument))) :form (org-lint (wrong-header-argument)) > :value ((1 ["8"

Re: [PATCH] ob-java: Define the list of all supported header arguments

Ihor Radchenko writes: > Rudolf Adamkovič writes: > >> Overall, I now see the following failures on the main branch: >> >>FAILED ob-java/lint-header-args-block >>FAILED ob-java/lint-header-args-buffer >>FAILED ob-java/lint-header-args-heading > > AFAIK, Max is using Linux.

Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: > The second one (`test-org-table') still fails on macOS. > > Overall, I now see the following failures on the main branch: > >FAILED ob-java/lint-header-args-block >FAILED ob-java/lint-header-args-buffer >FAILED ob-java/lint-header-args-heading AFAIK,

Re: [PATCH] ob-java: Define the list of all supported header arguments

Ihor Radchenko writes: >> ... The remaining tests (`test-org-num' and `test-org-table') fail >> in both scenarios. That said, I run macOS, which has some issues with >> sorting [*]. > > This is not because of macOS. Emacs 29 broke some assumptions about > return value of `overlays-in'. See >

Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: > On `main' with Emacs 29 (5b9b393c61), I get: > > 8 unexpected results: > ... >FAILED test-org-num/max-level [...] >FAILED test-org-num/skip-numbering [...] >FAILED test-org-num/update [...] >FAILED test-org-table/sort-lines [...] >FAILED

Re: [PATCH] ob-java: Define the list of all supported header arguments

Max Nikulin writes: > Am I the only person who gets > > 3 unexpected results: > FAILED ob-java/lint-header-args-block > FAILED ob-java/lint-header-args-buffer > FAILED ob-java/lint-header-args-heading On `main' with Emacs 29 (5b9b393c61), I get: 8 unexpected results: FAILED

Re: [PATCH] ob-java: Define the list of all supported header arguments

Max Nikulin writes: > Am I the only person who gets > > 3 unexpected results: > FAILED ob-java/lint-header-args-block > FAILED ob-java/lint-header-args-buffer > FAILED ob-java/lint-header-args-heading > > Emacs-27.1. Example of failure: Tests are passing on my side. -- Ihor

Re: [PATCH] ob-java: Define the list of all supported header arguments

Am I the only person who gets 3 unexpected results: FAILED ob-java/lint-header-args-block FAILED ob-java/lint-header-args-buffer FAILED ob-java/lint-header-args-heading Emacs-27.1. Example of failure: Test ob-java/lint-header-args-block backtrace: signal(ert-test-failed

Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: > Rudolf Adamkovič writes: > >> Please see the attached patch with updated tests. > > Oops, I had a typo (a wrong tense) in the commit message. > > Please see the patch attached to this message that has it fixed. Thanks! Applied onto main.

Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: > Please see the attached patch with updated tests. Oops, I had a typo (a wrong tense) in the commit message. Please see the patch attached to this message that has it fixed. Rudy >From 37bd1716a652751e6941781464d47c283be3b4b9 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] ob-java: Define the list of all supported header arguments

Ihor Radchenko writes: > Thanks! > Applied onto main. Fantastic! > Fixed. Thanks. Please see the attached patch with updated tests. Rudy >From 5405d0419295bb1a0314cb2b3ce07713fc77e792 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Fri, 21 Oct 2022 14:48:56 +0200

Re: [PATCH] ob-java: Define the list of all supported header arguments

Rudolf Adamkovič writes: > Hello smart folks! > > The Org linter warns about *correct* Java source block arguments. The > attached patch fixes that. Thanks! Applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ee3dbb0fdb6e119207f13a165e90b878b741cf49 > P.S. I