[Accepted] [Orgmode] Re: [bug] org-store-link on gnus message fails

2011-01-13 Thread Carsten Dominik
Patch 533 (http://patchwork.newartisans.com/patch/533/) is now Accepted.

Maintainer comment: No comment

This relates to the following submission:

http://mid.gmane.org/%3C87bp3moyua.fsf%40member.fsf.org%3E

Here is the original message containing the patch:

 Content-Type: text/plain; charset=utf-8
 MIME-Version: 1.0
 Content-Transfer-Encoding: 7bit
 Subject: [Orgmode] Re: [bug] org-store-link on gnus message fails
 Date: Wed, 12 Jan 2011 21:45:17 -
 From: Tassilo Horn tass...@member.fsf.org
 X-Patchwork-Id: 533
 Message-Id: 87bp3moyua@member.fsf.org
 To: emacs-orgmode@gnu.org
 
 Hi Eric,
 
 this patch should do the trick.  I think the issue was a malformed Date:
 header that couldn't be converted to a timestamp.
 
 --8---cut here---start-8---
 --8---cut here---end---8---
 
 Bye,
 Tassilo
 
 
 diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
 index 32641bf..ae5dc52 100644
 --- a/lisp/org-gnus.el
 +++ b/lisp/org-gnus.el
 @@ -152,11 +152,16 @@ If `org-store-link' was called with a prefix arg the 
 meaning of
  (from (mail-header-from header))
  (message-id (org-remove-angle-brackets (mail-header-id header)))
  (date (org-trim (mail-header-date header)))
 -(date-ts (and date (format-time-string
 -(org-time-stamp-format t) (date-to-time date
 -(date-ts-ia (and date (format-time-string
 -   (org-time-stamp-format t t)
 -   (date-to-time date
 +(date-ts (and date
 +  (condition-case nil
 +  (format-time-string
 +   (org-time-stamp-format t)
 +   (date-to-time date)
 +(date-ts-ia (and date
 + (condition-case nil
 + (format-time-string
 +  (org-time-stamp-format t t)
 +  (date-to-time date)
  (subject (copy-sequence (mail-header-subject header)))
  (to (cdr (assq 'To (mail-header-extra header
  newsgroups x-no-archive desc link)
 

___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Accepted] [Orgmode] Re: [bug] org-store-link on gnus message fails

2011-01-13 Thread Tassilo Horn
Carsten Dominik cdomi...@newartisans.com writes:

Hi Carsten,

 Patch 533 (http://patchwork.newartisans.com/patch/533/) is now Accepted.

The patch below was wrong.  The patch in the next mail that used
`ignore-errors' instead of `condition-case' is the right one.

Bye,
Tassilo

 diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
 index 32641bf..ae5dc52 100644
 --- a/lisp/org-gnus.el
 +++ b/lisp/org-gnus.el
 @@ -152,11 +152,16 @@ If `org-store-link' was called with a prefix arg the 
 meaning of
 (from (mail-header-from header))
 (message-id (org-remove-angle-brackets (mail-header-id header)))
 (date (org-trim (mail-header-date header)))
 -   (date-ts (and date (format-time-string
 -   (org-time-stamp-format t) (date-to-time date
 -   (date-ts-ia (and date (format-time-string
 -  (org-time-stamp-format t t)
 -  (date-to-time date
 +   (date-ts (and date
 + (condition-case nil
 + (format-time-string
 +  (org-time-stamp-format t)
 +  (date-to-time date)
 +   (date-ts-ia (and date
 +(condition-case nil
 +(format-time-string
 + (org-time-stamp-format t t)
 + (date-to-time date)
 (subject (copy-sequence (mail-header-subject header)))
 (to (cdr (assq 'To (mail-header-extra header
 newsgroups x-no-archive desc link)
 

___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode