Ihor Radchenko writes:
> LGTM now. Thanks!
> Applied onto main with minor amendments in formatting.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8151d52574f525fd922aadc43544688004cb7d14
Thanks Ihor!
Bastien Guerry writes:
> I confirm Bruno is on the list of FSF-signed contributors,
> I updated the Worg page. Bruno, thanks in advance for your
> contributions!
Thanks Bastien.
Bruno Barbier writes:
> I'm now adding a version of `with-connection-local-variables', in
> org-compat.el: that should work for 26. I didn't test it as I currently
> don't have an Emacs 26. But I should be able to compile one, if you think
> it's needed.
>
> Thank you for spotting this and pointi
Hi Ihor and Bruno,
Ihor Radchenko writes:
> Bastien, could you please check the FSF record.
I confirm Bruno is on the list of FSF-signed contributors,
I updated the Worg page. Bruno, thanks in advance for your
contributions!
--
Bastien
Ihor Radchenko writes:
>
> '->` :: `process-file'
>
Sorry: fixed.
> > lib/ob-shell.el (org-babel-sh-evaluate): Use `process-file' (instead
>
> lisp/ob-shell.el
Thanks.
>
>> +(with-connection-local-variables
>
> I tried to test your patch on various Emacs versions.
> `with-
Bruno Barbier writes:
>> You patch is >15LOC so we do need your copyright assignment before
>> merging. Let me know if you face any difficulties with the copyright
>> process. Note that FSF should reply within 5 working days.
>
> Done. I just learnt a few days ago the process is done.
Thanks!
B
Ihor Radchenko writes:
> Thanks for the patch!
>
Thanks for the review!
>> I've also included a test, as the problem is reproducible with TRAMP
>> "/mock::" connection. But, that test will only work on GNU/Linux
>> systems.
> Then you also need to guard the tests against system-type variable
Bruno Barbier writes:
> From what I understand, the function 'org-babel-sh-evaluate' relies on
> 'call-process'; and that function ignores file name handlers; as TRAMP
> relies on those file name handlers, it just cannot do the right thing.
>
> Using 'process-file' instead works for me.
>
> See t
"Felix Freeman" via "General discussions about Org-mode."
writes:
> When using TRAMP, ob-shell's :cmdline and :stdin header options are
> broken on org-babel.
>
I can reproduce the problem (thanks for your nice MCE).
I'm using:
Org mode version 9.5.4 (release_9.5.4-32-g82036c)
GNU Emac
When using TRAMP, ob-shell's :cmdline and :stdin header options are
broken on org-babel.
I've noticed that when those options are present, it takes other route
on ob-shell.el, but I lack the proper background to fix or debug it
further.
Probably cmdline is more complicated to get working right, b
10 matches
Mail list logo
