Re: [O] [PATCH] Do not save target buffer after archiving subtree

[Nicolas Goaziou]

Hello,

Matt Lundin  writes:

> The attached patch removes the call to save-buffer in
> org-archive-subtree. This significantly reduces the time necessary to
> archive a subtree, especially when archiving many subtrees in a region.
> Without this patch, Org Mode will save the archive buffer after each
> subtree is archived. If one were archiving a region of 50 trees, this
> would result in 50 writes to disk in quick succession. This patch makes
> the behavior of org-archive-subtree match that of org-refile, which does
> not save the target buffer after a refile.

Good catch. Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

[O] [PATCH] Do not save target buffer after archiving subtree

[Matt Lundin]

The attached patch removes the call to save-buffer in
org-archive-subtree. This significantly reduces the time necessary to
archive a subtree, especially when archiving many subtrees in a region.
Without this patch, Org Mode will save the archive buffer after each
subtree is archived. If one were archiving a region of 50 trees, this
would result in 50 writes to disk in quick succession. This patch makes
the behavior of org-archive-subtree match that of org-refile, which does
not save the target buffer after a refile.

Best,
Matt

>From 5c10b578461879d2770a85ae69c8182942074ee7 Mon Sep 17 00:00:00 2001
From: Matt Lundin 
Date: Sat, 25 Nov 2017 09:26:15 -0600
Subject: [PATCH] Do not save target buffer after archiving subtree

* lisp/org-archive.el: (org-archive-subtree) Do not save buffer after
  each archive. Saving the archive buffer after archiving each subtree
  results in substantial slowdown and many writes to disk when
  archiving an active region. This brings the behavior of
  org-archive-subtree into line with org-refile, which does not save
  the target buffer after refiling.
---
 lisp/org-archive.el | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/org-archive.el b/lisp/org-archive.el
index b2e2178dc..37c5d6f62 100644
--- a/lisp/org-archive.el
+++ b/lisp/org-archive.el
@@ -381,10 +381,7 @@ direct children of this heading."
 		 (point)
 		 (concat "ARCHIVE_" (upcase (symbol-name item)))
 		 value
-	  (widen)
-	  ;; Save and kill the buffer, if it is not the same
-	  ;; buffer.
-	  (unless (eq this-buffer buffer) (save-buffer)
+	  (widen
 	;; Here we are back in the original buffer.  Everything seems
 	;; to have worked.  So now run hooks, cut the tree and finish
 	;; up.
-- 
2.15.0