Re: [O] [PATCH] Fix inconsistency in drawer handling

2012-09-19 Thread Nicolas Goaziou
Hello, Yann Hodique writes: > thanks for the quick review. Of course I don't mind, but I'm just > curious to understand the purpose, as duplicating constants seems to > make room for future mistakes (even though in this case I guess we're > stuck with that regexp forever :)). As far as Org Elem

Re: [O] [PATCH] Fix inconsistency in drawer handling

2012-09-16 Thread Yann Hodique
> "Nicolas" == Nicolas Goaziou writes: > This patch is good, but I'd rather hard-code the regexp within > org-element: I'm slowly trying to make this library as low-level as > possible. Do you mind changing it? Hi, thanks for the quick review. Of course I don't mind, but I'm just curious to

Re: [O] [PATCH] Fix inconsistency in drawer handling

2012-09-15 Thread Nicolas Goaziou
Hello, Yann Hodique writes: > I've noticed that drawers are not managed similarly, depending on the > workflow. More precisely, the end-of-drawer detection is not exactly > the same for various exports, org-element, or folding. It all boils > down to variations around (re-search-forward ":END:")

[O] [PATCH] Fix inconsistency in drawer handling

2012-09-15 Thread Yann Hodique
* lisp/org.el (org-drawer-end-re): Introduce new constant. (org-clock-drawer-start-re): Fix docstring. (org-clock-drawer-end-re): Fix docstring. (org-flag-drawer): Make use of `org-drawer-end-re'. (org-end-of-meta-data-and-drawers): Make use of `org-drawer-end-re'. * lisp/org-element.el (org-eleme

[O] [PATCH] Fix inconsistency in drawer handling

2012-09-15 Thread Yann Hodique
Hi, I've noticed that drawers are not managed similarly, depending on the workflow. More precisely, the end-of-drawer detection is not exactly the same for various exports, org-element, or folding. It all boils down to variations around (re-search-forward ":END:"). In particular, it's expected th