Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-09-01 Thread Marcin Borkowski
Dnia 2014-08-31, o godz. 21:56:19 Nicolas Goaziou napisał(a): > >> There are also bits of documentation here and there, on the ML, in > >> the "ox.el" reference... I'm in the process of writing a small > >> document collecting these bits. > > > > Wow, that would be cool! I tried to look into the

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-31 Thread Nicolas Goaziou
Hello, Marcin Borkowski writes: > Dnia 2014-08-27, o godz. 09:34:16 > Nicolas Goaziou napisał(a): > >> There are also bits of documentation here and there, on the ML, in the >> "ox.el" reference... I'm in the process of writing a small document >> collecting these bits. > > Wow, that would be c

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-27 Thread Marcin Borkowski
Dnia 2014-08-27, o godz. 09:34:16 Nicolas Goaziou napisał(a): > There are also bits of documentation here and there, on the ML, in the > "ox.el" reference... I'm in the process of writing a small document > collecting these bits. Wow, that would be cool! I tried to look into the docstrings in o

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-27 Thread Nicolas Goaziou
Samuel Loury writes: > Nonetheless, please find attached a revised version of the patch with > your comments taken into account. Applied (with some spurious newlines removed). Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-27 Thread Nicolas Goaziou
Hello, Samuel Loury writes: > About org-element.el, I would be happy to try. I guess the best > documentation is the file itself (it appears to be quite well > commented). Is it a good way to start? There are also bits of documentation here and there, on the ML, in the "ox.el" reference... I'm

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-27 Thread Samuel Loury
Hi, Finally, I don't have time to dig into org-element.el for the time being. Nonetheless, please find attached a revised version of the patch with your comments taken into account. In order to avoid creating the regexp each time `org-at-clock-log-p' is called, I added the constant `org-clock-li

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-26 Thread Samuel Loury
Hi, Thank you for the comments, I will try to improve the commit as soon as possible. About org-element.el, I would be happy to try. I guess the best documentation is the file itself (it appears to be quite well commented). Is it a good way to start? -- Konubinix GPG Key: 7439106A Fingerpri

Re: [O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-26 Thread Nicolas Goaziou
Hello, Samuel Loury writes: > I would like to submit a tiny patch to make use of `org-clock-string' > instead of the hard coded value CLOCK: whenever possible. Thank you. Some comments follow. > From 8eedb019d277f7f1e8baa6641244ddf7e298d397 Mon Sep 17 00:00:00 2001 > From: Konubinix > Date: T

[O] [PATCH] Make use of the constant `org-clock-string' whenever possible

2014-08-26 Thread Samuel Loury
Hi, I would like to submit a tiny patch to make use of `org-clock-string' instead of the hard coded value CLOCK: whenever possible. I also found out that :CLOCK: was hard coded in `org-insert-property-drawer' (git sha 67ae102b4be87976240555d1c0d80ee55906f53c, file lisp/org.el:15897) instead of us