Re: [O] [PATCH] Re: Can't export LaTeX source code blocks
Sebastien Vauban sva-n...@mygooglest.com writes: Sebastien Vauban wrote: Thomas S. Dye wrote: Sebastien Vauban writes: The code block is NEVER exported. I don't understand why? I'm not sure either. I took a quick look at ob-latex.el. The code there sets `:exports results' and then, IIUC, goes on its way without checking if :exports has been set in the buffer. It looks to me like ob-latex.el would need to be revised. I don't have the impression that the error lies in `ob-latex' as the other `ob-LANG' files don't either make any special check -- while all graphics-only languages do, as well, have the default of results for :exports. I have the impression the problem is to search in `ob-core' (`org-babel-execute-src-block') or `ob-exp'... But that's not yet clear to me where that could be. I think I found it. That was a priority order problem for implementing the hierarchy of header arguments inheritage in `ob-core'. Applied, Thanks! Best regards, Seb From 3339c0f7d296fc68a206b0f69270da3a91025840 Mon Sep 17 00:00:00 2001 From: Sebastien Vauban sva-n...@invalid.mygooglest.com Date: Sat, 27 Apr 2013 11:40:25 +0200 Subject: [PATCH 2/2] Fix priority order for inheriting header arguments * ob-core.el (org-babel-parse-src-block-match): Fix order of list of header arguments. --- lisp/ob-core.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/ob-core.el b/lisp/ob-core.el index 9baff0c..73dca8f 100644 --- a/lisp/ob-core.el +++ b/lisp/ob-core.el @@ -1,6 +1,6 @@ ;;; ob-core.el --- working with code blocks in org-mode -;; Copyright (C) 2009-2012 Free Software Foundation, Inc. +;; Copyright (C) 2009-2013 Free Software Foundation, Inc. ;; Authors: Eric Schulte ;; Dan Davison @@ -1323,8 +1323,8 @@ may be specified in the properties of the current outline entry. (buffer-string))) (org-babel-merge-params org-babel-default-header-args - (org-babel-params-from-properties lang) (if (boundp lang-headers) (eval lang-headers) nil) + (org-babel-params-from-properties lang) (org-babel-parse-header-arguments (org-no-properties (or (match-string 4) switches -- 1.7.9 -- Eric Schulte http://cs.unm.edu/~eschulte
Re: [O] [PATCH] Re: Can't export LaTeX source code blocks
Hi Eric, Could you look at this patch, fixing the priority hierarchy of Babel header arguments, and apply it, if judged OK? Best regards, Seb Sebastien Vauban wrote: Sebastien Vauban wrote: Thomas S. Dye wrote: Sebastien Vauban writes: The code block is NEVER exported. I don't understand why? I'm not sure either. I took a quick look at ob-latex.el. The code there sets `:exports results' and then, IIUC, goes on its way without checking if :exports has been set in the buffer. It looks to me like ob-latex.el would need to be revised. I don't have the impression that the error lies in `ob-latex' as the other `ob-LANG' files don't either make any special check -- while all graphics-only languages do, as well, have the default of results for :exports. I have the impression the problem is to search in `ob-core' (`org-babel-execute-src-block') or `ob-exp'... But that's not yet clear to me where that could be. I think I found it. That was a priority order problem for implementing the hierarchy of header arguments inheritage in `ob-core'. Best regards, Seb From 3339c0f7d296fc68a206b0f69270da3a91025840 Mon Sep 17 00:00:00 2001 From: Sebastien Vauban sva-n...@invalid.mygooglest.com Date: Sat, 27 Apr 2013 11:40:25 +0200 Subject: [PATCH 2/2] Fix priority order for inheriting header arguments * ob-core.el (org-babel-parse-src-block-match): Fix order of list of header arguments. --- lisp/ob-core.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/ob-core.el b/lisp/ob-core.el index 9baff0c..73dca8f 100644 --- a/lisp/ob-core.el +++ b/lisp/ob-core.el @@ -1,6 +1,6 @@ ;;; ob-core.el --- working with code blocks in org-mode -;; Copyright (C) 2009-2012 Free Software Foundation, Inc. +;; Copyright (C) 2009-2013 Free Software Foundation, Inc. ;; Authors: Eric Schulte ;; Dan Davison @@ -1323,8 +1323,8 @@ may be specified in the properties of the current outline entry. (buffer-string))) (org-babel-merge-params org-babel-default-header-args - (org-babel-params-from-properties lang) (if (boundp lang-headers) (eval lang-headers) nil) + (org-babel-params-from-properties lang) (org-babel-parse-header-arguments (org-no-properties (or (match-string 4) switches -- 1.7.9 -- Sebastien Vauban
[O] [PATCH] Re: Can't export LaTeX source code blocks
Sebastien Vauban wrote: Thomas S. Dye wrote: Sebastien Vauban writes: The code block is NEVER exported. I don't understand why? I'm not sure either. I took a quick look at ob-latex.el. The code there sets `:exports results' and then, IIUC, goes on its way without checking if :exports has been set in the buffer. It looks to me like ob-latex.el would need to be revised. I don't have the impression that the error lies in `ob-latex' as the other `ob-LANG' files don't either make any special check -- while all graphics-only languages do, as well, have the default of results for :exports. I have the impression the problem is to search in `ob-core' (`org-babel-execute-src-block') or `ob-exp'... But that's not yet clear to me where that could be. I think I found it. That was a priority order problem for implementing the hierarchy of header arguments inheritage in `ob-core'. Best regards, Seb From 3339c0f7d296fc68a206b0f69270da3a91025840 Mon Sep 17 00:00:00 2001 From: Sebastien Vauban sva-n...@invalid.mygooglest.com Date: Sat, 27 Apr 2013 11:40:25 +0200 Subject: [PATCH 2/2] Fix priority order for inheriting header arguments * ob-core.el (org-babel-parse-src-block-match): Fix order of list of header arguments. --- lisp/ob-core.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/ob-core.el b/lisp/ob-core.el index 9baff0c..73dca8f 100644 --- a/lisp/ob-core.el +++ b/lisp/ob-core.el @@ -1,6 +1,6 @@ ;;; ob-core.el --- working with code blocks in org-mode -;; Copyright (C) 2009-2012 Free Software Foundation, Inc. +;; Copyright (C) 2009-2013 Free Software Foundation, Inc. ;; Authors: Eric Schulte ;; Dan Davison @@ -1323,8 +1323,8 @@ may be specified in the properties of the current outline entry. (buffer-string))) (org-babel-merge-params org-babel-default-header-args - (org-babel-params-from-properties lang) (if (boundp lang-headers) (eval lang-headers) nil) + (org-babel-params-from-properties lang) (org-babel-parse-header-arguments (org-no-properties (or (match-string 4) switches -- 1.7.9 -- Sebastien Vauban
