Re: [O] [PATCH] datetree: Recognize year headline with tags as a match

2013-02-25 Thread Tim Burt
Jeffrey Brent McBeth  writes:

> On Mon, Feb 25, 2013 at 10:48:16AM +0100, Bastien wrote:
>> Hi Tim,
>> 
>> Tim Burt  writes:
>> 
>> > * lisp/org-datetree.el (org-datetree-find-year-create):
>> >  Include regexp for tags.  Syntax was taken directly
>> >  from org-todo-line-tags-regexp in org.el.
>> 
>> Applied, thanks a lot for the patch and the detailed change log!
>> 
>> Best,
>
> I can confirm that latest git fixes my use case.  Thank you both so much.

Excellent all the way 'round.


>
> Jeff

-- 
Tim Burt
www.rketburt.org
"It is healthful to every sane man to utter the art within him;" -- GK 
Chesterton



Re: [O] [PATCH] datetree: Recognize year headline with tags as a match

2013-02-25 Thread Jeffrey Brent McBeth
On Mon, Feb 25, 2013 at 10:48:16AM +0100, Bastien wrote:
> Hi Tim,
> 
> Tim Burt  writes:
> 
> > * lisp/org-datetree.el (org-datetree-find-year-create):
> >   Include regexp for tags.  Syntax was taken directly
> >   from org-todo-line-tags-regexp in org.el.
> 
> Applied, thanks a lot for the patch and the detailed change log!
> 
> Best,

I can confirm that latest git fixes my use case.  Thank you both so much.

Jeff

-- 
"The man who does not read good books has no advantage over 
 the man who cannot read them."
 -- Mark Twain



Re: [O] [PATCH] datetree: Recognize year headline with tags as a match

2013-02-25 Thread Bastien
Hi Tim,

Tim Burt  writes:

> * lisp/org-datetree.el (org-datetree-find-year-create):
> Include regexp for tags.  Syntax was taken directly
> from org-todo-line-tags-regexp in org.el.

Applied, thanks a lot for the patch and the detailed change log!

Best,

-- 
 Bastien



[O] [PATCH] datetree: Recognize year headline with tags as a match

2013-02-24 Thread Tim Burt

* lisp/org-datetree.el (org-datetree-find-year-create):
  Include regexp for tags.  Syntax was taken directly
  from org-todo-line-tags-regexp in org.el.

Change made to fix the problem where a year headline of a
datetree was not matched if it had a tag.  The :NOEXPORT: tag
is one useful case that should be matched.

Initial problem observation reported by Jeffrey McBeth on the
org-mode mailing list.

TINYCHANGE
---
 lisp/org-datetree.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-datetree.el b/lisp/org-datetree.el
index f2e35fa..0102393 100644
--- a/lisp/org-datetree.el
+++ b/lisp/org-datetree.el
@@ -72,7 +72,7 @@ tree can be found."
   (goto-char (prog1 (point) (widen))
 
 (defun org-datetree-find-year-create (year)
-  (let ((re "^\\*+[ \t]+\\([12][0-9][0-9][0-9]\\)\\s-*$")
+  (let ((re "^\\*+[ \t]+\\([12][0-9][0-9][0-9]\\)\\(.*?\\([ 
\t]:[[:alnum:]:_@#%]+:\\)?\\s-*$\\)")
match)
 (goto-char (point-min))
 (while (and (setq match (re-search-forward re nil t))
-- 
1.7.11.7