Re: [O] [PATCH] ob-shell: honor the specified shell for :session

2014-07-28 Thread Bastien
Hi Achim, Achim Gratz writes: > I've added all user-visible changes from me that will go into 8.3. Thanks for this. Any committer can add visible changes from anyone, so please feel free. Best, -- Bastien

Re: [O] [PATCH] ob-shell: honor the specified shell for :session

2014-06-30 Thread Achim Gratz
Bastien writes: > In the perspective of Org 8.3, we need to start updating etc/ORG-NEWS. Done. > Regardless of whether this was documented in the official manual or > not, a note in ORG-NEWS would be useful -- feel free to start editing > this file. I've added all user-visible changes from me th

Re: [O] [PATCH] ob-shell: honor the specified shell for :session

2014-06-25 Thread Bastien
Hi Achim, thanks for this. Achim Gratz writes: > In the case you mention above shell-file-name is used. Which means that > if you change it in a running emacs session, then it will be picked up > for shell blocks (as one might reasonably expect), whereas you would > have had to change org-babe

Re: [O] [PATCH] ob-shell: honor the specified shell for :session

2014-06-23 Thread Achim Gratz
Eric Schulte writes: > I thought that `org-babel-sh-command' was still used if code blocks used > the keyword "shell" as the language. If that's not the case and there > really is no more use for `org-babel-sh-command', then please go ahead > and apply this patch. Done on master. In the case you

Re: [O] [PATCH] ob-shell: honor the specified shell for :session

2014-06-22 Thread Eric Schulte
I thought that `org-babel-sh-command' was still used if code blocks used the keyword "shell" as the language. If that's not the case and there really is no more use for `org-babel-sh-command', then please go ahead and apply this patch. Thanks, -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0

[O] [PATCH] ob-shell: honor the specified shell for :session

2014-06-22 Thread Achim Gratz
When using a shell block with a :session, the specified shell is ignored and the original value of org-babel-sh-command (defaulting to the value of shell-file-name as set at load-time) gets used. The following patch fixes this, however there are still several other problems with how shells are in