Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-10 Thread Anton Latukha
Please.I tried to explain myself, but I see the more I explain myself, and write - the more people would assume the things that not correspond to reality.I not even started the work, or shown changes. And I already received a bunch of recommendations and people being concern, and people confusing t

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-10 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Well, after re-reading my letter - it obviously probably comes off as > being very strong and ambitious. I am pretty cool-headed about > everything. I am aware of that I need to gradual do ideally clean and > 100% compatible changes, I looked at the code - and the

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-09 Thread Samuel Wales
i don't use the priority stuff, but i think it could perhaps be useful to use terminology to distinguish the priority stuff from the priority stuff. i.e. 1] the stuff i don't use that you are talking about 2] [#A] and all that when i was a beginner i got confused by that. :) On 10/9/19, Adam

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-09 Thread Adam Porter
Hi Anton, Nicolas, et al, I'm in favor of tidying up the priority-related code, as I also have found it hard to follow. But please do not change the API of these functions, i.e. the signatures and return values. Their output is used in other packages, including some of mine like org-rifle, org-s

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Anton Latukha
Well, after re-reading my letter - it obviously probably comes off as being very strong and ambitious. I am pretty cool-headed about everything. I am aware of that I need to gradual do ideally clean and 100% compatible changes, I looked at the code - and the changes needed are at the pretty simple

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Anton Latukha
Ok.I would tend to it.This hardcode goes through several org.el functions. The main custom priority (priority retrieval) function should be already working and accepted in the whole Org system. But that hardcode expectation of (* 1000 ..) should be moved-out of the main priority functions and be su

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Another two small patches. Please merge the two patches and factor out the (- org-lowest-priority ...) while you're at it. Thank you. Regards, -- Nicolas Goaziou

[O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-09-28 Thread Anton Latukha
Another two small patches.(First I subscribed mail profile with a `name+tag@mail` format, after that understood that I can receive messages, but I can not write back from that tag address. Still do not see or know, if I reached the mailing list with the patches). $ make test---Ran 808 tests, 80