Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Aaron Ecay writes: > Checking the source, date-to-time can raise an error (invalid date). > format-time-string is a C function, so it’s less easy for me to > understand. But it looks like if it raises any errors, these are bugs > that we want to know about and not suppress.

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Hi Jan, 2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen: [...] >> Also, what is ignore-errors protecting? The call to date-to-time, or >> format-time-string? I think the scope of ignore-errors should be as >> narrow as it can be. > > I have no idea. I moved these lines from org-gnus,

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Aaron Ecay writes: > Can you introduce a let binding so that (date-to-time x) is only called > once? Ok. > Also, what is ignore-errors protecting? The call to date-to-time, or > format-time-string? I think the scope of ignore-errors should be as > narrow as it can be. I

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Hi Jan, 2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen: [...] > diff --git a/lisp/org.el b/lisp/org.el > index c466870..cf0ef1f 100755 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -9960,7 +9960,7 @@ active region." >(car org-stored-links)) > > (defun org-store-link-props (

[O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

* lisp/org.el (org-store-link-props): Rewrite function to get date-timestamp* calculations. * lisp/org-gnus.el: * lisp/org-mhe.el: * lisp/org-rmail.el: * contrib/lisp/org-mew.el: * contrib/lisp/org-vm.el: * contrib/lisp/org-wl.el: Remove date-timestamp* copy-paste. * doc/org.texi: Fix